stx-sdo-helm build failure

[Scott Little]

Brief Description
-----------------
New stx-sdo-helm package causes build failures

Severity
--------
Major

Steps to Reproduce
------------------
build-pkgs --clean
build-pkgs
or
build-pkgs stx-sdo-helm

Expected Behavior
------------------
all package build

Actual Behavior
----------------
stx-sdo-helm fails to build

Reproducibility
---------------
~50%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
March 1, 2021

Only new commit was ...
./cgcs-root/stx/SDO-rv-service 58aa9e92bcdd80271c83efed051c575080533e1d Fri Feb 26 05:22:42 2021 +0530 Poornima commit for stx-sdo-armada-app

Last Pass
---------
Feb 28

Timestamp/Logs
--------------
+ cd /builddir/build/BUILD
+ cd stx-sdo-helm-1.0
+ cp /usr/lib/helm/helm-toolkit-0.1.0.tgz helm-charts/
cp: cannot stat '/usr/lib/helm/helm-toolkit-0.1.0.tgz': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.Bbyfka (%build)
    Bad exit status from /var/tmp/rpm-tmp.Bbyfka (%build)
RPM build errors:
Child return code was: 1

Test Activity
-------------
Build

Workaround
----------
None

[Poornima Y N (poornimayn)]

Hi,
I am trying to reproduce the issue, but not able to reproduce on my build set-up till now.
Here are the tries I have done on my local set-up:
1. Synced to latest master on 3rd March 2021 and did clean build. flock build was success
2. Synced latest master code for flock and cherry picked the patch https://review.opendev.org/c/starlingx/SDO-rv-service/+/768181 and did a clean build. Flock build is success this case also.
3. Did a fresh build from scratch, compiler build was success and distro was giving issue. I'm trying to fix this issue now.

Attaching the success logs.

[Ghada Khalil (gkhalil)]

stx.5.0 / high - build issue related to new stx.5.0 feature

[Poornima Y N (poornimayn)]

I'm not able to reproduce the issue even with the latest build. Which is build from scratch.
Scott/ Davlet/ Saul, Please help to reproduce the issue. Is there any environment changes from the local workstation set-up and the standard CI/CD build?.
Thanks in advance for the help!

Attaching the logs of the success flock build.

[Poornima Y N (poornimayn)]

Hi Ghada,
I'm not able to reproduce the issue even with the latest build, which is build from scratch.
Scott/ Davlet/ Saul, Please help to reproduce the issue. Is there any environment changes from the local workstation set-up and the standard CI/CD build?.
Thanks in advance for the help!

Attaching the success case flock build with SDO component.

[Scott Little (slittle1)]

use 'build-pkgs --dep-test stx-sdo-helm'

[Poornima Y N (poornimayn)]

submitted patch fixing the issue. Please refer https://review.opendev.org/c/starlingx/SDO-rv-service/+/779432

[Poornima Y N (poornimayn)]

Hi Scott, Please review the patch. It is better that If you can help to cherry-pick and test in your environment.

Thanks,
Poornima

[Ghada Khalil (gkhalil)]

Review merged on 2021-03-12
https://review.opendev.org/c/starlingx/SDO-rv-service/+/779432

Marking as Fix Released