haproxy fails to start after subcloud upgrade-activate

Bug #1916279 reported by Andy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Andy

Bug Description

Brief Description
-----------------
After running upgrade-activate on the subcloud haproxy went offline. This caused an outage of many services. This was caused by an empty /etc/ssl/private/admin-ep-cert.pem file. The file appears to have been cleared by the upgrade script 85-update-sc-admin-endpoint-cert.py.

There were no errors in the logs from 85-update-sc-admin-endpoint-cert.py. Because the upgrade-activate completed there was no way to re-run the upgrade script. I had to manually generate/populate admin-ep-cert.pem file.

We need to at least validate the data before we write it to the admin-ep-cert.pem file. It the data is empty or not an x509 cert we need to fail the script and leave the file intact.

Severity
--------
Major

Steps to Reproduce
------------------
Upgrade subcloud from 20.06 to 20.12
Run upgrade-activate

Expected Behavior
------------------
admin-ep-cert.pem is populated correctly. haproxy restarts successfully

Actual Behavior
----------------
admin-ep-cert.pem is empty. haproxy fails to start

Reproducibility
---------------
Likely intermittent

System Configuration
--------------------
VBox DC system. AIO-DX system controller, AIO-SX subcloud

Branch/Pull Time/Commit
-----------------------
Latest from master

Last Pass
---------
Unknown

Timestamp/Logs
--------------
Starts around

2021-01-28T00:46:15.308 controller-0 configassistant[185783] info /etc/upgrade.d/85-update-sc-admin-endpoint-cert.py:140 INFO [__main__] Subcloud admin endpoint certificate updated successfully

Test Activity
-------------
Developer Testing

Workaround
----------
Run
kubectl --kubeconfig=/etc/kubernetes/admin.conf get secret sc-adminep-certificate -n sc-cert -o=jsonpath='{.data.tls\.crt}' | base64 --decode
kubectl --kubeconfig=/etc/kubernetes/admin.conf get secret sc-adminep-certificate -n sc-cert -o=jsonpath='{.data.tls\.key}' | base64 --decode
Write the output to
/etc/ssl/private/admin-ep-cert.pem
cp /etc/ssl/private/admin-ep-cert.pem /opt/platform/config/20.12/admin-ep-cert.pem

Andy (andy.wrs)
Changed in starlingx:
assignee: nobody → Andy (andy.wrs)
status: New → In Progress
Ghada Khalil (gkhalil)
tags: added: stx.5.0 stx.update
Changed in starlingx:
importance: Undecided → Medium
Revision history for this message
Andy (andy.wrs) wrote :
Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793460

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793696

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/794611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/794906

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on config (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/794611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8)
Download full text (147.3 KiB)

Reviewed: https://review.opendev.org/c/starlingx/config/+/794906
Committed: https://opendev.org/starlingx/config/commit/75758b37a5a23c8811355b67e2a430a1713cd85b
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 9e420d9513e5fafb1df4d29567bc299a9e04d58d
Author: Bin Qian <email address hidden>
Date: Mon May 31 14:45:52 2021 -0400

    Add more logging to run docker login

    Add error log for running docker login. The new log could
    help identify docker login failure.

    Closes-Bug: 1930310
    Change-Id: I8a709fb6665de8301fbe3022563499a92b2a0211
    Signed-off-by: Bin Qian <email address hidden>

commit 31c77439d2cea590dfcca13cfa646522665f8686
Author: albailey <email address hidden>
Date: Fri May 28 13:42:42 2021 -0500

    Fix controller-0 downgrade failing to kill ceph

    kill_ceph_storage_monitor tried to manipulate a pmon
    file that does not exist in an AIO-DX environment.

    We no longer invoke kill_ceph_storage_monitor in an
    AIO SX or DX env.

    This allows: "system host-downgrade controller-0"
    to proceed in an AIO-DX environment where that second
    controller (controller-0) was upgraded.

    Partial-Bug: 1929884
    Signed-off-by: albailey <email address hidden>
    Change-Id: I633853f75317736084feae96b5b849c601204c13

commit 0dc99eee608336fe01b58821ea404286371f1408
Author: albailey <email address hidden>
Date: Fri May 28 11:05:43 2021 -0500

    Fix file permissions failure during duplex upgrade abort

    When issuing a downgrade for controller-0 in a duplex upgrade
    abort and rollback scenario, the downgrade command was failing
    because the sysinv API does not have root permissions to set
    a file flag.
    The fix is to use RPC so the conductor can create the flag
    and allow the downgrade for controller-0 to get further.

    Partial-Bug: 1929884
    Signed-off-by: albailey <email address hidden>
    Change-Id: I913bcad73309fe887a12cbb016a518da93327947

commit 7ef3724dad173754e40b45538b1cc726a458cc1c
Author: Chen, Haochuan Z <email address hidden>
Date: Tue May 25 16:16:29 2021 +0800

    Fix bug rook-ceph provision with multi osd on one host

    Test case:
    1, deploy simplex system
    2, apply rook-ceph with below override value
    value.yaml
    cluster:
      storage:
        nodes:
        - name: controller-0
          devices:
          - name: sdb
          - name: sdc
    3, reboot

    Without this fix, only osd pod could launch successfully after boot
    as vg start with ceph could not correctly add in sysinv-database

    Closes-bug: 1929511

    Change-Id: Ia5be599cd168d13d2aab7b5e5890376c3c8a0019
    Signed-off-by: Chen, Haochuan Z <email address hidden>

commit 23505ba77d76114cf8a0bf833f9a5bcd05bc1dd1
Author: Angie Wang <email address hidden>
Date: Tue May 25 18:49:21 2021 -0400

    Fix issue in partition data migration script

    The created partition dictonary partition_map is not
    an ordered dict so we need to sort it by its key -
    device node when iterating it to adjust the device
    nodes/paths for user created extra partitions to ensure
    the number of device node...

tags: added: in-f-centos8
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on config (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793696

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793460

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.