Brief Description
-----------------
The pep8/flake8 tox and zuul targets that use bugbear (like distributed cloud) sometimes fail
depending on the python environment.
This is because the upper-constraints expect
attrs 19.0.1
bugbear 20.1.1 added code that requires attrs 19.0.2
bugbear did not properly 'enforce' that requirements until a later release of bugbear, so the flake8 test can randomly fail in python3 systems
Severity
--------
Minor - This does not appear to impact zuul, and local designers only see it on certain developer setups.
Steps to Reproduce
------------------
cd distributedcloud/distributedcloud
tox -e pep8
Expected Behavior
------------------
Should pass
Actual Behavior
----------------
stx/distributedcloud/distributedcloud/.tox/pep8/lib/python3.6/site-packages/bugbear.py", line 150, in visit_ExceptHandler
names.append("{}.{}".format(e.value.id, e.attr))
AttributeError: 'Attribute' object has no attribute 'id'
Reproducibility
---------------
This is seen in certain designer environments.
The version of pip may also be a factor.
System Configuration
--------------------
N/A
Branch/Pull Time/Commit
-----------------------
N/A
Last Pass
---------
I can reliably get this to pass in one env and reliably fail in another with the same code in both.
Timestamp/Logs
--------------
stx/distributedcloud/distributedcloud/.tox/pep8/lib/python3.6/site-packages/bugbear.py", line 150, in visit_ExceptHandler
names.append("{}.{}".format(e.value.id, e.attr))
AttributeError: 'Attribute' object has no attribute 'id'
Test Activity
-------------
Development
Workaround
----------
The workaround is to explicitly set the version of bugbear to be 20.1.0
20.1.1 introduced the code that expects the new version of attrs, and the 'stein' upper constraints does not permit the higher version of attrs from being used.
low priority - would be nice to fix to avoid impacts to developer environments, but doesn't seem to be causing zuul failures on submissions as per the reporter's comments