API docs for showing the attributes of a specific PCI device's URL is incorrect

Bug #1907074 reported by Xinxin Shen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Xinxin Shen

Bug Description

I get an error when using the API interface (/v1/devices/​{device_id}) in the API documentation.

1.Execute the following URL command
  curl -i http://192.168.34.2:6385/v1/devices/22f0497c-0a09-41c4-8514-cb5afcbf930d -X GET -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: ${TOKEN}"

 The following results are returned:
 HTTP/1.1 404 Not Found
 Content-Type: application/json
 Content-Length: 85
 Date: Mon, 07 Dec 2020 17:25:10 GMT
 {"error_message": "{\"code\": 404, \"description\": \"\", \"title\": \"Not Found\"}"}

2.Error cause analysis
a.The API docs documentation is incorrect, the URL interface in the api documentation is
 /v1/devices/​{device_id}
https://docs.starlingx.io/api-ref/config/api-ref-sysinv-v1-config.html?expanded=shows-the-attributes-of-a-specific-pci-device-detail#profiles
b.The url in the code interface in the code is /v1/pci_devices/{device_id}, which is inconsistent with the
  api docs
https://github.com/starlingx/config/blob/master/sysinv/cgts-client/cgts-client/cgtsclient/v1/pci_device.py#L28

During the analysis, I found that the interface "Modifies a specific PCI device" also has corresponding problems, that is, the API document is /v1/devices/​{device_id}, but the code is /v1/pci_devices/​{device_id}
https://github.com/starlingx/config/blob/master/sysinv/cgts-client/cgts-client/cgtsclient/v1/pci_device.py#L35

Xinxin Shen (runsxx)
information type: Public → Private
Xinxin Shen (runsxx)
information type: Private → Public
Xinxin Shen (runsxx)
Changed in starlingx:
assignee: nobody → Xinxin Shen (runsxx)
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Low severity - inaccurate API documentation

tags: added: stx.config stx.docs
Changed in starlingx:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
M Camp (mcamp859) wrote :

Thanks Xinxin Shen for this LP and for the review to update the API documentation.
Adding the link to the review here: https://review.opendev.org/c/starlingx/config/+/765892

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
M Camp (mcamp859) wrote :

Changed status to Fix Released since the review has merged.

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793460

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793696

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/794611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/794906

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on config (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/794611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8)
Download full text (147.3 KiB)

Reviewed: https://review.opendev.org/c/starlingx/config/+/794906
Committed: https://opendev.org/starlingx/config/commit/75758b37a5a23c8811355b67e2a430a1713cd85b
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 9e420d9513e5fafb1df4d29567bc299a9e04d58d
Author: Bin Qian <email address hidden>
Date: Mon May 31 14:45:52 2021 -0400

    Add more logging to run docker login

    Add error log for running docker login. The new log could
    help identify docker login failure.

    Closes-Bug: 1930310
    Change-Id: I8a709fb6665de8301fbe3022563499a92b2a0211
    Signed-off-by: Bin Qian <email address hidden>

commit 31c77439d2cea590dfcca13cfa646522665f8686
Author: albailey <email address hidden>
Date: Fri May 28 13:42:42 2021 -0500

    Fix controller-0 downgrade failing to kill ceph

    kill_ceph_storage_monitor tried to manipulate a pmon
    file that does not exist in an AIO-DX environment.

    We no longer invoke kill_ceph_storage_monitor in an
    AIO SX or DX env.

    This allows: "system host-downgrade controller-0"
    to proceed in an AIO-DX environment where that second
    controller (controller-0) was upgraded.

    Partial-Bug: 1929884
    Signed-off-by: albailey <email address hidden>
    Change-Id: I633853f75317736084feae96b5b849c601204c13

commit 0dc99eee608336fe01b58821ea404286371f1408
Author: albailey <email address hidden>
Date: Fri May 28 11:05:43 2021 -0500

    Fix file permissions failure during duplex upgrade abort

    When issuing a downgrade for controller-0 in a duplex upgrade
    abort and rollback scenario, the downgrade command was failing
    because the sysinv API does not have root permissions to set
    a file flag.
    The fix is to use RPC so the conductor can create the flag
    and allow the downgrade for controller-0 to get further.

    Partial-Bug: 1929884
    Signed-off-by: albailey <email address hidden>
    Change-Id: I913bcad73309fe887a12cbb016a518da93327947

commit 7ef3724dad173754e40b45538b1cc726a458cc1c
Author: Chen, Haochuan Z <email address hidden>
Date: Tue May 25 16:16:29 2021 +0800

    Fix bug rook-ceph provision with multi osd on one host

    Test case:
    1, deploy simplex system
    2, apply rook-ceph with below override value
    value.yaml
    cluster:
      storage:
        nodes:
        - name: controller-0
          devices:
          - name: sdb
          - name: sdc
    3, reboot

    Without this fix, only osd pod could launch successfully after boot
    as vg start with ceph could not correctly add in sysinv-database

    Closes-bug: 1929511

    Change-Id: Ia5be599cd168d13d2aab7b5e5890376c3c8a0019
    Signed-off-by: Chen, Haochuan Z <email address hidden>

commit 23505ba77d76114cf8a0bf833f9a5bcd05bc1dd1
Author: Angie Wang <email address hidden>
Date: Tue May 25 18:49:21 2021 -0400

    Fix issue in partition data migration script

    The created partition dictonary partition_map is not
    an ordered dict so we need to sort it by its key -
    device node when iterating it to adjust the device
    nodes/paths for user created extra partitions to ensure
    the number of device node...

tags: added: in-f-centos8
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on config (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793696

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/config/+/793460

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.