[MultiOS][Yocto][duplex] controller-1 failed sometimes becaused docker login failed

[Jackie Huang]

Brief Description
-----------------
controller-1 failed sometimes becaused docker login failed

Severity
--------
Major

Steps to Reproduce
------------------
1. build the image according to https://opendev.org/starlingx/meta-starlingx/src/branch/master/README.md
2. Install AIO duplex controller-0 with the built out image
3. run ansiple playbootk
4. configure controller-0 after bootstrap and unlock
5. Install controller-1 and unlock

Expected Behavior
------------------
controller-1 unlock successfully

Actual Behavior
----------------
[sysadmin@controller-0 ~(keystone_admin)]$ system host-list
+----+--------------+-------------+----------------+-------------+--------------+
| id | hostname | personality | administrative | operational | availability |
+----+--------------+-------------+----------------+-------------+--------------+
| 1 | controller-0 | controller | unlocked | enabled | available |
| 4 | controller-1 | controller | unlocked | disabled | failed |
+----+--------------+-------------+----------------+-------------+--------------+

controller-1:~# grep Error: /var/log/puppet/2020-11-17-12-57-02_controller/puppet.log
2020-11-17T13:01:43.422 Error: docker login registry.local:9001 -u admin -p St8rlingX* returned 1 instead of one of [0]
2020-11-17T13:01:43.877 Error: /Stage[main]/Platform::Kubernetes::Master::Init/Exec[login local registry]/returns: change from notrun to 0 failed: docker login registry.local:9001 -u admin -p St8rlingX* returned 1 instead of one of [0]

Reproducibility
---------------
Intermittent

System Configuration
--------------------
Two node system, All-in-one duplex

Branch/Pull Time/Commit
-----------------------
Branch: master
Time: Nov 2 2020
Commit: 587e1dbcf2633770a9d6717fe5f84ab6b08de2bd

Last Pass
---------

Timestamp/Logs
--------------

Test Activity
-------------

Workaround
----------

[Ghada Khalil (gkhalil)]

Low / doesn't gate the next release as this is prep work for multi-os support which is not committed for stx.5.0