[MultiOS][Yocto] deplux failed to work with vlan

[Jackie Huang]

Brief Description
-----------------
deplux failed to work with vlan

Severity
--------
<Major: System/Feature is usable but degraded>

Steps to Reproduce
------------------
1. build the image according to https://opendev.org/starlingx/meta-starlingx/src/branch/master/README.md
2. Install AIO duplex controller-0 with the built out image
3. run ansiple playbootk
4. configure controller-0 after bootstrap and adding vlan interfaces:

source /etc/platform/openrc
OAM_IF=eno3
MGMT_IF=eno1
system host-if-modify controller-0 lo -c none
IFNET_UUIDS=$(system interface-network-list controller-0 | awk '{if ($6=="lo") print $4;}')
for UUID in $IFNET_UUIDS; do
    system interface-network-remove ${UUID}
done

system host-if-modify controller-0 $OAM_IF -n oam0
system host-if-modify controller-0 $MGMT_IF -n pxeboot0

system host-if-modify controller-0 oam0 -c platform/
system interface-network-assign controller-0 oam0 oam

system host-if-modify controller-0 pxeboot0 -c platform
system interface-network-assign controller-0 pxeboot0 pxeboot

system host-if-add -V 18 controller-0 mgmt0 vlan pxeboot0
system interface-network-assign controller-0 mgmt0 mgmt

system host-if-add -V 19 controller-0 cluster0 vlan pxeboot0
system interface-network-assign controller-0 cluster0 cluster-host

system ntp-modify ntpservers=ntp-1.wrs.com

echo ">>> Add OSDs to primary tier"
system host-disk-list controller-0
system host-disk-list controller-0 | awk '/\/dev\/sdb/{print $2}' | xargs -i system host-stor-add controller-0 {}
system host-disk-list controller-0 | awk '/\/dev\/sdc/{print $2}' | xargs -i system host-stor-add controller-0 {}
system host-stor-list controller-0
system host-unlock controller-0

5. controller-0 will be rebooted after unlock but failed with:
{code:java}
[ 669.939844] controller_config[12586]: [ERROR]
[ 669.947240] controller_config[12586]: Errors found. See /var/log/puppet/2020-11-13-05-29-32_controller/puppet.log for details
[ 669.961126] controller_config[12586]: *****************************************************
[ 669.970897] controller_config[12586]: *****************************************************
[ 669.980901] controller_config[12586]: Failed to run the puppet manifest (RC:1)
[ 669.990902] controller_config[12586]: *****************************************************
[ 670.000874] controller_config[12586]: *****************************************************
[ 670.010834] controller_config[12586]: Pausing for 5 seconds...

Expected Behavior
------------------
The controller-0 should be unlocked successfully

Actual Behavior
----------------
controller-0:~# grep Error: /var/log/puppet/2020-11-13-05-29-32_controller/puppet.log
2020-11-13T05:34:47.999 Error: ip addr replace 192.168.206.1/24 dev vlan19 returned 1 instead of one of [0]
2020-11-13T05:34:48.363 Error: /Stage[main]/Platform::Addresses/Network_address[cluster-host]/Exec[Configuring cluster-host IP address]/returns: change from notrun to 0 failed: ip addr replace 192.168.206.1/24 dev vlan19 returned 1 instead of one of [0]
2020-11-13T05:34:48.418 Error: ip addr replace 192.168.18.2/24 dev vlan18 returned 1 instead of one of [0]
2020-11-13T05:34:48.798 Error: /Stage[main]/Platform::Addresses/Network_address[mgmt]/Exec[Configuring mgmt IP address]/returns: change from notrun to 0 failed: ip addr replace 192.168.18.2/24 dev vlan18 returned 1 instead of one of [0]

Reproducibility
---------------
intermittent

System Configuration
--------------------
Two node system, All-in-one duplex

Branch/Pull Time/Commit
-----------------------
Branch: master
Time: Nov 2 2020
Commit: 587e1dbcf2633770a9d6717fe5f84ab6b08de2bd

Last Pass
---------

Timestamp/Logs
--------------

Test Activity
-------------

Workaround
----------

[Ghada Khalil (gkhalil)]

Low / doesn't gate the next release as this is prep work for multi-os support which is not committed for stx.5.0

[Jackie Huang (jackie-huang)]

Fixed by:
https://opendev.org/starlingx/meta-starlingx/commit/68abae8f87aeec04b478520843f84f1f81a562e3
https://opendev.org/starlingx/meta-starlingx/commit/f0589807ede82881add94063fc6ffe5321ad1021