schedtop field widths not large enough
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Low
|
Jim Gauld |
Bug Description
Brief Description
-----------------
The field width for TID and PID require wider fields. In recent kernels, now have 7 digits. This makes visual interpretation of schedtop much harder since columns don't line up when browsing engineering data.
Severity
--------
minor.
Steps to Reproduce
------------------
Collect schedtop data. Look at data.
Expected Behavior
------------------
Columns should line up.
Actual Behavior
----------------
Various fields are wider than the allotted field width.
Reproducibility
---------------
100 percent.
System Configuration
-------
All configs.
Branch/Pull Time/Commit
-------
N/A
Last Pass
---------
N/A
Timestamp/Logs
--------------
N/A
Test Activity
-------------
Engineering, Feature Testing, Developer Testing.
Workaround
----------
Manually update the schedtop source code.
-bash-4.2$ diff -u schedtop.ORIG schedtop
--- schedtop.ORIG 2020-09-18 15:50:47.300449000 -0400
+++ schedtop 2020-09-18 15:50:47.304448000 -0400
@@ -361,7 +361,7 @@
# Build up output line by specific area
my $L = ();
$L = '';
- $L .= sprintf "%6s %6s %6s ", "TID", "PID", "PPID";
+ $L .= sprintf "%7s %7s %7s ", "TID", "PID", "PPID";
if ($::opt_P{$::P_ps} != $::P_none) {
$L .= sprintf "%1s %2s %*s %2s %3s %4s ",
"S", "P", $w_aff, "AFF", "PO", "NI", "PR";
@@ -406,7 +406,7 @@
# Build up output line by specific area
$L = '';
- $L .= sprintf "%6d %6d %6d ",
+ $L .= sprintf "%7d %7d %7d ",
$tid, $::D_task{
if ($::opt_P{$::P_ps} != $::P_none) {
$L .= sprintf "%1s %2d %*s %2s %3d %4d ",
Changed in starlingx: | |
assignee: | nobody → Jim Gauld (jgauld) |
status: | New → In Progress |
Changed in starlingx: | |
importance: | Undecided → Low |
tags: | added: stx.tools |
Changed in starlingx: | |
status: | In Progress → Fix Released |
Fix proposed to branch: master /review. opendev. org/761470
Review: https:/