grub updates from puppet manifests aren't reflected in /etc/default/grub

[Don Penney]

Brief Description
-----------------
The grub.pp and compute.pp manifests use grubby to make changes to the grub cmdline, but these are not reflected in /etc/grub/default. If someone uses grub2-mkconfig to update the cmdline, the customizations made by the manifests are lost.

Severity
--------
Minor

Steps to Reproduce
------------------
Run grub2-mkconfig command to update the grub cmdline.

Expected Behavior
------------------
Customizations like the spectre options should remain on /proc/cmdline

Actual Behavior
----------------
Customizations are dropped. They will be re-applied by the manifests, but may require an additional reboot.

Reproducibility
---------------
Reproducible

Branch/Pull Time/Commit
-----------------------
starlingx/master, present Oct 26, 2020

Last Pass
---------
Issue present in original code introducing grubby calls

Workaround
----------
Additional lock/unlock of impacted node(s).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/759744

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/759744
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=4913d25a0f31efe97227868d218d5e1469be91ea
Submitter: Zuul
Branch: master

commit 4913d25a0f31efe97227868d218d5e1469be91ea
Author: Don Penney <email address hidden>
Date: Fri Oct 23 02:08:00 2020 -0400

    Update grub defaults from manifests

    This update adds a utility, puppet-update-default-grub.sh, that is
    called from the grub.pp and compute.pp manifests when they call grubby
    to update the grub cmdline. This ensures that the changes being made
    via grubby will have corresponding changes reflected in the grub
    defaults file, so that added options are not lost if the grub cmdline
    is updated via calls to grub2-mkconfig.

    Change-Id: Ibf74ddf9d0445e92dd8903c67e95901d856ad373
    Closes-Bug: 1901559
    Signed-off-by: Don Penney <email address hidden>

[Ghada Khalil (gkhalil)]

Re-opening as an issue was found with the handling of hugepage setting on the grub cmdline.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/762693

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/762693
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=1f7aa66c1dbf82509796157f1b108f8a1990e720
Submitter: Zuul
Branch: master

commit 1f7aa66c1dbf82509796157f1b108f8a1990e720
Author: Don Penney <email address hidden>
Date: Thu Nov 5 03:24:54 2020 -0500

    Handle hugepages params in grub audit

    The grub cmdline can have multiple hugepages config arguments, in
    pairs of hugepagesz and hugepages parameters. This commit extends the
    puppet-update-default-grub.sh audit to handle these parameters in
    pairs, allowing for multiple pairs.

    Change-Id: Ia3c431f25ae488987245929de7a451aa4a822f06
    Closes-Bug: 1901559
    Signed-off-by: Don Penney <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/762919