DC subcloud B&R restore fails pulling Ceph images

[Frank Miller]

Brief Description
-----------------
On a distributed cloud system using NetApp, if a B&R is done on a system controller followed by a B&R on a subcloud, the ceph images will fail to be pulled on the subcloud.

Severity
--------
Major

Steps to Reproduce
------------------
B&R on system controller
B&R on subcloud

Expected Behavior
------------------
All pods on the subcloud should recover after the restore is complete

Actual Behavior
----------------
CEPH pods do not recover on the subcloud and are in ImagePullBackOff state.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Distributed Cloud where NetApp is the storage backend on the system controller and ceph is used on the subclouds.

Branch/Pull Time/Commit
-----------------------
Master branch

Last Pass
---------
n/a

Timestamp/Logs
--------------
n/a

Test Activity
-------------
B&R testing

Workaround
----------
Images have to be manually added back to the system controller docker registry.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/752804

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/752805

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752804
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=e6c4bcc7d7ad2b1d88cb0c06d842345e983fb18d
Submitter: Zuul
Branch: master

commit e6c4bcc7d7ad2b1d88cb0c06d842345e983fb18d
Author: Ovidiu Poncea <email address hidden>
Date: Fri Sep 18 21:14:19 2020 +0300

    Back up local registry images for platform-integ-apps on DC central

    Rbd-provisioner images are not backed up on a DC central w/o Ceph
    even when they are added to additional_local_registry_images.
    This means that on restore of DC central they are no longer present
    in registry.local. This causes subclouds with Ceph enabled to fail
    restore (or apply) as they pull rbd-provisioner from central.

    This commit fixes this.

    Change-Id: I12310f694db6b53881646d1a3ee61b2a6f833d1b
    Closes-Bug: 1896272
    Signed-off-by: Ovidiu Poncea <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752805
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=1464e57f176d43bd348bdca1efffbe5e99c16de9
Submitter: Zuul
Branch: master

commit 1464e57f176d43bd348bdca1efffbe5e99c16de9
Author: Ovidiu Poncea <email address hidden>
Date: Fri Sep 18 21:07:33 2020 +0300

    Back up local registry images for platform-integ-apps on DC central

    Rbd-provisioner images are not backed up on a DC central w/o Ceph even
    when they are added to additional_local_registry_images. This means
    that on restore of DC central they are no longer present in
    registry.local. This causes subclouds with Ceph enabled to fail restore
    (or apply) as they pull rbd-provisioner from central.

    This commit fixes this.

    Change-Id: Iabc10f694db6b53881646d1a3ee61b2a6f833d1a
    Closes-Bug: 1896272
    Depends-On: I12310f694db6b53881646d1a3ee61b2a6f833d1b
    Signed-off-by: Ovidiu Poncea <email address hidden>