Bug #1895054 “flake8 failing on ubuntu-focal zuul machine” : Bugs : StarlingX

Revision history for this message

Ghada Khalil (gkhalil) wrote on 2020-09-09:

#1

Adding stx.3.0, 4.0 & 5.0 (master) tags as this issue will impact submissions to any of these branches.

Changed in starlingx:
importance:	Undecided → Critical
assignee:	nobody → Don Penney (dpenney)
tags:	added: stx.3.0 stx.4.0 stx.5.0 stx.zuul

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-09: Fix proposed to metal (master)

#2

Fix proposed to branch: master
Review: https://review.opendev.org/750819

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-09: Fix merged to utilities (master)

#3

Reviewed: https://review.opendev.org/750813
Committed: https://git.openstack.org/cgit/starlingx/utilities/commit/?id=5bc7a33773e947eef8caeb3f371afa816fbcb774
Submitter: Zuul
Branch: master

commit 5bc7a33773e947eef8caeb3f371afa816fbcb774
Author: Don Penney <email address hidden>
Date: Wed Sep 9 17:12:45 2020 -0400

Use newer flake8 to run on ubuntu-focal Zuul machines

    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

    The update removes the hacking constraint to use newer flake8. This
    also ignores new warnings/errors, which should be addressed in a
    future update to remove the ignores.

    Change-Id: Ib24639adeea4da3063fb403a8e8484937f9e1a9f
    Partial-Bug: 1895054
    Signed-off-by: Don Penney <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-09: Fix merged to metal (master)

#4

Reviewed: https://review.opendev.org/750819
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=fcae730d65fe145e76a3d384360327a6b8f61c44
Submitter: Zuul
Branch: master

commit fcae730d65fe145e76a3d384360327a6b8f61c44
Author: Don Penney <email address hidden>
Date: Wed Sep 9 17:59:49 2020 -0400

Use newer flake8 to run on ubuntu-focal Zuul machines

    flake8 3.5.0 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

    The update removes the version constraint to use newer flake8. This
    also ignores new warnings/errors, which should be addressed in a
    future update to remove the ignores.

    Change-Id: I16dc579f7ee803881c42ff6048ddd2f6bb0c553b
    Partial-Bug: 1895054
    Signed-off-by: Don Penney <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-10: Fix proposed to stx-puppet (master)

#5

Fix proposed to branch: master
Review: https://review.opendev.org/751004

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-10: Fix merged to stx-puppet (master)

#6

Reviewed: https://review.opendev.org/751004
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=49de3e954e3187da34b43f2093d244bcb47127d1
Submitter: Zuul
Branch: master

commit 49de3e954e3187da34b43f2093d244bcb47127d1
Author: Don Penney <email address hidden>
Date: Thu Sep 10 10:27:53 2020 -0400

Use newer flake8 to run on ubuntu-focal Zuul machines

    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

The update removes the version constraint to use newer flake8.

    Change-Id: I8f82c818fd9653da14f042fffa4acf304fd76789
    Partial-Bug: 1895054
    Signed-off-by: Don Penney <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-16: Fix merged to ha (master)

#7

Reviewed: https://review.opendev.org/752286
Committed: https://git.openstack.org/cgit/starlingx/ha/commit/?id=57225bb34ae5380c95dddd0e556847f7a17e3d61
Submitter: Zuul
Branch: master

commit 57225bb34ae5380c95dddd0e556847f7a17e3d61
Author: albailey <email address hidden>
Date: Wed Sep 16 13:01:03 2020 -0500

Use newer flake8 to run on ubuntu-focal Zuul machines

    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

The update removes the version constraint to use newer flake8.

    The linters can be run in python3.
    Pylint cannot be run in python3 because mysql-python is not
    compatable, so a new zuul job for pylint is now added.

    The flake8 errors that the newer version raises are all suppressed,
    and some of them should be addressed by someone with familiarity in
    this repo.

    Change-Id: Ida6447728d4175173c02130cb04a6013e4f966f9
    Partial-Bug: 1895054
    Signed-off-by: albailey <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-22: Fix merged to integ (master)

#8

Reviewed: https://review.opendev.org/753445
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=f779502f5a216d094cb5277cab65f268aa08956c
Submitter: Zuul
Branch: master

commit f779502f5a216d094cb5277cab65f268aa08956c
Author: Steven Webster <email address hidden>
Date: Tue Sep 22 16:20:02 2020 -0400

Use newer flake8 to run on ubuntu-focal Zuul machines

    flake8 3.6.0 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

    The update removes the version constraint to use newer flake8. This
    also ignores new warnings/errors, which should be addressed in a
    future update to remove the ignores

    Change-Id: Id22fb14e2cce76c2f4f5234abb3be4db68c70555
    Partial-Bug: 1895054
    Signed-off-by: Steven Webster <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-10-12: Fix proposed to utilities (f/centos8)

#9

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/757417

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-10-12: Fix merged to utilities (f/centos8)

#10

Reviewed: https://review.opendev.org/757417
Committed: https://git.openstack.org/cgit/starlingx/utilities/commit/?id=d29ed62e9e2413da3009b926aa3b274da516891a
Submitter: Zuul
Branch: f/centos8

commit d29ed62e9e2413da3009b926aa3b274da516891a
Author: Don Penney <email address hidden>
Date: Wed Sep 9 17:12:45 2020 -0400

Use newer flake8 to run on ubuntu-focal Zuul machines

    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

    The update removes the hacking constraint to use newer flake8. This
    also ignores new warnings/errors, which should be addressed in a
    future update to remove the ignores.

    Change-Id: Ib24639adeea4da3063fb403a8e8484937f9e1a9f
    Partial-Bug: 1895054
    Signed-off-by: Don Penney <email address hidden>

tags:

added: in-f-centos8

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-11-16: Fix merged to monitoring (master)

#11

Reviewed: https://review.opendev.org/761668
Committed: https://git.openstack.org/cgit/starlingx/monitoring/commit/?id=ee7ae99d4181293368fb1d5bce4e6e69ccffd815
Submitter: Zuul
Branch: master

commit ee7ae99d4181293368fb1d5bce4e6e69ccffd815
Author: albailey <email address hidden>
Date: Thu Nov 5 14:56:47 2020 -0600

Use newer flake8 on python3.8 zuul systems

    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

    Suppresses the following:
     W503 line break before binary operator
     W504 line break after binary operator
     W605 invalid escape sequence '\d'

     E117 over-indented
     E266 too many leading '#' for block comment
     E305 expected 2 blank lines after class or function definition, found 1
     E402 module level import not at top of file
     E722 do not use bare 'except'
     E741 ambiguous variable name 'I'

F632 use ==/!= to compare constant literals
F821 undefined name 'dpdk' (this is a flake8 bug)

    Change-Id: I6c2ef05d765b57b7be0b038d6e384cb2af589054
    Partial-Bug: 1895054
    Signed-off-by: albailey <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-11-16: Fix proposed to stx-puppet (f/centos8)

#12

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/762919

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-11-17: Fix proposed to integ (f/centos8)

#13

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/762968

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-11-17: Fix merged to fault (master)

#14

Reviewed: https://review.opendev.org/762907
Committed: https://git.openstack.org/cgit/starlingx/fault/commit/?id=42a9cfa8829dba61b78a4784c5dfbe582e53ec4f
Submitter: Zuul
Branch: master

commit 42a9cfa8829dba61b78a4784c5dfbe582e53ec4f
Author: albailey <email address hidden>
Date: Mon Nov 16 13:09:11 2020 -0600

Use newer flake8 on python3.8 zuul systems

    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

    Fixed:
     E117 over-indented
     E741 ambiguous variable name
     F841 local variable is assigned to but never used

    Per-Line-Suppressed:
     E402 module level import not at top of file
     F632 use ==/!= to compare constant literals

    Global Suppress:
     W504 line break after binary operator
     W605 invalid escape sequence

The suppressed errors can be fixed by later submissions.

    Change-Id: I2df3ece427f0c84ce16c1a82f4d9f0c9a5a6982b
    Partial-Bug: 1895054
    Signed-off-by: albailey <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-11-18: Change abandoned on integ (f/centos8)

#15

Change abandoned by Yong Fu (<email address hidden>) on branch: f/centos8
Review: https://review.opendev.org/762968

Don Penney (dpenney) on 2020-12-07

Changed in starlingx:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-04-22: Fix proposed to ha (f/centos8)

#16

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/ha/+/787550

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-19: Fix proposed to utilities (f/centos8)

#17

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/utilities/+/792213

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-19: Fix proposed to ha (f/centos8)

#18

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/ha/+/792251

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-19: Fix proposed to gui (f/centos8)

#19

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/792252

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-19: Fix merged to gui (f/centos8)

#20

Download full text (16.7 KiB)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/792252
Committed: https://opendev.org/starlingx/gui/commit/63d6de4701a7f21779ad9ea4060fce9ed85bc71f
Submitter: "Zuul (22348)"
Branch: f/centos8

commit e05e1a43531499d94cfb1e538683ee36eea92b43
Author: Teresa Ho <email address hidden>
Date: Thu May 13 23:04:04 2021 -0400

Do not display primary_reselect if not specified

If the attribute 'primary_reselect' is not specified, the sysinv API
will leave it as null and GUI will not display the attribute.

Closes-Bug: 1928461

Change-Id: I5b8ef8b29fb7775dde8607bb14cd733015269f82
Signed-off-by: Teresa Ho <email address hidden>

commit f1a4d30eca91c7a239ebd7479a56fef7870a4b2e
Author: Pablo Bovina <email address hidden>
Date: Fri May 7 16:59:50 2021 -0300

Display DataNetworks list

DataNetworks are listed for pci-sriov
under Create/Edit Interface forms.

    Closes-bug: 1927782
    Signed-off-by: Pablo Bovina <email address hidden>
    Change-Id: If927bb0facdec9e587a13354bef56eca5df08785

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu May 6 07:32:59 2021 -0400

In AIO-SX, interface edit rejected with Host administrative unlocked

    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".

    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.

    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):

    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected

Locked state:
all conversions (with network/datanetwork assignment) are accepted

Closes-Bug: 1925183

Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

commit ddcc4fd3ccb4c02580c71414345993252b089761
Author: Enzo Candotti <email address hidden>
Date: Tue May 4 11:08:57 2021 -0300

Enable add/edit Worker personality on DC AIO-DX's GUI

This update is to allow the option to add a new host with Worker
personality on Distributed Cloud mode.

Closes-Bug: 1927107

Signed-off-by: Enzo Candotti <email address hidden>
Change-Id: Idfed9352c7c6467014a2ed2cf10b70f6b470c28c

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fer...

Reviewed:  https://review.opendev.org/c/starlingx/gui/+/792252
Committed: https://opendev.org/starlingx/gui/commit/63d6de4701a7f21779ad9ea4060fce9ed85bc71f
Submitter: "Zuul (22348)"
Branch:    f/centos8

commit e05e1a43531499d94cfb1e538683ee36eea92b43
Author: Teresa Ho <teresa.ho@windriver.com>
Date:   Thu May 13 23:04:04 2021 -0400

Do not display primary_reselect if not specified
    
    If the attribute 'primary_reselect' is not specified, the sysinv API
    will leave it as null and GUI will not display the attribute.
    
    Closes-Bug: 1928461
    
    Change-Id: I5b8ef8b29fb7775dde8607bb14cd733015269f82
    Signed-off-by: Teresa Ho <teresa.ho@windriver.com>

commit f1a4d30eca91c7a239ebd7479a56fef7870a4b2e
Author: Pablo Bovina <pablo.bovina@windriver.com>
Date:   Fri May 7 16:59:50 2021 -0300

Display DataNetworks list
    
    DataNetworks are listed for pci-sriov
    under Create/Edit Interface forms.
    
    Closes-bug: 1927782
    Signed-off-by: Pablo Bovina <pablo.bovina@windriver.com>
    Change-Id: If927bb0facdec9e587a13354bef56eca5df08785

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <AndreFernandoZanella.Kantek@windriver.com>
Date:   Thu May 6 07:32:59 2021 -0400

In AIO-SX, interface edit rejected with Host administrative unlocked
    
    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".
    
    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.
    
    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):
    
    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected
    
    Locked state:
    all conversions (with network/datanetwork assignment) are accepted
    
    Closes-Bug: 1925183
    
    Signed-off-by: Andre Fernando Zanella Kantek <AndreFernandoZanella.Kantek@windriver.com>
    Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

commit ddcc4fd3ccb4c02580c71414345993252b089761
Author: Enzo Candotti <enzo.candotti@windriver.com>
Date:   Tue May 4 11:08:57 2021 -0300

Enable add/edit Worker personality on DC AIO-DX's GUI
    
    This update is to allow the option to add a new host with Worker
    personality on Distributed Cloud mode.
    
    Closes-Bug: 1927107
    
    Signed-off-by: Enzo Candotti <enzo.candotti@windriver.com>
    Change-Id: Idfed9352c7c6467014a2ed2cf10b70f6b470c28c

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fernando Zanella Kantek <AndreFernandoZanella.Kantek@windriver.com>
Date:   Thu Apr 29 06:33:50 2021 -0400

On AIO-SX's GUI, allow create/delete buttons for SRIOV-VF interfaces
    
    As part of the correction for this bug the user must be capable,
    through GUI, to create and delete subinterfaces on an unlocked system
    to handle SRIOV-VF interfaces, as it is permitted via CLI
    
    If the system is unlocked, a logic was added to prevent the create
    button to be displayed if no SRIOV-PF interface is present. The
    delete button will also only be shown if it is a SRIOV-VF interface
    
    Closes-Bug: 1925183
    
    Signed-off-by: Andre Fernando Zanella Kantek <AndreFernandoZanella.Kantek@windriver.com>
    Change-Id: I985383292affee5e1627b2c0c9a6455d16bbdfec

commit 180d8a7dcc78d1e9b10df4c103f95d32b116bb0e
Author: Andre Fernando Zanella Kantek <AndreFernandoZanella.Kantek@windriver.com>
Date:   Tue Apr 20 07:10:46 2021 -0400

Cant modify the interface without lock/unlock through GUI, in AIO-SX
    
    As part of storyboard 2008531 users should be able to modify the
    ethernet interface to SR-IOV from the CLI and Horizon's GUI. This
    correction enables the "Edit Interface" button if the system is
    AIO-SX, the interface is ethernet and the class isn't pci-sriov.
    
    Tested with GUI on AIO-SX and Standard setups as described on
    launchpad
    
    Closes-Bug: 1925183
    
    Signed-off-by: Andre Fernando Zanella Kantek <AndreFernandoZanella.Kantek@windriver.com>
    Change-Id: Ic60684eae123618506d15c8564a85230df7a605d

commit c308974419d1174df75a6d573e0f3c5a7d80e2ad
Author: Fernando Theirs <Fernando.Theirs@windriver.com>
Date:   Fri Apr 9 14:54:50 2021 -0300

Download openrc file for subclouds
    
    This change sets adminURL as secondary endpoint. When trying to
    download openrc file for subcloud-N, it is only allowed to use adminURL
    endpoint. Since publicURL is used by default, it is necessary to go
    to fallback option.
    
    Closes-Bug: 1923884
    
    Signed-off-by: Fernando Theirs <Fernando.Theirs@windriver.com>
    Change-Id: Ifd0a32a03a458ea99f8589a524e562220a9f0b74

commit eee41da9a22653132b53ca40a70659a220dab725
Author: Takamasa Takenaka <takamasa.takenaka@windriver.com>
Date:   Fri Apr 9 17:48:51 2021 -0300

Add new introduced deploy states to cloud overview panel
    
    Add the following deploy states to put the proper icon.
    [DANGER: Red icon]
    DEPLOY_STATE_DEPLOY_PREP_FAILED = 'deploy-prep-failed'
    DEPLOY_STATE_DATA_MIGRATION_FAILED = 'data-migration-failed'
    DEPLOY_STATE_RESTORE_PREP_FAILED = 'restore-prep-failed'
    DEPLOY_STATE_RESTORE_FAILED = 'restore-failed'
    [WARNING: Yellow icon]
    DEPLOY_STATE_PRE_DEPLOY = 'pre-deploy'
    DEPLOY_STATE_MIGRATING_DATA = 'migrating-data'
    DEPLOY_STATE_PRE_RESTORE = 'pre-restore'
    DEPLOY_STATE_RESTORING = 'restoring'
    [SUCCESS: Green icon]
    DEPLOY_STATE_INSTALLED = 'installed'
    DEPLOY_STATE_MIGRATED = 'migrated'
    
    (These deploy state is obtained from
    distributedcloud/dcmanager/common/consts.py)
    
    Closes-Bug: 1890503
    
    Signed-off-by: Takamasa Takenaka <takamasa.takenaka@windriver.com>
    Change-Id: I4bf6c98431639b85a5f6dc7dd40a598bd3cc3f88

commit 8e87f2c513eb492ab5f2b699eb875a47114b6e6c
Author: Jose Infanzon <jose.infanzon@windriver.com>
Date:   Fri Apr 9 15:33:08 2021 -0300

Horizon add of OSD journal ignores SIZE
    
    Set journal size. Truncate non integer values.
    
    Closes-Bug: 1907269
    
    Signed-off-by: Jose Infanzon <jose.infanzon@windriver.com>
    Change-Id: I125f93be452e3b95bd7d7bb040fb7d665d0d0f8d

commit 84b5d7979f0a8fe0409302c426d35e441afcb71e
Author: Teresa Ho <teresa.ho@windriver.com>
Date:   Mon Mar 15 22:11:15 2021 -0400

Add bond option primary_reselect in GUI
    
    This update is to allow the option primary_reselect configurable for
    aggregated ethernet interface. The option is to prevent reverting
    between the primary slave and other slaves.
    
    Story: 2008706
    Task: 42058
    Depends-On: https://review.opendev.org/c/starlingx/config/+/780863
    
    Change-Id: I6783542168518755b8148c8a4ee5dd58d4a7e703
    Signed-off-by: Teresa Ho <teresa.ho@windriver.com>

commit f097bc14a08a0a0b306474945cabf642f1927149
Author: Tyler Smith <tyler.smith@windriver.com>
Date:   Fri Feb 5 17:49:00 2021 -0500

starlingx_dashboard should enable optional security settings
    
    - Turning on ENFORCE_PASSWORD_CHECK to require admin password re-entry
      when updating password
    - Turning on disable_password_reveal so that passwords cannot be revealed
      in password fields
    
    Closes-bug: 1914831
    Signed-off-by: Tyler Smith <tyler.smith@windriver.com>
    Change-Id: I630839fd2b39ea3a9fca2b2e1d827404bc50f77d

commit 481e80014ce616981e7b2cdd849c207ff280d294
Author: Litao Gao <litao.gao@windriver.com>
Date:   Thu Jan 7 01:42:27 2021 -0500

Single NIC support in GUI
    
    This feature is to allow user to configure CaaS and Data networks
    to single VF capable NIC during ‘Host interface configuration’
    before unlock operation.
    
    This commit modify web gui to allow end use to create ethernet
    subinterface over pci-sriov class ethernet interface.
    And also activate delete button for the ethernet interface which
    uses other interface.
    
    Story: 2008470
    Task: 41507
    
    Depends-On: https://review.opendev.org/c/starlingx/config/+/770132
    Signed-off-by: Litao Gao <litao.gao@windriver.com>
    Change-Id: Ic1cf49a32ea7caefb2de91e32c322b9c29422dbf

commit 927bee2d66eff3e224b356cee72d5fb2bccbcaa8
Author: albailey <Al.Bailey@windriver.com>
Date:   Mon Dec 21 10:59:14 2020 -0600

Use newer flake8 to run on ubuntu-focal Zuul machines
    
    flake8 2.5.5  fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
    
    The update updates the version constraint to use newer flake8.
    
    pylint has been switched to running in python3 which has challenges
    related to the new pip resolver. The correct version of Django cannot
    be specified with the new resolver so the pylint errors caused
    by the newer version are suppressed for now.
    
    The docs targets for tox use their own install_command which
    does not include an upper constraint.
    
    A non ascii character was removed from the tox.ini file which
    prevented running tox on some ubuntu envs.
    
    Partial-Bug: 1895054
    Signed-off-by: albailey <Al.Bailey@windriver.com>
    Change-Id: Ic6a50c2ecf2a654fd883ed92fc305336741d4303

commit ed99d3960c67c6671a2f55b4bf2e6756128f9f4e
Author: Yuxing Jiang <yuxing.jiang@windriver.com>
Date:   Fri Aug 28 21:36:27 2020 -0400

Align OS_AUTH_URL in admin-openrc.sh
    
    The admin-openrc.sh can be downloaded from Horizon. This file can be
    used for authentication as sysadmin in system controllers. However,
    as the keystone public endpoint of region SystemController differs
    from the RegionOne. If a user download an RC file of SystemController
    and use the OS_AUTH_URL to authenticate, a HTTP 401 Error(The request
    you have made requires authentication) will be produced.
    
    In the upstream project, the OS_AUTH_URL is got according to the
    "Central Cloud Region" and shown in the view. This commit overwrites
    the openrc template, aligns the OS_AUTH_URL in the admin-openrc.sh of
    region SystemController with the RegionOne by port replacement. As it
    is a specific usage for starlingx rather than a generic usage, it will
    not go to the Horizon project.
    
    Test:
    1. Choose the "Central Cloud Region" in Horizon as "SystemController"
    2. Download the admin-openrc.sh via API Access -> Download OpenStack
    RC File
    3. Check the OS_AUTH_URL is pointing to then keystone pulic endpoint
    of RegionOne
    4. Check the keystone pulic endpoint is still correct in the web page
    
    Change-Id: I1f43f79364f5cc7bff382c1ae90a7f8f801abedb
    Closes-Bug: 1892090
    Signed-off-by: Yuxing Jiang <yuxing.jiang@windriver.com>

commit f18c0eaa83cd47d13d477acd2a48eb87908a845d
Author: Tyler Smith <tyler.smith@windriver.com>
Date:   Thu Aug 6 17:07:25 2020 -0400

Internal server error in gui when subcloud goes down
    
    - Adding checks to prevent user navigating to an offline subcloud
    - Adding a default service region when in DC mode to remove the
      possibility of a fresh user being defaulted to logging in to an
      offline subcloud
    
    Change-Id: Ia9d37ad1f977df7e08377677186cd59eae336b1c
    Closes-bug: 1890715
    Signed-off-by: Tyler Smith <tyler.smith@windriver.com>

commit 959427c8bd1c8d074f46ba5be310850e2ee817ae
Author: Kristine Bujold <kristine.bujold@windriver.com>
Date:   Mon Jul 20 15:38:38 2020 -0400

Fix managing/unmanaging subclouds
    
    Change that were done in https://opendev.org/starlingx/distcloud-client
    /commit/dd05eccb0826ad4047201d361abea20b7a788bf5 changed the
    dcmanagerclient update_subcloud API and caused the call to the API
    from Horizon to break.
    
    Closes-Bug: 1888301
    
    Change-Id: Ia009f625a402c5480e669f61d1630f7dc3ba589f
    Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>

commit 73b77d5d526af66bed2c41975635febedf685162
Author: Kristine Bujold <kristine.bujold@windriver.com>
Date:   Mon Jun 29 11:05:40 2020 -0400

Update restrictions on Physical Volume
    
    Physical Volume had restrictions which were no longer valid.
    
    Closes-Bug: 1860139
    Change-Id: I89e6c5aa429875171fc7e083e35057b61d920b95
    Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>

commit 4ef018429f244a835d126d77668fe06dc695b47e
Author: Kristine Bujold <kristine.bujold@windriver.com>
Date:   Tue Jun 30 11:57:58 2020 -0400

Fix Add Host button
    
    Fix bug with “Add Host" under "Admin/Platform/Host Inventory".
    
    Closes-Bug: 1862069
    Change-Id: If804422832828db5bf5f7003589acd5388297895
    Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>

commit c8a05a9960f2a2c047b937822451f69164f8187e
Author: Kristine Bujold <kristine.bujold@windriver.com>
Date:   Tue Jun 23 16:50:58 2020 -0400

Fix logging errors
    
    An invalid attribute was being set for HiddenInput
    
    Closes-Bug: 1884837
    Change-Id: I8ab337bf5f6124174ad394961d6bb136c3d06aa1
    Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>

commit 798b0c9f3f40335163c8f52e3f2eadc492221c33
Author: albailey <Al.Bailey@windriver.com>
Date:   Thu Jun 18 08:14:22 2020 -0500

Fix DC patch strategy commands in Horizon
    
    The patch strategy classes in DC client were refactored
    to support multiple update types by
    https://review.opendev.org/#/c/720457/
    
    The Horizon code now uses the updated classes and methods.
    
    Change-Id: Idf0711fcd1c4341c6b5599c2414ba49868117cb7
    Closes-Bug: 1883993
    Signed-off-by: albailey <Al.Bailey@windriver.com>

commit e1e3439059a1303e3e2f7b30cccdb0f80c2a6a59
Author: Kristine Bujold <kristine.bujold@windriver.com>
Date:   Tue Jun 9 11:32:50 2020 -0400

Prevent false negative user popups
    
    Checks were added to prevent false negative user pop ups to be raised.
    This could happen when a user is about to switch from the
    SystemController’s region to a subcloud. The error is caused by pending
    requests still in the queue from the SystemController’s.
    
    Closes-Bug: 1876792
    Change-Id: I54aeaeab61f9989015061382c16e80b569ed08bc
    Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>

commit 170ac040d2250ec5a26f2a39e4c7d5b49cfd6529
Author: Sharath Kumar K <sharath.kumar@intel.com>
Date:   Thu May 7 08:59:08 2020 +0200

Tox and Zuul job for the bandit code scan in stx/gui
    
    Setting up the bandit tool for the scanning of HIGH severity issues
    in the python codes under Starlingx/gui folder.
    Expecting this merge will enable zuul job for CI/CD of bandit scan.
    
    Configuration files:
    1. tox.ini for adding bandit environment and command.
    2. test-requirements.txt for adding bandit version.
    3. .zuul.yaml file for adding bandit job and configuring under
       check job to run code scan every time before code commit.
    
    Test:
    Run tox -e bandit command inside the fault folder to validate the
    bandit scan and result.
    
    Story: 2007541
    Task: 39683
    Depends-On: https://review.opendev.org/#/c/721294/
    
    Change-Id: I155c9f894f8b1d701f2c75e3e892e6b83a35b11e
    Signed-off-by: Sharath Kumar K <sharath.kumar@intel.com>

commit b4f16ab7e86a8cf9a75cd48a6a4cdb949835e065
Author: Andreas Jaeger <aj@suse.com>
Date:   Thu Jun 4 14:20:59 2020 +0200

Switch to newer openstackdocstheme and reno versions
    
    Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
    these versions will allow especially:
    * Linking from HTML to PDF document
    * Allow parallel building of documents
    * Fix some rendering problems
    
    Update Sphinx version as well.
    
    Disable openstackdocs_auto_name to use 'project' variable as name.
    
    Change pygments_style to 'native' since old theme version always used
    'native' and the theme now respects the setting and using 'sphinx' can
    lead to some strange rendering.
    
    Remove docs requirements from test-requirements.txt, they are not needed
    during install or test but only for docs building.
    
    openstackdocstheme renames some variables, so follow the renames
    before the next release removes them. A couple of variables are also
    not needed anymore, remove them.
    
    See also
    http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
    
    Change-Id: Id86f483b405c8fbc74b89ac085076b55e461d417

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-28: Fix merged to utilities (f/centos8)

#21

Download full text (29.4 KiB)

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/792213
Committed: https://opendev.org/starlingx/utilities/commit/c4d042615e6fe8944a4628fa1a29e86e012a9bf5
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 557cada006fd5a3bd81ad5af387c37657801f8c5
Author: Fernando Theirs <email address hidden>
Date: Thu May 13 16:21:47 2021 -0300

Collect is missing etcdctl output

    When the collect tool is run, it does not include the contents
    of the etcd database. Fixes have been made for this to dump the
    contents in "etcd_database.dump" file.

Verify if etcd access is secured. In that case, certificates
will be used.

Closes-Bug: 1911935

Signed-off-by: Fernando Theirs <email address hidden>
Change-Id: Idbc60edffa978a7a6bead939a4eb54f4abae29a6

commit 6045b1b8a0d8ed6a94d06cdfc994bf1a5fa9dbb5
Author: Jim Gauld <email address hidden>
Date: Thu May 6 11:58:34 2021 -0400

Provide utility script is-rootdisk-device.sh

    This provides a utility script to determine which disk contains the root
    filesystem. This can also be used as a helper function for io-scheduler
    udev rules that require specific configuration for root disk.

    Example usage:
    /usr/local/bin/is-rootdisk-device.sh
    ROOTDISK_DEVICE=sda

/usr/local/bin/is-rootdisk-device.sh /dev/sda
ROOTDISK_DEVICE=sda

/usr/local/bin/is-rootdisk-device.sh /dev/sdb
(i.e., no output)

    Partial-Bug: 1927515
    Signed-off-by: Jim Gauld <email address hidden>
    Change-Id: Ib0d4a161a407b08d294c5ff9aa0b7590961e18c9

commit 88a678f142cfe86c58b6405aae6babbc08de0e8f
Author: Chen, Haochuan Z <email address hidden>
Date: Fri Mar 26 09:09:41 2021 +0800

Add packages to stx-ceph-manager image

This update installs ceph-mgr, ceph-mon, ceph-osd packages as part
of stx-ceph-manager image.

Partial-Bug: 1920882

Change-Id: I4afde8b1476e14453fac8561f1edde7360b8ee96
Signed-off-by: Chen, Haochuan Z <email address hidden>

commit 09b3542fcc6cc0300a9cae0d302225e6977780f3
Author: Scott Little <email address hidden>
Date: Thu Mar 25 11:49:49 2021 -0400

Set SW_VERSION 21.05

Prep for the StarlingX 5.0 release.
SW_VERSION, also known as PLATFORM_RELEASE, uses YY.MM format.

    Story: 2008055
    Task: 42115
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: If7c91a2b523358269ae4850961cf4189ffcd7a75

commit ae4cefd0e2a0001476782c31e1003810da2b4838
Author: Chris Friesen <email address hidden>
Date: Thu Mar 4 18:04:12 2021 -0500

add dcmanager-audit-worker to patch restart script

Need to add the new process to the patch restart script.

    Story: 2007267
    Task: 41999
    Signed-off-by: Chris Friesen <email address hidden>
    Change-Id: If5faa806bd0d52ddbf1343b064959f4207cf975a

commit 27fce5a52321f3014fa8ae9181d344bc774289da
Author: Enzo Candotti <email address hidden>
Date: Mon Feb 1 12:47:38 2021 -0300

Add resource CPU and memory info in collect

This adds commands to collect more data to debug
resource allocations and...

Reviewed:  https://review.opendev.org/c/starlingx/utilities/+/792213
Committed: https://opendev.org/starlingx/utilities/commit/c4d042615e6fe8944a4628fa1a29e86e012a9bf5
Submitter: "Zuul (22348)"
Branch:    f/centos8

commit 557cada006fd5a3bd81ad5af387c37657801f8c5
Author: Fernando Theirs <Fernando.Theirs@windriver.com>
Date:   Thu May 13 16:21:47 2021 -0300

Collect is missing etcdctl output
    
    When the collect tool is run, it does not include the contents
    of the etcd database. Fixes have been made for this to dump the
    contents in "etcd_database.dump" file.
    
    Verify if etcd access is secured. In that case, certificates
    will be used.
    
    Closes-Bug: 1911935
    
    Signed-off-by: Fernando Theirs <Fernando.Theirs@windriver.com>
    Change-Id: Idbc60edffa978a7a6bead939a4eb54f4abae29a6

commit 6045b1b8a0d8ed6a94d06cdfc994bf1a5fa9dbb5
Author: Jim Gauld <james.gauld@windriver.com>
Date:   Thu May 6 11:58:34 2021 -0400

Provide utility script is-rootdisk-device.sh
    
    This provides a utility script to determine which disk contains the root
    filesystem. This can also be used as a helper function for io-scheduler
    udev rules that require specific configuration for root disk.
    
    Example usage:
    /usr/local/bin/is-rootdisk-device.sh
    ROOTDISK_DEVICE=sda
    
    /usr/local/bin/is-rootdisk-device.sh /dev/sda
    ROOTDISK_DEVICE=sda
    
    /usr/local/bin/is-rootdisk-device.sh /dev/sdb
    (i.e., no output)
    
    Partial-Bug: 1927515
    Signed-off-by: Jim Gauld <james.gauld@windriver.com>
    Change-Id: Ib0d4a161a407b08d294c5ff9aa0b7590961e18c9

commit 88a678f142cfe86c58b6405aae6babbc08de0e8f
Author: Chen, Haochuan Z <haochuan.z.chen@intel.com>
Date:   Fri Mar 26 09:09:41 2021 +0800

Add packages to stx-ceph-manager image
    
    This update installs ceph-mgr, ceph-mon, ceph-osd packages as part
    of stx-ceph-manager image.
    
    Partial-Bug: 1920882
    
    Change-Id: I4afde8b1476e14453fac8561f1edde7360b8ee96
    Signed-off-by: Chen, Haochuan Z <haochuan.z.chen@intel.com>

commit 09b3542fcc6cc0300a9cae0d302225e6977780f3
Author: Scott Little <scott.little@windriver.com>
Date:   Thu Mar 25 11:49:49 2021 -0400

Set SW_VERSION 21.05
    
    Prep for the StarlingX 5.0 release.
    SW_VERSION, also known as PLATFORM_RELEASE, uses YY.MM format.
    
    Story: 2008055
    Task: 42115
    Signed-off-by: Scott Little <scott.little@windriver.com>
    Change-Id: If7c91a2b523358269ae4850961cf4189ffcd7a75

commit ae4cefd0e2a0001476782c31e1003810da2b4838
Author: Chris Friesen <chris.friesen@windriver.com>
Date:   Thu Mar 4 18:04:12 2021 -0500

add dcmanager-audit-worker to patch restart script
    
    Need to add the new process to the patch restart script.
    
    Story: 2007267
    Task: 41999
    Signed-off-by: Chris Friesen <chris.friesen@windriver.com>
    Change-Id: If5faa806bd0d52ddbf1343b064959f4207cf975a

commit 27fce5a52321f3014fa8ae9181d344bc774289da
Author: Enzo Candotti <enzo.candotti@windriver.com>
Date:   Mon Feb 1 12:47:38 2021 -0300

Add resource CPU and memory info in collect
    
    This adds commands to collect more data to debug
    resource allocations and usage for the system
    and containerization.
    
    The following command outputs were added:
    system host-cpu-list <hostname>
    ctr -n k8s.io images list
    kubectl describe nodes | grep -e Capacity: -B1
      -A40 | grep -e 'System Info:' -B13 | grep
      -v 'System info:'
    lscpu
    lscpu -e
    cat /sys/devices/system/cpu/isolated
    
    Partial-Bug: 1886868
    
    Signed-off-by: Enzo Candotti <enzo.candotti@windriver.com>
    Change-Id: Ib26b4bb22d787451cc96820b3a413b410f79d49d

commit a4365bf1b2124c9587d78eff82594ce798fb7e06
Author: Enzo Candotti <enzo.candotti@windriver.com>
Date:   Mon Jan 25 13:16:55 2021 -0300

Fix clear passwords presented in collected log files
    
    The --relative option used by rsync resulted in changes
    to the paths of some collected files in the tarball,
    which in turn resulted in failures to mask the passwords
    in those files (as they were no longer in the expected
    location).
    
    This update removes the --relative option, restoring
    the location to that expected by the masking.
    
    Closes-Bug: 1906524
    
    Signed-off-by: Enzo Candotti <enzo.candotti@windriver.com>
    Change-Id: I001d3e2b1d2ec0ff88a129fe7b31bee21928686b

commit 5c8c8434389d67a24758ea36b9439ef946c46dfd
Author: Jose Infanzon <jose.infanzon@windriver.com>
Date:   Wed Dec 16 17:25:18 2020 -0300

Add new logs to the inventory info files
    
    Now collect_tool implements a new param
    '-i' when inventory info is required to
    be retrieved. By default it will not be
    executed.
    
    The following command outputs were added:
    system show
    system host-show <hostname>
    system host-port-list <hostname>
    system host-if-list <hostname>
    system interface-network-list <hostname>
    system network-list
    system host-memory-list <hostname>
    system host-label-list <hostname>
    system host-disk-list <hostname>
    system host-stor-list <hostname>
    system host-lvg-list <hostname>
    system host-pv-list <hostname>
    
    the execution of:
    
    -system host-show
    -system host-port-list
    -system host-if-list
    -system interface-network-list
    -system host-ethernet-port-list
    -system host-memory-list
    -system host-label-list
    -system host-disk-list
    -system host-stor-list
    -system host-lvg-list
    -system host-pv-list
    
    on a simplex lab, took 12 seconds to complete
    
    Story: 2008452
    Task: 41428
    
    Signed-off-by: Jose Infanzon <jose.infanzon@windriver.com>
    Change-Id: I223a3ef239a00a1e9dddb86d04874f13c33163e9

commit 538d47cb81317976a7ed31024a05d2fc6bf373bb
Author: Jim Gauld <james.gauld@windriver.com>
Date:   Fri Jan 15 16:06:16 2021 -0500

collect is missing helmv2 output
    
    This adds helm v2 outputs that we used to have before helm v3 upversion.
    This gives 'helm status' and 'helm get values' per application using
    helmv2-cli.
    
    This changes helm v3 commands to run as user sysadmin since helm is
    configured for sysadmin and not root. Otherwise there is missing
    environment and helm files when run via collect sudo.
    
    This corrects one complex expression that does not properly evaluate
    since it requires being run through command line first.
    
    Expressions like CMD="command1 | command2" needs to be run as:
     eval ${CMD}
    instead of just:
     ${CMD}
    e.g.,
     eval "cat filename | python -m json.tool"
    
    Closes-Bug: 1911933
    
    Signed-off-by: Jim Gauld <james.gauld@windriver.com>
    Change-Id: Ie13c78ae325ce0c2f506b320db3e9b51df3f74f2

commit cb00a00c15896b8ab493354e14287cfec29bf2d8
Author: Nicolas Alvarez <nicolas.alvarez@windriver.com>
Date:   Fri Dec 18 18:40:49 2020 -0300

Add new log to the device and interface info files.
    
    collector.spec: modify to add the new scripts with permissions.
    collector_disk: new bash script with smartctl command.
    collector_interfaces: new bash script with ethtool command.
    
    Story: 2008452
    Task: 41434
    
    Signed-off-by: Nicolas Alvarez <nicolas.alvarez@windriver.com>
    Change-Id: I4c7b6e6e3d3fe990750c1fb40b1ab555a63edf83

commit a0736f3dc3f35c70e21eaf62fdb96675ac36ba5d
Author: Don Penney <don.penney@windriver.com>
Date:   Wed Jan 6 14:28:30 2021 -0500

Remove empty package from stx-extensions
    
    Packages defined in a spec with no files do not result in an RPM
    produced by the build. On a rebuild, the build tools scan the spec and
    sees the package defined but does not find a corresponding RPM, and so
    flags the package for a rebuild as a result.
    
    This commit removes the empty package definition from the spec.
    
    Change-Id: I48e725bee837cd27352d38732d6f7155827cfe32
    Partial-Bug: 1910439
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit 676df72f5bbd66e9e8d02cf23ce6721ca169e9f7
Author: pablo bovina <pablo.bovina@windriver.com>
Date:   Fri Dec 18 17:43:57 2020 -0300

Add parameters for list open files command.
    
    This is for performance improvements and usability
    issues for debugging and testing.
    
    Closes-Bug: 1906537
    
    Change-Id: I2e703882219fb986c16fc32e01865fa774094543
    Signed-off-by: Pablo Bovina <pablo.bovina@windriver.com>

commit 312c87a86fd84534c5acd4447efebfda99e16016
Author: Pablo Bovina <pablo.bovina@windriver.com>
Date:   Fri Dec 18 17:55:14 2020 +0000

Revert "Collect tool times out due to long running lsof"
    
    This reverts commit bdd8c02d84de416ab407cb2cbd39e70b216dc524.
    
    Reason for revert:
    <
    The following  command:
    
    "grep awk '($3 !~ /^[0-9]+$/ && /\/mnt\/huge/) || NR==1 {print $0;}'"
    
    after the command "lsof -lwX"
    
    doesn't adds value  for debugging and testing purposes.
    >
    
    Story: 2008452
    Task: 41483
    
    Change-Id: I2f81ff6ca4daa6956ad6d0dd210262df2f9e00e8
    Signed-off-by: Pablo Bovina <pablo.bovina@windriver.com>

commit dbd5dbd8e0b2153ffa04f24649d4bc946ef226d0
Author: albailey <Al.Bailey@windriver.com>
Date:   Sun Dec 13 19:09:00 2020 -0600

Turn off legacy resolver workaround in pip
    
    The legacy resolver was enabled when the new pip was released.
    The requirements have been cleaned up, and sysinv has been
    updated.
    
    pkgconfig is required to be able to install libvirt from pip.
    
    A bindep file has been added to ensure the components required
    to build libvirt-python are available on the zuul host.
    
    The upper constraints have been removed from tox/zuul since
    the headers for components installed by bindep are newer than
    what will work when compiling the older libvirt
    
    Depends-On: https://review.opendev.org/c/starlingx/config/+/766645
    Partial-Bug: #1907678
    Signed-off-by: albailey <Al.Bailey@windriver.com>
    Change-Id: I5905f6cd0bb9bbe379835008ccf3f70102cfc17f

commit bdd8c02d84de416ab407cb2cbd39e70b216dc524
Author: pablo bovina <pablo.bovina@windriver.com>
Date:   Thu Dec 17 15:56:04 2020 -0300

Collect tool times out due to long running lsof
    
    lsof without these options:
    
    -l : conversion of user ID numbers to login names
    -w : suppress warning messages
    -X : skip the reporting of information on all open TCP,
          UDP and UDPLITE IPv4 and IPv6 files.
    
    can lead to timeout failure.
    
    Story: 2008452
    Task: 41465
    
    Change-Id: I688e024c39d8a56ad30e0e944aeb3e3a16aad2fc
    Signed-off-by: Pablo Bovina <pablo.bovina@windriver.com>

commit 467851e8d5128df6060399207843b78a9325c951
Author: Don Penney <don.penney@windriver.com>
Date:   Thu Dec 17 13:20:49 2020 -0500

Add auto-version for remaining stx/utilities packages
    
    Update remaining StarlingX packages with hardcoded TIS_PATCH_VER to
    use PKG_GITREVCOUNT where possible, with offsets as needed to ensure
    the version is incremented above the hardcoded version.
    
    Change-Id: Ia1ade77e12b948040f06806a5417d005488e3bb9
    Story: 2008455
    Task: 41460
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit dd97a2c3bb0f4c4dcc8f283b9e20cfedcc181737
Author: Lu Yao Chen <luyao.chen@windriver.com>
Date:   Wed Dec 16 15:05:08 2020 -0500

Fixing collect tool issue
    
    Fixing error found in patch 763859, missing \
    character in line 104.
    
    Review:
    https://review.opendev.org/c/starlingx/utilities/+/763859
    
    Closes-Bug: 1896116
    
    Signed-off-by: Lu Yao Chen <luyao.chen@windriver.com>
    Change-Id: I80ee960a2b8dab19443a45f8539a5cb602af4efb

commit e7e0ecfab90e1f8843a04dd6dc00e7cf00c2adb1
Author: pablo bovina <pablo.bovina@windriver.com>
Date:   Mon Dec 14 11:12:39 2020 -0300

Add new logs to the alarm info file
    
    Add new log to the alarm.info generated
    by the output of:
            fm event-list --nopaging
    
    Story: 2008452
    Task: 41435
    
    Change-Id: Ic7ea6c33e79b846058723dc1023797526ceeb7af
    Signed-off-by: Pablo Bovina <pablo.bovina@windriver.com>

commit b9b8ef2dc99009c18966c91f05bbe81a78b575f7
Author: pablo bovina <pablo.bovina@windriver.com>
Date:   Mon Dec 14 15:51:42 2020 -0300

Add new logs to the crash info file
    
    Add new log to the crash.info generated
    by the output of: 
            ls -lrtd /var/crash/*
            md5sum /var/crash/*
    
    Story: 2008452
    Task: 41433
    
    Change-Id: I19a532c7cead5b972a9c143860478ea128bfab3d
    Signed-off-by: Pablo Bovina <pablo.bovina@windriver.com>

commit 8c44a5a1065edc24e528c2d44b93c5bb7b5dd858
Author: albailey <Al.Bailey@windriver.com>
Date:   Thu Dec 10 08:53:23 2020 -0600

Enable legacy resolver for pip until requirements are updated
    
    pylint zuul jobs are failing due to incompatible dependencies that
    cause the new version of pip to abort.
    
    Enabling the legacy resolver (for now) so zuul can pass, while we
    fix all the requirements across the different repos.
    
    Related-Bug: 1907125
    Signed-off-by: albailey <Al.Bailey@windriver.com>
    Change-Id: I59e29aadb291574307e8278c9351f961bfc0277f

commit 17c62bd5aa24459bde2894a876d170803f52db3e
Author: Andy Ning <andy.ning@windriver.com>
Date:   Thu Dec 3 09:57:12 2020 -0500

Remove secure hieradata files from collect
    
    Supporting controller puppet manifests apply following DOR introduces
    cached hieradata which will be included in log collect.
    
    This change updated collect to remove the secure hieradata files in the
    cache as they contain clear text passwords.
    
    Change-Id: I17542c9fd778107f065531d02c53c59581fc179e
    Partial-Bug: 1904739
    Depends-On: https://review.opendev.org/c/starlingx/config/+/765373
    Signed-off-by: Andy Ning <andy.ning@windriver.com>

commit e3f78a9c0ad948b01fdd73a77604601e46289181
Author: Jackie Huang <jackie.huang@windriver.com>
Date:   Tue Oct 27 10:17:31 2020 -0600

cpumap_functions.sh: fix perl experimental feature issue
    
    An experimental feature added in Perl 5.14 allowed each, keys, push,
    pop, shift, splice, unshift, and values to be called with a scalar
    argument. This experiment is considered unsuccessful, and has been
    removed in 5.23 and later releases. So don't use this feature to
    avoid failure:
    localhost:~# platform_expanded_cpu_list
    Experimental keys on scalar is now forbidden at -e line 13.
    
    Closes-Bug: 1901642
    Change-Id: I5898145151e25538c745572da51af26b9251c285
    Signed-off-by: Jackie Huang <jackie.huang@windriver.com>

commit b58d9d20d3d1c5307f12706900645e1ce969b2e4
Author: Martin, Chen <haochuan.z.chen@intel.com>
Date:   Fri Oct 30 14:30:00 2020 +0800

Build image for ceph-manager
    
    For host-based ceph cluster, serivce manager launch service mgr-restful-plugin
    which launch ceph-mgr and daemon ceph-manager. Ceph-manager daemon polls
    ceph cluster status by ceph-mgr restful module and raise or clean alarm to
    to fault manager.
    
    For rook, build a image named stx-ceph-manager, use this image to make a
    deployment, which will take the same task polling containerized ceph cluster
    status and raise or clean alarm.
    
    Story: 2005527
    Task: 41338
    
    Change-Id: Iaaedfc0c7198e102eb4b8c94ab759e9b209e6bfd
    Signed-off-by: Martin, Chen <haochuan.z.chen@intel.com>

commit 43cd10d392e64abd810b8032a01bcbf4a29524b6
Author: Lu Yao Chen <luyao.chen@windriver.com>
Date:   Mon Nov 23 13:58:11 2020 -0500

Masking passwords with collect script
    
    Using collect script to mask cleartext password incidents
    in /var/log/user.log, done by grepping for -password,
    password: prefixes and headers and redacting password
    with xxxxxx string, used user.log with cleartext
    passwords to test
    
    Partial-Bug: 1896116
    
    Signed-off-by: Lu Yao Chen <luyao.chen@windriver.com>
    Change-Id: I3a3c02b61994d53589d673b2335d0eb023adfac6

commit ddd40f08f2086690e8439c9ce8183ead7d41761b
Author: Carmen Rata <carmen.rata@windriver.com>
Date:   Thu Oct 22 23:05:08 2020 -0400

Fix shared libraries file permissions
    
    Updated shared library files permission from
    /usr/lib/systemd/system/ to be non group-writable,
    to fix openscap security violation.
    Verified installation is successful in AIO-SX and
    Standard 2+2 system configurations.
    Ran successfully "taskset" command to check current
    affinity to platforms CPUs.
    
    Story: 2008037
    Task: 40694
    
    Change-Id: If8d7d3becba073ee827e988f1e651a9c8d31d773
    Signed-off-by: Carmen Rata <carmen.rata@windriver.com>

commit 0f0bcf58446cc854397e67c0f6577288f98decf6
Author: Eric MacDonald <eric.macdonald@windriver.com>
Date:   Fri Oct 16 21:44:10 2020 -0400

Exclude /var/log/crash from collect
    
    This update adds support to exclude
    /var/log/crash content from a collect
    operation.
    
    Additional /var/log content exclusions can be
    added to the new /etc/collect/varlog.exclude
    file added by this update.
    
    Change-Id: I657ce2552e36cc3ac296f11ecd7ed1331ec0f13e
    Partial-Fix: 1898602
    Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>

commit db2156eaddeafec0523aeccda45447b3069eb059
Author: Jim Gauld <james.gauld@windriver.com>
Date:   Fri Oct 16 15:41:34 2020 -0400

Affine kswapd* kernel threads to platform cores
    
    The kswapd* kernel tasks are per NUMA node and have floating
    cpu affinity masks spanning those nodes.
    
    On AIO low-latency systems, this affines the kswapd* kernel tasks to
    platform cores. This is a performance improvement for low-latency
    sensitive applications.
    
    Partial-Bug: 1900174
    Change-Id: I20db19978362997b23a69bf591b8e7c23096f492
    Signed-off-by: Jim Gauld <james.gauld@windriver.com>

commit dd5002831818c1a43b90cc3ca704648e6d3e889d
Author: Scott Little <scott.little@windriver.com>
Date:   Thu Sep 17 16:10:31 2020 -0400

Set SW_VERSION/PLATFORM_RELEASE to 20.12
    
    Story: 2008055
    Task: 40919
    Change-Id: If065e2967b3fbe0a5fce41b6cef3a99e5ffd17f3
    Signed-off-by: Scott Little <scott.little@windriver.com>

commit 5bc7a33773e947eef8caeb3f371afa816fbcb774
Author: Don Penney <don.penney@windriver.com>
Date:   Wed Sep 9 17:12:45 2020 -0400

Use newer flake8 to run on ubuntu-focal Zuul machines
    
    flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
    
    The update removes the hacking constraint to use newer flake8. This
    also ignores new warnings/errors, which should be addressed in a
    future update to remove the ignores.
    
    Change-Id: Ib24639adeea4da3063fb403a8e8484937f9e1a9f
    Partial-Bug: 1895054
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit dd902cf3865f2147559b8c8baeecff70ffebe3cb
Author: Jim Gauld <james.gauld@windriver.com>
Date:   Tue Sep 8 11:13:24 2020 -0400

Add mariadb-cli, kubectl and openstack commands to collect
    
    This adds containerized related commands to collect:
    - containerized wrapper script mariadb-cli to access MariaDB mysql
    - various kubectl commands to understand resource usage
    - various containerized openstack commands to understand resource usage
    
    mariadb-cli is used to dump contents of all mariadb databases.
    
    Change-Id: I70a08e38adbba247152509a22a8b9beac9128ff9
    Closes-Bug: 1889678
    Closes-Bug: 1894103
    Signed-off-by: Jim Gauld <james.gauld@windriver.com>

commit 6573fbe80c04e7cf85c46238c508aff1f2a04454
Author: Don Penney <don.penney@windriver.com>
Date:   Wed Sep 9 15:27:51 2020 -0400

Fix missing log_error in update-iso.sh
    
    The update-iso.sh utility references an undefined log_error function.
    As a result, error messages are not properly reported, instead
    resulting in messages such as:
    stx-iso-utils.sh: line 53: log_error: command not found
    
    This error was introduced by code restructuring in a previous update:
    https://review.opendev.org/707673
    
    This update defines a log_error function for update-iso.sh that writes
    the message to stderr, as this is a user-run utility, so no need to
    log to syslog.
    
    Change-Id: Ifdc2a25c24cd86e61ccc12601a0bcbe6888ac349
    Closes-Bug: 1895042
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit f43e37b4ea5ed58a55a660cab0b76a3ce0b6532e
Author: Don Penney <don.penney@windriver.com>
Date:   Wed Sep 2 22:42:41 2020 -0400

Fix gen-bootloader-iso.sh error on unpatched controller
    
    On a system that has never been patched, the updates repository may
    not yet have a Packages directory. This update fixes the patch setup
    in gen-bootloader-iso.sh to check for this case and handle it without
    failing.
    
    This update also improves the platform-kickstarts-pxeboot check to
    look for a pxeboot kickstart, to ensure there isn't a false-positive
    match against an extracted pxe-network-installer patch, which would
    also have a /pxeboot directory.
    
    Change-Id: I8e24a3ff123f4c2649be52b1a0ce77d830e342f3
    Closes-Bug: 1893990
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit c0ab7c29c1e44bf448fcd89dbc6a8fa9e814818b
Author: Jessica Castelino <jessica.castelino@windriver.com>
Date:   Wed Sep 2 10:29:08 2020 -0400

Adding dcmanager-orchestrator process to patch restart script
    
    Process dcmanager-orchestrator has been added to the restart script
    to simplify no-reboot patches that updates that process.
    
    Story: 2007267
    Task: 40813
    Change-Id: I5d634f769e86ac4c79170bfd8476bd65a1ac2280
    Signed-off-by: Jessica Castelino <jessica.castelino@windriver.com>

commit fb70729a9e13f6b12d0a5376c637723701578721
Author: Don Penney <don.penney@windriver.com>
Date:   Mon Aug 31 14:37:59 2020 -0400

Improve DNF cache handling in gen-bootloader-iso.sh
    
    The "dnf repoquery" command is using and updating the cache for ad-hoc
    repos created when using the repofrompath option. This can result in
    gen-bootloader-iso.sh using stale cached information when looking for
    specific RPMs in the patch repo when generating bootloader ISOs for
    subcloud installs.
    
    In order to avoid such issues, this update asks DNF to mark the cache
    as expired after copying the patch repo for generating the new ISOs,
    as well as on deletion. This ensures the repoquery uses up-to-date
    information.
    
    Additionally, this update removes a duplicated patch repo setup step,
    which was not cleaned up during dev testing on the previous commit.
    
    Change-Id: I664edb346692d79cd13b23772686ea88f0aaaf9f
    Story: 2007994
    Task: 40798
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit 584b23bd1527bb2666952c6427013ce4e7728934
Author: Michel Thebeau <Michel.Thebeau@windriver.com>
Date:   Wed Aug 26 16:06:12 2020 -0400

stx-extensions: use the host's PID for coredump
    
    systemd-coredump running as root on the host wants to get process
    information using the process' PID, but %p refers to "the PID namespace
    in which the process resides" (the container).  systemd-coredump
    coredumps.  Dmesg shows "Failed to get EXE" and the segfault (sic
    'systemd-coredum').
    
    This segfault of systemd-coredump is intermittent, and so on occasion a
    core file may actually be dumped for the containerized process. This
    happens when the %p does not match a process from the host's
    perspective.  Dmesg shows "Failed to get COMM..." and "Failed to get
    EXE".  This becomes more likely as the PIDs in container's namespace
    become larger - the host's PIDs are more sparse as the numbers increase.
    
    Use %P instead, "as seen in the initial PID namespace" (host).
    
    Convert the package to use PKG_GITREVCOUNT for release increment.
    
    Closes-Bug: 1892951
    Change-Id: Ifa5017d5997d12891893fc97fac4487ddfbbbbb8
    Signed-off-by: Michel Thebeau <Michel.Thebeau@windriver.com>

commit a69c15f4065017bcacd1d8cefba40bd1e4c956ba
Author: Don Penney <don.penney@windriver.com>
Date:   Fri Aug 7 10:56:25 2020 -0400

Use host patches for subcloud install setup
    
    This update enhances gen-bootloader-iso.sh to use patches applied on
    the host controller when setting up the subcloud installation
    bootloader. This checks the release version from the ISO to look for
    patches for that release only, copying applied and committed patches
    to the installation setup.
    
    This update also adds cleanup of partial setup on failure.
    
    Change-Id: I4eeb0141b75e48ce53c132b89e19e07c68cc49d2
    Story: 2007994
    Task: 40631
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit 6fec9e9ec55af9c62ca03558766806710d4da0b6
Author: Carmen Rata <carmen.rata@windriver.com>
Date:   Thu Jul 16 15:08:50 2020 -0400

Verify-license plugin support
    
    Current StarlingX implementation does not support a proper
    license validation.
    Used the Stevedore plugin pattern to allow override
    of the verify-license implementation to add enhanced
    validation rules if necessary.
    
    Story: 2007403
    Task: 39644
    
    Change-Id: I6fa6626feabff06b832dd41a2778804a28956131
    Signed-off-by: Carmen Rata <carmen.rata@windriver.com>

commit 71314e4af1af0c9590908656882c7a4c68172399
Author: albailey <Al.Bailey@windriver.com>
Date:   Thu Jul 9 14:01:52 2020 -0500

Adding missing distributed cloud processes to patch restart script
    
    In order to simplify no-reboot patches that update any of these DC
    processes, they have been added to the restart script.
    
     - dcdbsync-api
     - dcorch-identity-api-proxy
     - dcmanager-audit
    
    Closes-Bug: 1887002
    Change-Id: Ida2cee5b3ca873888820e3de485e9877b64166b9
    Signed-off-by: albailey <Al.Bailey@windriver.com>

commit 7c076a390f99cb72623da7168ae64e2947a25080
Author: Eric MacDonald <eric.macdonald@windriver.com>
Date:   Mon Jul 6 11:24:10 2020 -0400

Exclude temporary subcloud install iso files from collect
    
    The collect tool is unnecessarily including temp subcloud
    install iso files and related other large tmp files.
    
    This update changes the raw 'cp ...' to 'rsync ...'
    with the --exclude option to filter out iso files from the
    the collect_dc and collect_sysinv collect scripts.
    
    Change-Id: I3575c3193a24f376dcd006c3e5015c551023c69a
    Closes-Bug: 1885778
    Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>

commit 7ed511a6a0b861573bd9224a8a2a2ff6a031f463
Author: Don Penney <don.penney@windriver.com>
Date:   Tue Jun 30 17:19:14 2020 -0400

Protect against parallel exec of gen-bootloader-iso.sh
    
    The bulk of the work done by gen-bootloader-iso.sh is not safe to be
    executed by two callers in parallel. If the initial execution is
    setting up shared files when a subsequent call starts, the subsequent
    call can end up with an incomplete set of symlinks to shared files.
    This, in turn, can result in installation failures.
    
    To protect against this, a file lock is added to gen-bootloader-iso.sh
    to prevent subsequent calls from accessing shared files before they're
    completely setup.
    
    Change-Id: Id6def4527b226b8746b2b8ff74059c0d3937e130
    Closes-Bug: 1885779
    Signed-off-by: Don Penney <don.penney@windriver.com>

commit a10381203d920c55732109eb07aae2cf6d3345e8
Author: Jim Gauld <james.gauld@windriver.com>
Date:   Wed Jun 17 09:20:47 2020 -0400

Add kube-cpusets to collect
    
    This adds kube-cpusets tool to collect_hosts.
    This displays cpuset and numa node information per kubernetes pod
    on a given host.
    
    Change-Id: I1bd862cc0b1cef3b7997c032108c02b09f2885a1
    Story: 2006999
    Task: 40106
    Depends-On: https://review.opendev.org/723808
    Signed-off-by: Jim Gauld <james.gauld@windriver.com>

commit 12b7504a0a01fc3c74aa9f74f788422d8ecf45ee
Author: Andy Ning <andy.ning@windriver.com>
Date:   Tue May 26 10:03:32 2020 -0400

Install set keystone user option scripts
    
    This commit packs set_keystone_user_option.sh in platform-util rpm and
    install it in /usr/local/bin directory. The scripts can be used to set
    keystone user options such as "ignore_lockout_failure_attempts". It is
    currently used by keystone openstack::user::option puppet class to set
    admin user's "ignore_lockout_failure_attempts" to true to exempt it
    from auth fail lockout rule.
    
    Change-Id: I479cf2abb71fc57707d618d1cd110caf58d43394
    Closes-Bug: 1877179
    Signed-off-by: Andy Ning <andy.ning@windriver.com>

commit 9064dd13a006b23395c292f31230c7d8c0bb0701
Author: Scott Little <scott.little@windriver.com>
Date:   Thu May 21 15:19:49 2020 -0400

Set PLATFORM_RELEASE (aka SW_VERSION) to 20.06.
    
    Planned release of STX 4.0 is June 2020.
    The convention for PLATFORM_RELEASE is YY.MM .
    
    Change-Id: I863a4f1d615d0476dd51a29cca6b0eb65f50d36d
    Signed-off-by: Scott Little <scott.little@windriver.com>

commit 7552f4a0f58e73a74e4506cb86674047b2d83c18
Author: Ran An <ran1.an@intel.com>
Date:   Fri May 15 01:34:37 2020 +0000

Update logmgmt to use python3
    
    This reverts commit 115332ef6b0016393e6af9a65eadc1911be2be33.
    
    Change python to python3 about script and spec
    fix log runtime errors in python3 env
    1. layer build OK
    2. logmgmt.service running and stop ok
    3. log rotate and force rotate ok
    4. logmgmt manage and delete monitored or unmonitored log ok
    5. logmgmgt.log back up ok
    
    Story: 2007106
    Task: 39288
    Depends-on: https://review.opendev.org/#/c/728323/
    Depends-on: https://review.opendev.org/#/c/728325/
    Signed-off-by: Long Li <lilong-neu@neusoft.com>
    Signed-off-by: SidneyAn <ran1.an@intel.com>
    Change-Id: I08d6396922cea2d8d4d485f3cc66f522f6579f2e

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-01: Fix merged to ha (f/centos8)

#22

Download full text (20.2 KiB)

Reviewed: https://review.opendev.org/c/starlingx/ha/+/792251
Committed: https://opendev.org/starlingx/ha/commit/85bab5d2b394114feabe524504339a55eb8904e0
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 9f70df63fd0d83bf0f94d1b9ac2f98516d5971c8
Author: Bin Qian <email address hidden>
Date: Fri May 7 16:36:23 2021 -0400

Fix no swact for failure of critical services

This fix is to ensure keeping service failure counting over successful
audit.

    When service enabled audit successfully completes, SM reset the service
    failure state. However it should not reset the service fail-count.
    The fail-count should only be reset after the grace period.

    Closes-Bug: 1893669
    Change-Id: I6996fe3f1c08c38da6f26243aee2b95b083069f0
    Signed-off-by: Bin Qian <email address hidden>

commit 0b99b594f83b7c626cc0c4f7dc970ce373a7b748
Author: Bin Qian <email address hidden>
Date: Tue May 4 11:33:43 2021 -0400

Fix AIO-DX failover issues

    This fix is to fix AIO unexpected failover behaviors.
    1. active controller reboots itself when standby controller
       reboot/lost power
    2. standby controller becomes degraded after active controller
       reboot/lost power

    Closes-bug: 1927133
    Change-Id: If3c9f6251f689a89cd206c672092ba296f00bd6b
    Signed-off-by: Bin Qian <email address hidden>

commit cb5fa9510f3ebda66f9850ac697e542bf041ce8c
Author: Eric MacDonald <email address hidden>
Date: Tue Apr 27 09:43:00 2021 -0400

Remove hbsAgent restart in failover failure recovery handling

    A forced reboot of the active controller in an AIO DC system
    puts SM into a failover failure recovery loop that prevents
    maintenance from detecting the heartbeat failure of the just-
    rebooted controller.

    The SM's failover failure recovery handling algorithm includes
    a self (sm process) restart preceded by a restart of the
    hbsAgent, both added by the following update last year.

update: Add unhealthy state recovery audit to service management (sm)
review: https://review.opendev.org/c/starlingx/ha/+/735219

    The self restart of SM was and is required in this case. However,
    the restart of the hbsAgent was only included as a safety measure,
    at the time, to ensure SM received updated cluster state info. The
    hbsAgent restart was only added at that time with the longer term
    intention to have it removed once the hbsAgent cluster state change
    notification improvement was implemented. That change is now
    implemented and merged by the following update.

update: Mtce heartbeat cluster state change notification improvement
review: https://review.opendev.org/c/starlingx/metal/+/769936

    Testing of the fix for the following issue in an AIO DC system
    resulted in the takeover controller not detecting a heartbeat loss
    of the just rebooted standby controller.

title: Force active controller reboot results in a second reboot
issue: https://bugs.launchpad.net/starlingx/+bug/1922584

The hbsAgent is not able to detect the heartbeat loss of the just-
booted controller because SM keeps re...

Reviewed:  https://review.opendev.org/c/starlingx/ha/+/792251
Committed: https://opendev.org/starlingx/ha/commit/85bab5d2b394114feabe524504339a55eb8904e0
Submitter: "Zuul (22348)"
Branch:    f/centos8

commit 9f70df63fd0d83bf0f94d1b9ac2f98516d5971c8
Author: Bin Qian <bin.qian@windriver.com>
Date:   Fri May 7 16:36:23 2021 -0400

Fix no swact for failure of critical services
    
    This fix is to ensure keeping service failure counting over successful
    audit.
    
    When service enabled audit successfully completes, SM reset the service
    failure state. However it should not reset the service fail-count.
    The fail-count should only be reset after the grace period.
    
    Closes-Bug: 1893669
    Change-Id: I6996fe3f1c08c38da6f26243aee2b95b083069f0
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit 0b99b594f83b7c626cc0c4f7dc970ce373a7b748
Author: Bin Qian <bin.qian@windriver.com>
Date:   Tue May 4 11:33:43 2021 -0400

Fix AIO-DX failover issues
    
    This fix is to fix AIO unexpected failover behaviors.
    1. active controller reboots itself when standby controller
       reboot/lost power
    2. standby controller becomes degraded after active controller
       reboot/lost power
    
    Closes-bug: 1927133
    Change-Id: If3c9f6251f689a89cd206c672092ba296f00bd6b
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit cb5fa9510f3ebda66f9850ac697e542bf041ce8c
Author: Eric MacDonald <eric.macdonald@windriver.com>
Date:   Tue Apr 27 09:43:00 2021 -0400

Remove hbsAgent restart in failover failure recovery handling
    
    A forced reboot of the active controller in an AIO DC system
    puts SM into a failover failure recovery loop that prevents
    maintenance from detecting the heartbeat failure of the just-
    rebooted controller.
    
    The SM's failover failure recovery handling algorithm includes
    a self (sm process) restart preceded by a restart of the
    hbsAgent, both added by the following update last year.
    
    update: Add unhealthy state recovery audit to service management (sm)
    review: https://review.opendev.org/c/starlingx/ha/+/735219
    
    The self restart of SM was and is required in this case. However,
    the restart of the hbsAgent was only included as a safety measure,
    at the time, to ensure SM received updated cluster state info. The
    hbsAgent restart was only added at that time with the longer term
    intention to have it removed once the hbsAgent cluster state change
    notification improvement was implemented. That change is now
    implemented and merged by the following update.
    
    update: Mtce heartbeat cluster state change notification improvement
    review: https://review.opendev.org/c/starlingx/metal/+/769936
    
    Testing of the fix for the following issue in an AIO DC system
    resulted in the takeover controller not detecting a heartbeat loss
    of the just rebooted standby controller.
    
    title: Force active controller reboot results in a second reboot
    issue: https://bugs.launchpad.net/starlingx/+bug/1922584
    
    The hbsAgent is not able to detect the heartbeat loss of the just-
    booted controller because SM keeps restarting it before it reaches
    the heartbeat loss state.
    
    With the cluster notification improvement update now implemented
    and merged it's time to remove the hbsAgent restart from SM's
    failover failure recovery algorithm.
    
    Test Plan:
    
    PASS: Active controller force reboot handling in AIO DC, DX and
          standard systems.
    PASS: Standby controller force reboot handling in AIO DC, DX and
          standard systems
    
    Partial-Bug: 1922584
    Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>
    Change-Id: I26aa5ed9e0faec7294816269dbaa49cbb4696f66

commit 05a01c2100de3108d0a8ac757f0939d5c61fedcb
Author: Bin Qian <bin.qian@windriver.com>
Date:   Wed Mar 17 10:46:37 2021 -0400

Fix SQLite3 concurrent access issue
    
    SQLite3 does not support concurrent access with multiple connections
    that have writeable access. Currently SM opens database connections
    with full access, which causes concurrent issue.
    
    This fix includes:
    1. open readonly connection whenever the write permission is not needed
    2. remove code that open connections that are not being used
    3. remove reattempt and loggings from previous partial fix
    
    Now all writable connections are opened and used in main thread, this
    can ensure no more concurrent issue.
    
    Closes-Bug: 1915894
    Signed-off-by: Bin Qian <bin.qian@windriver.com>
    Change-Id: I200647a3733ac899b0b7498abd52992c7a87bd32

commit 7ca56fec9f2829953f934bad519a7eea0a27f3f2
Author: Bin Qian <bin.qian@windriver.com>
Date:   Thu Mar 4 15:07:24 2021 -0500

Limit the troubleshooting log
    
    Stop the troubleshooting log once the execution passes the
    checkpoint.
    
    Change-Id: I4e1d7710d5216f7b5a908f56e72d5f95c35a6586
    Partial-bug: 1915894
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit 10ff42ae1135b5cdd9df0a13cd0d18bfe8d655fe
Author: Bin Qian <bin.qian@windriver.com>
Date:   Tue Mar 2 16:05:14 2021 -0500

Fix incorrect include causing build failure
    
    Previous commit:
    https://opendev.org/starlingx/ha/commit/f39ca95924a0a44dc287c1a560fa9f6f52cdea51
    added an incorrect #include which cause build failure.
    
    Closes-bug: 1917527
    
    Change-Id: I5d93d77fb0b14446e21a1ba160ffd0848533e970
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit f39ca95924a0a44dc287c1a560fa9f6f52cdea51
Author: Bin Qian <bin.qian@windriver.com>
Date:   Tue Dec 15 15:55:25 2020 -0500

Add reattempt and collect more data for SM init failure
    
    Multiple report to AIO-SX that SM failed its intialization due to
    a SQL failure. The issue had not been reproduced in DEV environment.
    This change adds logging, reattempt and collect SM troubleshooting
    data when SM fails in such situation.
    For potential recovery before pmon start actively monitoring SM,
    setting systemd restart=on-failure. Also set RestartSec=10 seconds
    in order to give pmon enough time to catch the failure and restart
    SM.
    
    Partial-bug: 1915894
    Change-Id: I5899e401742510158cd9c59a664b1dc329bb1075
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit 4f1f13dbf75c7d0df1e6383043b3fa8636d54b2d
Author: Chris Friesen <chris.friesen@windriver.com>
Date:   Fri Feb 12 17:42:40 2021 -0600

Add support for dcmanager-audit-worker service
    
    We're moving the bulk of the dcmanager subcloud audits to separate
    worker processes, so we need to add a service for the main worker
    processes (which will then spawn additional workers).
    
    In order to ensure that audits can be processed as soon as
    dcmanager-audit starts up, we make enabling it dependent on
    dcmanager-audit-worker being already running.
    
    Story: 2007267
    Task: 41870
    Signed-off-by: Chris Friesen <chris.friesen@windriver.com>
    Depends-On: https://review.opendev.org/c/starlingx/distcloud/+/769216
    Change-Id: I162c00a3e8dba07f1912171e9371c29e5fd9a689

commit aaab51c1230a9194ec91886fe817cfb765d39bf5
Author: Teresa Ho <teresa.ho@windriver.com>
Date:   Thu Feb 11 13:23:55 2021 -0500

Create device-image-fs SM service
    
    Added a device-image-fs SM service to manage the device image
    repository filesystem.
    
    Tests performed on the following systems:
    AIO-DX, AIO-DX plus compute, Standard 2+1
    DC with AIO-DX plus subcloud
    DC with Standard subcloud
    
    Story: 2007875
    Task: 41880
    Depends-On: https://review.opendev.org/c/starlingx/ansible-playbooks/+/776488
    
    Change-Id: I068c26c524357176e4b526c405785768044c379c
    Signed-off-by: Teresa Ho <teresa.ho@windriver.com>

commit df3a96d8072f21fbe37b2206679b0f0afeef27bf
Author: Bin Qian <bin.qian@windriver.com>
Date:   Fri Jan 8 10:18:13 2021 -0500

Skip logging state change of I/F not managed by SM
    
    Skip logging state changes of interfaces that are not being
    monitored by SM. This is to reduce the noise in the sm.log.
    
    Closes-Bug: 1910770
    Change-Id: I6e3d78255dc41c03f10af2fd5d778e2398ea8816
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit ae51b607366e0f27cc5f7256542105f55f9dfe32
Author: Martin, Chen <haochuan.z.chen@intel.com>
Date:   Sun Nov 29 22:11:07 2020 +0800

Add service rook-mon-exit for duplex mode, host-swact case.
    
    For duplex, when make host swact, sm should firstly remove ceph-mon
    and ceph-osd pod, which open the /var/lib/ceph/mon-a folder.
    Remove these pods on active controller and make drbd set to
    secondary to swact to the other controller
    
    Story: 2005527
    Task: 41328
    
    Change-Id: I7cb7af3b3a56afcff71087d7f3b4f09a384c8dc2
    Signed-off-by: Martin, Chen <haochuan.z.chen@intel.com>

commit 2d0fc9b6118c7c9dd69290aa133c223ad557e5ae
Author: Bin Qian <bin.qian@windriver.com>
Date:   Thu Sep 17 12:36:31 2020 -0400

Detect peer SM failure
    
    This change is to detect SM failure/stall.
    
    1. SM sends alive pulse to hbsAgent, (hbsAgent sends SM failed state
       along with hbs cluster info)
    2. When SM lost heartbeat from peer, SM detects if peer has failed
       from hbs cluster info.
    3. On standby controller, if peer SM is stalled, it will take over
       to become active after signaling mtce to fail peer node.
    
    TCs passed:
       When SM detects peer failure from hbs cluster info, and signals
       mtce to fail peer node.
    
    Depends-on: https://review.opendev.org/#/c/751558
    
    Partial-bug: 1895350
    Change-Id: Id51e9adb4ef30bf806159366e6fdf115e743fe97
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit fa0d235555abb4e7fb4719ed70bfefac7213be72
Author: Takamasa Takenaka <takamasa.takenaka@windriver.com>
Date:   Tue Jan 12 17:05:46 2021 -0300

Remove database entries related to host-based snmp
    
    According to host-based SNMP removal, remove data entry related
    snmp.
    
    Story: 2008132
    Task: 41573
    Signed-off-by: Takamasa Takenaka <takamasa.takenaka@windriver.com>
    Depends-On: https://review.opendev.org/765381
    Change-Id: I533d9286f1a384be9d3ea245dff68812a14a4cd3

commit ebdc59e3e1fa81e35a1f8a6306dc96a7e31cae0e
Author: Bin Qian <bin.qian@windriver.com>
Date:   Wed Dec 9 17:38:28 2020 -0500

add disable dependency for drbd and fs services
    
    A DRBD service needs dependency on disable to its related fs
    service, for example: drbd-rabbit -> rabbit-fs, so that
    SM disables drbd-rabbit after rabbit-fs is disabled.
    This is important especially in AIO-SX in which drbd services
    are disabled when host is being unlocked.
    
    The following disable dependency are added in this change:
    drbd-pg -> pg-fs
    drbd-rabbit -> rabbit-fs
    drbd-platform -> platform-fs
    drbd-extension -> extension-fs
    drbd-cinder -> cinder-lvm
    drbd-dc-vault -> dc-vault-fs
    drbd-dockerdistribution -> dockerdistribution-fs
    drbd-cephmon -> cephmon-fs
    
    Test host lock/unlock in AIO-SX and standard DX environments.
    
    Closes-bug: 1907490
    Change-Id: I631f718add2c1d2756a36f3770a4d48f02904f1a
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit e52a67bfa0f181eccf60eaa704d3c2c3b1c83b32
Author: Bin Qian <bin.qian@windriver.com>
Date:   Thu Dec 31 11:48:09 2020 -0500

Avoid sending UDP packets to ::1
    
    In AIO-SX, the peer IP address is not configured (blank),
    which is translated into '::'. When the '::' is used as
    dest address, it is translated to loopback '::1'.
    
    SM should skip sending packets to destination '::'.
    
    Closes-Bug: 1909769
    Change-Id: Id8a9a00adce6573bcccd60b1b2112b6ee8b2f8a3
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit 6ab82889af6bdf4232045a473f4762c5c0401252
Author: albailey <Al.Bailey@windriver.com>
Date:   Thu Dec 17 13:18:43 2020 -0600

Fix zuul jobs broken due to pip upversion
    
    The install_command for docs, newnote and api-ref
    needed to be overridden to not use upper constraints.
    
    The bandit requirement needed to be made python3 only.
    
    The bandit scan was failing, so it is now updated to
    allow individual bandit failures to be suppressed in tox.ini
    
    Need to include a py file change in order for bandit to be
    triggered by zuul.
    
    Partial-Bug: #1907678
    Signed-off-by: albailey <Al.Bailey@windriver.com>
    Change-Id: Ic73d0ea590ab1b7857f7275fa9c71828b0d343ee

commit df739b210e3074d48adddf0d54b5b024cd7419dc
Author: Don Penney <don.penney@windriver.com>
Date:   Thu Dec 17 13:27:02 2020 -0500

Add auto-version for remaining stx/ha packages
    
    Update remaining StarlingX packages with hardcoded TIS_PATCH_VER to
    use PKG_GITREVCOUNT where possible, with offsets as needed to ensure
    the version is incremented above the hardcoded version.
    
    Story: 2008455
    Task: 41447
    Signed-off-by: Don Penney <don.penney@windriver.com>
    Change-Id: Idf5ef476192cdf4923d6c903f1a15e03cfe9d03f

commit e8af161b16c1f75e2f1bab7c257aaa66caae7fd1
Author: Bin Qian <bin.qian@windriver.com>
Date:   Wed Oct 7 10:24:45 2020 -0400

Skip verifying h/w info for Not-In-Use interface
    
    When a domain interface state is changed, hardware information is
    verified to ensure the interface is OK to enter into the new state.
    
    However, when an interface is entering into Not-In-Use state, it should
    be always OK no matter what the h/w interface state is. Especially when
    the interface is back on lo, in which case getting hardware information
    will fail. This prevents moving interface to Not-In-Use state.
    
    This change skip verifying h/w state if state of an interface is changed
    to Not-In-Use.
    
    This fix will also skip checking h/w information for lo interface and
    always returns enabled = true.
    
    Closes-Bug: 1898629
    
    Signed-off-by: Bin Qian <bin.qian@windriver.com>
    Change-Id: I709708bce622f52bf84fc3fec749f204cfeee533

commit 57225bb34ae5380c95dddd0e556847f7a17e3d61
Author: albailey <Al.Bailey@windriver.com>
Date:   Wed Sep 16 13:01:03 2020 -0500

Use newer flake8 to run on ubuntu-focal Zuul machines
    
    flake8 2.5.5  fails on ubuntu-focal zuul machines running python3.8
    with the following error:
    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
    
    The update removes the version constraint to use newer flake8.
    
    The linters can be run in python3.
    Pylint cannot be run in python3 because mysql-python is not
    compatable, so a new zuul job for pylint is now added.
    
    The flake8 errors that the newer version raises are all suppressed,
    and some of them should be addressed by someone with familiarity in
    this repo.
    
    Change-Id: Ida6447728d4175173c02130cb04a6013e4f966f9
    Partial-Bug: 1895054
    Signed-off-by: albailey <Al.Bailey@windriver.com>

commit de04f2386039b7a393ff319405bb00dce5348001
Author: Jessica Castelino <jessica.castelino@windriver.com>
Date:   Wed Aug 19 16:01:58 2020 -0400

Move dcmanager orchestration to a separate process
    
    The DC manager orchestration is being removed from the
    dcmanager-manager process and it is running in
    dcmanager-orchestrator process.
    
    This update adds associated sm config for the new process.
    
    Change-Id: I7cc0869a123713d85b8167bd1f8a4481b8da0902
    Story: 2007267
    Task: 40715
    Depends-On: https://review.opendev.org/#/c/748452/
    Signed-off-by: Jessica Castelino <jessica.castelino@windriver.com>

commit 000df04ce109fe0e97721d9b4f3c842de754020d
Author: Bin Qian <bin.qian@windriver.com>
Date:   Mon Jun 22 10:10:55 2020 -0400

Move cert-mon service to controller-services
    
    Move the cert-mon service to controller-services service group, so
    to make it more generic for other platform certificate monitoring
    features.
    
    Story: 2007347
    Task: 40119
    
    Change-Id: Ib82a579dd2f1d0dcf97e90eed44fb095ee9ab6ca
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit 18deafa5c3c5ffe94434c4d4b63232210440d8ef
Author: Bin Qian <bin.qian@windriver.com>
Date:   Thu Jun 18 22:08:37 2020 -0400

Add new cert-mon service to sm db -- not provisioned
    
    Add new critical service cert-mon to under SM manage,
    in controller-services group.
    The new service will monitor admin endpoint service renewal in
    cert-manager and apply new certificates to controller nodes in a
    DC setup.
    
    Tests:
    Provision DC system controllers. Swact. all successful.
    
    Added and provisioned dummy service process, swact, all successful.
    
    Change-Id: Ic545fafc88be4acb4e5e0ea3e4449ade57dcef8c
    Story: 2007347
    Task: 40119
    Signed-off-by: Bin Qian <bin.qian@windriver.com>

commit 630a777cbb894501cb019c917c1be8288e7a7c36
Author: Eric MacDonald <eric.macdonald@windriver.com>
Date:   Thu Jun 11 15:32:47 2020 -0400

Add unhealthy state recovery audit to service management (sm)
    
    Service Management (SM) monitors connectivity and health of
    its peer controller over the OAM, Mgmt and (if provisioned)
    Cluster-Host networks.
    
    If SM sees all the links to its peer go 'carrier down' virtually
    simultaneously, it is possible that both controllers might
    simultaneously declare themselves unhealthy and both go
    disabled; i.e. shutdown all services with no automatic recovery.
    
    This update adds an 'Unhealthy State Recovery Audit' to SM which
    forces a self restart when all of its monitored links recover
    for cases where both controllers go unhealthy-shutdown or both
    controllers remain active in split-brain.
    
    Test Plan:
    
    PASS: Verify AIO SX install
    PASS: Verify Standard system install and unhealthy state recovery
    PASS: Verify single link failure end to end behavior
    PASS: Verify 2 of 3 link failure end to end behavior
    PASS: Verify all link failure end to end behavior
    PASS: Verify SM and Mtce heartbeat recovery over unhealthy state recovery
    PASS: Verify swact back and forth following a recovery
    PASS: Verify process restart as part of unhealthy state recovery
    PASS: Verify AIO DX install and unhealthy state recovery
    
    Change-Id: Ie906eaf04bec607328b7e0af09b37fa0558e3bbe
    Closes-Bug: 1883004
    Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>

commit 3b68098be42b856471fa1cc39f359d6649585df4
Author: Sharath Kumar K <sharath.kumar@intel.com>
Date:   Mon May 4 08:01:38 2020 +0200

Tox and Zuul job for the  python code scan in starlingx/ha
    
    Setting up the bandit tool for the scanning of HIGH severity issues
    in the python codes under Starlingx/ha folder.
    Expecting this merge will enable zuul job for CI/CD of bandit scan.
    
    Configuration files:
    1. tox.ini for adding bandit environment and command.
    2. test-requirements.txt for adding bandit version.
    3. .zuul.yaml file for adding bandit job and configuring under
       check job to run code scan every time before code commit.
    
    Test:
    Run tox -e bandit command inside the fault folder to validate the
    bandit scan and result.
    
    Please note:
    Changes will be implemented in batches and this is Batch3 change.
    
    Story: 2007541
    Task: 39621
    Depends-On: https://review.opendev.org/#/c/721294/
    
    Change-Id: I01f81d7c52c12432965106f9603e4db600381971
    Signed-off-by: Sharath Kumar K <sharath.kumar@intel.com>

commit 58d1e5b3bfe4b08d6a7274d1d96449554058ff22
Author: Andreas Jaeger <aj@suse.com>
Date:   Thu Jun 4 14:25:29 2020 +0200

Switch to newer openstackdocstheme and reno versions
    
    Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
    these versions will allow especially:
    * Linking from HTML to PDF document
    * Allow parallel building of documents
    * Fix some rendering problems
    
    Update Sphinx version as well.
    
    Disable openstackdocs_auto_name to use 'project' variable as name.
    
    Change pygments_style to 'native' since old theme version always used
    'native' and the theme now respects the setting and using 'sphinx' can
    lead to some strange rendering.
    
    openstackdocstheme renames some variables, so follow the renames
    before the next release removes them. A couple of variables are also
    not needed anymore, remove them.
    
    See also
    http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
    
    Change-Id: Iab15b05918b73ce9ba2ff0b479fdb8a0631fad42

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-15: Change abandoned on ha (f/centos8)

#23

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/ha/+/787550

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-07-06:

#24

Change abandoned by "Bart Wensley <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/ha/+/765061
Reason: This patch has been idle for more than six months. I am abandoning it to keep the review queue sane. If you are still interested in working on this patch, please unabandon it and upload a new patchset.

StarlingX

flake8 failing on ubuntu-focal zuul machine

Bug Description

Other bug subscribers

Remote bug watches