patch-iso fails on pxe-network-installer patch

Bug #1892424 reported by Don Penney
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Don Penney

Bug Description

Brief Description
-----------------
Running patch-iso with a pxe-network-installer patch fails, due to an older restructuring of pxe-network-installer when the grub2 package was upversioned in 2018. The pxe-network-installer spec and build-iso package were updated, but patch-iso was not:
https://opendev.org/starlingx/metal/commit/d58a4ca481e02d3e8aa952bd6251a99cd86986d0
https://opendev.org/starlingx/root/commit/3a37c7feed50cde3e2c5f619cb85c97a7c1b18d7

Extraction of pxe-network-installer files fails with:
cp: cannot stat ‘pxeboot/EFI/centos/x86_64-efi/*’: No such file or directory
Error: Could not copy all files from installer

Severity
--------
Minor

Steps to Reproduce
------------------
Create a pxe-network-installer patch and run patch-iso to add it to an ISO.

Reproducibility
---------------
Reproducible

Branch/Pull Time/Commit
-----------------------
master, as of Aug 20, 2020

Last Pass
---------
This appears to have been broken since 2018

Don Penney (dpenney)
Changed in starlingx:
assignee: nobody → Don Penney (dpenney)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to root (master)

Fix proposed to branch: master
Review: https://review.opendev.org/747297

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (master)

Reviewed: https://review.opendev.org/747297
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=466ce2c528b6e9f72005053b261a4b023ead47b1
Submitter: Zuul
Branch: master

commit 466ce2c528b6e9f72005053b261a4b023ead47b1
Author: Don Penney <email address hidden>
Date: Thu Aug 20 17:52:54 2020 -0400

    Fix patch-iso pxe-network-installer handling

    Changes made previously to upversion grub2 in starlingx resulted in
    some restructuring of the pxe-network-installer package, and
    corresponding changes in build-iso. These changes were not reflected
    in patch-iso, however. This update fixes the handling of
    pxe-network-installer extraction, and includes additional grub2
    packages in the patch support.

    Change-Id: Ib72a44d2d5a39fe41023be8feb83b88e5f39435b
    Closes-Bug: 1892424
    Signed-off-by: Don Penney <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
tags: added: stx.5.0 stx.build
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.