config: unnecessary re-apply of manifests on unlock when using 'system modify --https_enabled'

[Kristine Bujold]

Brief Description
-----------------
Found a bug in sysinv where if the user issue the CLI command “system modify --https_enabled <true/false>” (which does not requires a lock/unlock to be applied), the config flag '.https_config_required' gets set and never removed. If the user performs a lock/unlock on the lab, the conductor with run the _controller_config_active_apply() audit after the unlock. It will see the '.https_config_required' flag is set and raise the config alarm and apply the manifests. If there is no problem problems applying the manifests the alarm is cleared.

A fix for this would be to have stx-puppet clear the flag as well after the changes are performed.

Severity
--------
Minor

Steps to Reproduce
------------------
- system modify --https_enabled <true/false>
- lock/unlock node
- Right after the unlock see 250.001 alarm 'Configuration is out-of-date' being raised and cleared

Expected Behavior
------------------
The alarm should have not been raised since there was no config changes

Actual Behavior
----------------
250.001 alarm 'Configuration is out-of-date' being raised and cleared

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------

Timestamp/Logs
--------------

Test Activity
-------------
Developer Testing

Workaround
----------
None. This is not service affecting other than an unnecessary alarm being raised and cleared.

[Bill Zvonar (billzvonar)]

Hi John, can you propose a solution.

[Bart Wensley (bartwensley)]

This LP should not gate stx.5.0. Reasons:
- This is a rare scenario (enabling https) that will only be done once on a deployment.
- The impact is very low (an extra alarm for a very short period) and self corrects.

Please remove the stx.5.0 tag.

[Bill Zvonar (billzvonar)]

st.x.5.0 tag removed.