DC fpga orchestration delete should delete subcloud vim strategies

[Al Bailey]

This is more of a design change, than a bug, to align DC fpga orch with DC patch orch.

Brief Description
-----------------
When DC fpga orch starts it deletes any existing VIM strategies (there should not be any unless there was a failure)
When DC fpga orch succeeds it deletes the VIM strategy.
When DC fpga orch fails, it does not delete the VIM strategy.

Only one vim strategy can exist of any type, so having a failed fpga orch can block DC patch orch from running (without manually logging in to clean them up)

Severity
--------
Minor

Steps to Reproduce
------------------
Do a failed DC fpga orchestration.
Attempt a DC patch orchestration.

Expected Behavior
------------------
Should be able to do the patch orch

Actual Behavior
----------------
The leftover fpga vim strategy will block the patch orch.

Reproducibility
---------------
Should be reproduceable. Not typically seen, since in typical env, the goal was to resolve the fpga orch.

System Configuration
--------------------
DC

Branch/Pull Time/Commit
-----------------------
Aug 13, 2020

Last Pass
---------
N/A
The DC fpga orch is a new feature and was designed with this limitation.

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Developer Testing

Workaround
----------
Manually login to the subclouds and delete the existing VIM strategy

[Ghada Khalil (gkhalil)]

stx.5.0 / med to low priority - issue related to FPGA Orchestration, but is relatively minor

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/754811

[Al Bailey (albailey1974)]

The fix for this change is to put the 'delete' of the vim strategy as part of the DC orchestration delete.
This is how we are doing this already for DC patch orchestration.
When upgrades are enhanced to use VIM strategies, that feature will also use this technique.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754811
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=12b81ff452ce79d6dc1547c0a315284309e95b7f
Submitter: Zuul
Branch: master

commit 12b81ff452ce79d6dc1547c0a315284309e95b7f
Author: albailey <email address hidden>
Date: Tue Sep 1 08:02:57 2020 -0500

    Delete subcloud VIM strategies when DC fpga strategy deleted

    As part of an fpga upgrade strategy in a subcloud by the VIM,
    that strategy needs to be deleted. Previously it was being
    deleted as part of a the final steps of a successful orchestration,
    but there can be scenarios where that orchestration is incomplete,
    and therefore these VIM strategies need to be handled.

    A new DC orchestration cannot be created until the old one is deleted,
    so this change ensures fpga vim strategies are deleted if possible
    when the DC orchestration strategy is deleted.

    A bug in applying vim strategy has been fixed, and the section removed
    since a vim auth exception cannot be raised since a new vim client
    is constructed per loop.

    Unit tests to invoke the delete strategy have been added.

    Tox coverage now generates an html report.

    Change-Id: I4f3d7bc3550e12c430d1b1c0ce3dffb298fe31b4
    Closes-Bug: 1891521
    Signed-off-by: albailey <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/distcloud/+/792298

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/distcloud/+/792298
Reason: Updated merge soon

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/distcloud/+/793405

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/distcloud/+/793405

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/distcloud/+/796528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/796528
Committed: https://opendev.org/starlingx/distcloud/commit/4c5344f8765b372cb84d2b1181589c16db2ae6e4
Submitter: "Zuul (22348)"
Branch: f/centos8

commit cb979811017bd193fc1f06e53bb7830fd3184859
Author: Yuxing Jiang <email address hidden>
Date: Wed Jun 9 11:11:27 2021 -0400

    Format the IP addresses in payload before adding a subcloud

    The IPv6 addresses can be represented in multiple formats. As IP
    addresses are stored as text in database, ansible inventory and
    overrides, this commit converts the IP addresses in payload to
    standard text format of IPv6 address during adding a new subcloud.

    Tested with installing and bootstrapping a new subcloud(RVMC
    configured) with the correct IPv6 address values, but with
    unrecommended upper case letters and '0'. The addresses are
    converted to standard format in database, ansible inventory and
    overrides files.

    Partial-Bug: 1931459
    Signed-off-by: Yuxing Jiang <email address hidden>
    Change-Id: I6c26e749941f1ea2597f91886ad8f7da64521f0d

commit 2cf5d6d5cef0808c354f7575336aec34253993b3
Author: albailey <email address hidden>
Date: Thu May 20 14:19:24 2021 -0500

    Delete existing vim strategy from subcloud during patch orch

    When dcmanager creates a patch strategy, if a subcloud has an
    existing vim patch strategy, it will attempt to re-use
    that strategy during its patching phase, which may result in an
    error.

    This commit deletes the existing vim patch strategy in
    a subcloud, if it exists, so it can be re-created.
    If the strategy cannot be deleted, orchestration fails.

    Change-Id: Id35ef26ed3ddae6d71874fc6bac11df147f72323
    Closes-Bug: 1929221
    Signed-off-by: albailey <email address hidden>

commit 9e14c83f0162549a2a94cb8bc1e73dbc4f4d4887
Author: albailey <email address hidden>
Date: Tue Jun 1 14:37:14 2021 -0500

    Adding activation retry to upgrade orchestration

    When performing an activation, the keystone endpoints may not
    be accessible in the subcloud due to the asyncronous way that
    cert-mon can trigger a restart of keystone.

    This would have occasionally resulted in the upgrade activation
    failing to be initiated, and orchestration needing to be invoked
    again to resume.

    This 'hack' adds retries and sleeps to the initial
    activation action.

    Change-Id: Ic757521dec7bdc248a51a70b5463caafe7927360
    Partial-Bug: 1927550
    Signed-off-by: albailey <email address hidden>

commit bb604c0a9b872efd65fa45f1e2269995818c6262
Author: Tee Ngo <email address hidden>
Date: Thu May 27 22:17:16 2021 -0400

    Fix subcloud show --detail command related issues

    If the subcloud is offline, the command stalls and eventually returns
    the "ERROR (app)" output. If the subcloud is online, the oam_floating_ip
    info is excluded from the output when the subcloud id instead of subcloud
    name is specified.

    This commit fixes both of the above issues.

    Closes-Bug: 1929893
    Change-Id: I995591368564539b0e6af185b1adba2db73e0e46
    Sign...