starlingx gui dc_admin deploy status field needs updating

[Tyler Smith]

Brief Description
-----------------
On the dc_admin cloud overview panel the subcloud table deploy status column needs to be updated to recognize newly introduced statuses, such as 'data-migration-failed'. It should display an icon next to the text value of the field like with the other possible status values.

Also the search suggestion values for that field need to be updated as well.

Severity
--------
Minor

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Distributed cloud system

Branch/Pull Time/Commit
-----------------------
master

Test Activity
-------------
Developer Testing

[Frank Miller (sensfan22)]

Marking as stx.5.0 gating.

[Takamasa Takenaka (ttakenak)]

[Root Cause]
Cloud overview panel does not recognize new introduced deploy state values like "data-migration-failed".
So that when the state is changed, it showed the state in text but icon is not shown.

[Design Overview]
Add deploy state to bind to the proper icons.

[Impact]
This fix will be in one html page which contains the function to select proper icon for deploy states. It will not affect other function or other application.

[Background]
Cloud overview panel shows deploy state in the list. Deploy state is obtained by API and screen is refreshed automatically by interval.
When the deploy state is obtained, panel shows the state text with proper icon (red for DANGER state, for example).
New deploy states are intrduced after, but panel htlm, which contains the code to manage showing proper icon, was not updated.
As a result, when new deploy state comes up, panel does not show the icon.

Currently supported:

[DANGER]
DEPLOY_STATE_PRE_INSTALL_FAILED = 'pre-install-failed'
DEPLOY_STATE_INSTALL_FAILED = 'install-failed'
DEPLOY_STATE_BOOTSTRAP_FAILED = 'bootstrap-failed'
DEPLOY_STATE_DEPLOY_FAILED = 'deploy-failed'

[WARNING]
DEPLOY_STATE_NONE = 'not-deployed'
DEPLOY_STATE_PRE_INSTALL = 'pre-install'
DEPLOY_STATE_INSTALLING = 'installing'
DEPLOY_STATE_BOOTSTRAPPING = 'bootstrapping'
DEPLOY_STATE_DEPLOYING = 'deploying'

[SUCCESS]
DEPLOY_STATE_DONE = 'complete'

Need to support
[DANGER]
DEPLOY_STATE_DEPLOY_PREP_FAILED = 'deploy-prep-failed'
DEPLOY_STATE_DATA_MIGRATION_FAILED = 'data-migration-failed'
DEPLOY_STATE_RESTORE_PREP_FAILED = 'restore-prep-failed'
DEPLOY_STATE_RESTORE_FAILED = 'restore-failed'

[WARNING]
DEPLOY_STATE_PRE_DEPLOY = 'pre-deploy'
DEPLOY_STATE_MIGRATING_DATA = 'migrating-data'
DEPLOY_STATE_PRE_RESTORE = 'pre-restore'
DEPLOY_STATE_RESTORING = 'restoring'

[SUCCESS]
DEPLOY_STATE_INSTALLED = 'installed'
DEPLOY_STATE_MIGRATED = 'migrated'

Possible deploy states are obtained from distributedcloud/dcmanager/common/consts.py

[Takamasa Takenaka (ttakenak)]

The patch is uploaded: https://review.opendev.org/c/starlingx/gui/+/785732

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/792252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/gui/+/792252
Committed: https://opendev.org/starlingx/gui/commit/63d6de4701a7f21779ad9ea4060fce9ed85bc71f
Submitter: "Zuul (22348)"
Branch: f/centos8

commit e05e1a43531499d94cfb1e538683ee36eea92b43
Author: Teresa Ho <email address hidden>
Date: Thu May 13 23:04:04 2021 -0400

    Do not display primary_reselect if not specified

    If the attribute 'primary_reselect' is not specified, the sysinv API
    will leave it as null and GUI will not display the attribute.

    Closes-Bug: 1928461

    Change-Id: I5b8ef8b29fb7775dde8607bb14cd733015269f82
    Signed-off-by: Teresa Ho <email address hidden>

commit f1a4d30eca91c7a239ebd7479a56fef7870a4b2e
Author: Pablo Bovina <email address hidden>
Date: Fri May 7 16:59:50 2021 -0300

    Display DataNetworks list

    DataNetworks are listed for pci-sriov
    under Create/Edit Interface forms.

    Closes-bug: 1927782
    Signed-off-by: Pablo Bovina <email address hidden>
    Change-Id: If927bb0facdec9e587a13354bef56eca5df08785

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu May 6 07:32:59 2021 -0400

    In AIO-SX, interface edit rejected with Host administrative unlocked

    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".

    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.

    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):

    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected

    Locked state:
    all conversions (with network/datanetwork assignment) are accepted

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

commit ddcc4fd3ccb4c02580c71414345993252b089761
Author: Enzo Candotti <email address hidden>
Date: Tue May 4 11:08:57 2021 -0300

    Enable add/edit Worker personality on DC AIO-DX's GUI

    This update is to allow the option to add a new host with Worker
    personality on Distributed Cloud mode.

    Closes-Bug: 1927107

    Signed-off-by: Enzo Candotti <email address hidden>
    Change-Id: Idfed9352c7c6467014a2ed2cf10b70f6b470c28c

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fer...