device image upload should only be allowed for supported devices

Bug #1889451 reported by Chris Friesen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Teresa Ho

Bug Description

Currently we allow uploading and applying images for any PCI device, but sysinv doesn't actually do anything for devices other than the N3000.

I think it would make sense to disallow uploading device images for hardware (identified by PCI vendor and device IDs) that sysinv doesn't know how to update. (This is more of a day 2 issue, doesn't cause problems if we only upload images for the N3000.) This would reduce confusion to the end-user since otherwise they might get confused about why their device image isn't being applied as expected.

Chris Friesen (cbf123)
tags: added: stx.integ sysinv
Ghada Khalil (gkhalil)
tags: added: stx.config
removed: sysinv
Revision history for this message
Chris Friesen (cbf123) wrote :

I tagged it with stx.integ by mistake, should have been stx.config in the first place.

tags: removed: stx.integ
Ghada Khalil (gkhalil)
tags: added: stx.5.0
Ghada Khalil (gkhalil)
tags: removed: stx.5.0
Ghada Khalil (gkhalil)
tags: added: stx.fpga
Ghada Khalil (gkhalil)
Changed in starlingx:
assignee: nobody → Teresa Ho (teresaho)
importance: Undecided → Low
Ghada Khalil (gkhalil)
Changed in starlingx:
status: New → Triaged
tags: added: stx.5.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/746340

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/746340
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=e946429f451d6c9e29b8d158c6100bea223ea331
Submitter: Zuul
Branch: master

commit e946429f451d6c9e29b8d158c6100bea223ea331
Author: Teresa Ho <email address hidden>
Date: Fri Aug 14 12:04:45 2020 -0400

    Add check for supported devices in image upload

    This commit adds a semantic check to the device image upload
    command to ensure that the PCI device vendor and device IDs
    are for the supported PCI devices.

    Closes-Bug: 1889451

    Change-Id: I01b0b889179a831d0f427d2a8cab287ee4f079d8
    Signed-off-by: Teresa Ho <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.