Redfish Virtual Media Controller not handling 204 properly

[Eric MacDonald]

The RVMC (Redfish Virtual Media Controller) is failing http requests that respond with 204 ; ok but with no reply content.

The 204 with no content should be handled as success.

Severity: Critical: Subcloud install fails for servers that reply with 204.

Steps to Reproduce: Perform a redfish subcloud install of a server that supports redfish
                    virtual media and replies with 204 to some commands.

Expected Behavior : 204 handled as OK
Actual Behavior : 204 is treated as a failure due to not finding a response.
Reproducibility : 100%

System Configuration: Subcloud install using redfish

Branch/Pull Time/Commit: master

Last Pass: N/A ; issue only found while trying to support additional server

Timestamp/Logs: N/A

Test Activity: Server Evaluation

Workaround : None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/743242

[Ghada Khalil (gkhalil)]

stx.5.0 / medium priority - issue reported on specific h/w during redfish integration testing

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743242
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=d46c9c55a9a9b7ea09e8d0fe66c8cfbeeb9ac75f
Submitter: Zuul
Branch: master

commit d46c9c55a9a9b7ea09e8d0fe66c8cfbeeb9ac75f
Author: Eric MacDonald <email address hidden>
Date: Mon Jul 27 10:26:34 2020 -0400

    Redfish Virtual Media Controller enhancements

    Adding support for additional server that responds to a number of
    redfish requests with the 204 (OK but with no response content).

    This update fixes http 204 status handling to expect no response
    content.

    This update also adds support for servers that download image at
    insertion time and have short connection timeout periods that cannot
    be changed.

    1. Image Insertion: add image download monitoring phase to image
       insertion.
       - to accommodate for servers that load the image during insertion

    2. Image Eject: Modify to retry eject and poll for ejection complete.
       - to handle case where the eject is called while a server is aready
         downloading an image.

    3. Power Control: Change host power control operation from a 10 second
       inline wait to a 10 x 1sec power state change verification loop
       - avoid server issue that leads to redfish client connection timeout
         due to inactivity. Also extended the power control timeout to
         handled servers that aer slow.

    This update also adds the following work around to existing redfish
    python library issue.

    1. BMC Ping: Verify bmc is pingable before redfish client connect.
       - to avoid redfish client python library hang issue when bmc ip
         is unreachable.

    This update also implements the following debug and robustness
    improvements:

    1. Switch from single to multi line progress to provide better progress
       detail.
    2. Add redfish client request execution duration time to the http
       status logs.
    3. Add ipv6 bool to control object to so only a single lookup is
       required.
    4. Pair action stage logs with action verified log.
    5. Fixed 2 logs that didn't have proper parameter format layout.
    6. Various logging changes to assist in future issue debug.
    7. Verify container continues to work with existing servers.

    Change-Id: I9c90ac03ece220b12708594adea582b9f640cdf3
    Closes-Bug: 1889086
    Signed-off-by: Eric MacDonald <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/761140

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/761140
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=7ad6a1a39bed42567c7757f6c820377bc4eab269
Submitter: Zuul
Branch: master

commit 7ad6a1a39bed42567c7757f6c820377bc4eab269
Author: Eric MacDonald <email address hidden>
Date: Tue Nov 3 08:30:14 2020 -0500

    Update tag for rvmc image to stx.5.0-v1.0.0

    Change-Id: I5b2e0e911f76cc108837fa753e1902c5adefe410
    Partial-Bug: 1889086
    Signed-off-by: Eric MacDonald <email address hidden>