System helm override update for Vault app not working

[ayyappa]

Brief Description
-----------------
The user override values for vault app not applying

"system helm-override-update --values vault-override.yaml vault vault vault" followed by 'sys

Severity
--------
Minor

Steps to Reproduce
------------------
1)override update the following podLabels on vault pods

cat override-vault.yaml
podlabels:
  pv: test

2)Override update the vault values
system helm-override-update --values override-vault.yaml vault vault vault

3)system apply vault
system application-apply vault

4)Verify the podlabels are applied to vault pods
kubectl get pods -n vault -l pv=test

[sysadmin@controller-0 ~(keystone_admin)]$ kubectl get pod -n vault sva-vault-0 -o jsonpath={.metadata.labels}
map[app:vault app.kubernetes.io/instance:sva-vault app.kubernetes.io/name:vault component:server controller-revision-hash:sva-vault-77f9bc4b5b helm.sh/chart:vault-0.6.0 statefulset.kubernetes.io/pod-name:sva-vault-0 vault-active:true vault-initialized:true vault-perf-standby:false vault-sealed:false vault-version:1.4.2][sysadmin@controller-0 ~(keystone_admin)]$

Expected Behavior
------------------
the podlabel should be applied on the vault pods

Actual Behavior
----------------
the override values are not taking affect on vault app

Reproducibility
---------------
100%

System Configuration
--------------------
standard wcp_3_6 ipv4

Branch/Pull Time/Commit
-----------------------
2020-07-24_00-00-00

Last Pass
---------
This is a new test scenario

Timestamp/Logs
--------------
2020-07-24T15:43:40.922783884Z

Test Activity
-------------
Feature Testing

Workaround
----------
Haven't found any

[Ghada Khalil (gkhalil)]

stx.5.0 / medium priority - should be investigated, but doesn't impact the operation of the application

[Cole Walker (cwalops)]

This appears to just be related to the structure of the submitted override values. Override values must map to the parameters seen in the vault helm chart's values.yaml file.

Once vault has been uploaded with system application-upload, values.yaml can be inspected at this path:
cat /scratch/apps/vault/1.0-9/charts/vault/values.yaml

For the example in the bug report, the override file would have to look like this (extra values included for example):
[sysadmin@controller-0 ~(keystone_admin)]$ cat override-vault.yaml
server:
  ha:
    replicas: 1
  extraLabels:
   foo: bar
  nodeSelector: |
    node-role.kubernetes.io/master: ""

Step #4 in the "Steps to Reproduce" section will also not work unless the pods are deleted and recreated. This particular override updates pod definition in the sva-vault statefulset and the labels will only be applied to subsequently created pods.

You could instead run
kubectl describe statefulsets -n vault sva-vault

and the label should be under
Pod Template:
  Labels:
    <labels are here>

Alternatively, you could delete the sva-vault-# pods and they will come back up with the label and then step #4 should work.

The key to this issue is using the correct syntax as per values.yaml