Install should fail if platform_backup partition is not created

[Frank Miller]

Brief Description
-----------------
The installer creates the platform_backup partition but does not check if it was properly created. In labs when using certain types of disks, the partition has been seen to be of type vfat instead of ext4 for example. The installation process should detect this and report a failure. One good place to add this check would be in the ansible playbook.

Severity
--------
Major

Steps to Reproduce
------------------
At this point it is not clear what disk will trigger the issue.

Expected Behavior
------------------
Installation should fail and report an error due to inability to create the platform_backup partition properly.

Actual Behavior
----------------
Install and ansible playbook completes with no errors reported for the platform_backup partition.

Reproducibility
---------------
Seen once. Only seen on a system with an incorrect partition for platform_backup.

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
stx4.0 load

Last Pass
---------
n/a

Timestamp/Logs
--------------
n/a

Test Activity
-------------
testing

Workaround
----------
none

[Ghada Khalil (gkhalil)]

stx.5.0 - given this is a robustness check and the issue is very hard to reproduce

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/742656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/742656
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=cf7eea90f59cdf583c84c4cdc85791f32f51e823
Submitter: Zuul
Branch: master

commit cf7eea90f59cdf583c84c4cdc85791f32f51e823
Author: Stefan Dinescu <email address hidden>
Date: Thu Jul 23 12:38:24 2020 +0000

    Add check for valid Platform Backup partition

    Check if the Platform Backup partition has been properly
    created by the kickstart files.

    Change-Id: I5e7d2c63da31d781a187750c2c097f9d39e6eb87
    Closes-bug: 1888514
    Depends-On: https://review.opendev.org/#/c/742569/
    Signed-off-by: Stefan Dinescu <email address hidden>

[Frank Miller (sensfan22)]

Re-opening the LP to add in a check to only run this code on an AIO-SX since only that config makes use of the platform-backup partition.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/743034

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743034
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=c904b4966021ff58f1ccccf4c373e0006782c0c4
Submitter: Zuul
Branch: master

commit c904b4966021ff58f1ccccf4c373e0006782c0c4
Author: Stefan Dinescu <email address hidden>
Date: Sat Jul 25 16:48:14 2020 +0000

    Only check for Platform Backup partition on AIO-SX

    The Platform backup partition is created on all system types,
    but it only used for AIO-SX setups. Ansible bootstrap should
    only fail on AIO-SX, since an invalid partition setup has
    no impact on other system types

    Change-Id: If31f24dae906e2e26d3af082fb14b201e9706018
    Closes-bug: 1888514
    Signed-off-by: Stefan Dinescu <email address hidden>