Helm install command for Kubernetes dashboard is deprecated

[Nicolae Jascanu]

Brief Description
-----------------
I'm following the documentation from https://docs.starlingx.io/deploy_install_guides/r4_release/kubernetes_access.html

The helm install command for stable/kubernetes-dashboard seems to be deprecated

Severity
--------
Major: Kubernetes dashboard cannot be installed

Steps to Reproduce
------------------
Follow the documentation:

[sysadmin@controller-0 ~(keystone_admin)]$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "stx-platform" chart repository
...Successfully got an update from the "starlingx" chart repository
Update Complete. ⎈ Happy Helming!⎈

[sysadmin@controller-0 ~(keystone_admin)]$ helm install stable/kubernetes-dashboard --name dashboard -f dashboard-values.yaml
Error: unknown flag: --name

[sysadmin@controller-0 ~(keystone_admin)]$ helm install dashboard stable/kubernetes-dashboard -f dashboard-values.yaml
Error: failed to download "stable/kubernetes-dashboard" (hint: running `helm repo update` may help)

Expected Behavior
------------------
No errors at install step.
A pod named dashboard-kubernetes-dashboard-.... should be created

Actual Behavior
----------------
Unknown flag --name and failure to download stable/kubernetes-dashboard

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Helm version:
[sysadmin@controller-0 ~(keystone_admin)]$ helm version
version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}

Standard with External Storage:
[sysadmin@controller-0 ~(keystone_admin)]$ cat /etc/build.info
###
### StarlingX
### Release 20.06
###

OS="centos"
SW_VERSION="20.06"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="r/stx.4.0"

JOB="STX_BUILD_4.0"
<email address hidden>"
BUILD_NUMBER="6"
BUILD_HOST="starlingx_mirror"
BUILD_DATE="2020-07-10 21:47:45 +0000"

Test Activity
-------------
Regression

Workaround
----------
It worked with the following two commands:

[sysadmin@controller-0 ~(keystone_admin)]$ helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/
"kubernetes-dashboard" has been added to your repositories

[sysadmin@controller-0 ~(keystone_admin)]$ helm install dashboard kubernetes-dashboard/kubernetes-dashboard -f dashboard-values.yaml
NAME: dashboard
LAST DEPLOYED: Wed Jul 15 09:45:54 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
*********************************************************************************
*** PLEASE BE PATIENT: kubernetes-dashboard may take a few minutes to install ***
*********************************************************************************

Get the Kubernetes Dashboard URL by running:
  export NODE_PORT=$(kubectl get -n default -o jsonpath="{.spec.ports[0].nodePort}" services dashboard-kubernetes-dashboard)
  export NODE_IP=$(kubectl get nodes -o jsonpath="{.items[0].status.addresses[0].address}")
  echo https://$NODE_IP:$NODE_PORT/

[M Camp (mcamp859)]

Thanks Nicolae for finding this error.
I will replace this command:
   helm install stable/kubernetes-dashboard --name dashboard -f dashboard-values.yaml

With these 2 commands:
   helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/
   helm install dashboard kubernetes-dashboard/kubernetes-dashboard -f dashboard-values.yaml

I will CC you on the review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/741666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/741666
Committed: https://git.openstack.org/cgit/starlingx/docs/commit/?id=fe994e73226c43dd377089238a7d2302fddaab58
Submitter: Zuul
Branch: master

commit fe994e73226c43dd377089238a7d2302fddaab58
Author: MCamp859 <email address hidden>
Date: Fri Jul 17 11:50:11 2020 -0400

    Fix K8s dashboard install command

    Correct helm command for install of Kubernetes dashboard.

    Editorial cleanup (change tabs to spaces, wrap lines @79, fix typos).

    Closes-Bug: 1887653

    Change-Id: I572a309e0fe0351effa73cc66c5c0487b527833f
    Signed-off-by: MCamp859 <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.4.0
Review: https://review.opendev.org/742525

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/742525
Committed: https://git.openstack.org/cgit/starlingx/docs/commit/?id=5eba81361059bf0b20d16f0331224be93cc498a8
Submitter: Zuul
Branch: r/stx.4.0

commit 5eba81361059bf0b20d16f0331224be93cc498a8
Author: MCamp859 <email address hidden>
Date: Fri Jul 17 11:50:11 2020 -0400

    Fix K8s dashboard install command

    Correct helm command for install of Kubernetes dashboard.

    Editorial cleanup (change tabs to spaces, wrap lines @79, fix typos).

    Closes-Bug: 1887653

    Change-Id: I572a309e0fe0351effa73cc66c5c0487b527833f
    Signed-off-by: MCamp859 <email address hidden>
    (cherry picked from commit fe994e73226c43dd377089238a7d2302fddaab58)