Subcloud upgrade failure when using multiple cgts-vg partitions

[Frank Miller]

Brief Description
-----------------
During a subcloud upgrade on an AIO-SX with 2 cgts-vg partitions, the unlock step failed when trying to create the second partition.

Severity
--------
Major: upgrade fails.

Steps to Reproduce
------------------
Perform an upgrade of a subcloud (AIO-SX).

Expected Behavior
------------------
The upgrade succeeds.

Actual Behavior
----------------
The upgrade failed.

Reproducibility
---------------
Reproducible on AIO systems with 2 cgts-vgs partitions.

System Configuration
--------------------
AIO-SX or AIO-DX configurations.

Branch/Pull Time/Commit
-----------------------
2020-06-27_18-35-20

Last Pass
---------
n/a

Timestamp/Logs
--------------
Partition table on the system before the upgreade:
# Start End Size Type Name
1 2099200 2508799 200M unknown Platform Backup
2 20482048 21096447 300M EFI System EFI System Partition
3 21096448 22120447 500M Microsoft basic primary
4 22120448 63080447 19.5G Microsoft basic primary
5 63080448 522356735 219G Linux LVM extended
6 522356736 1002604543 229G unknown LVM Physical Volume

Partition table on the system after the upgrade at time of failure:
# Start End Size Type Name
1 2048 20482047 9.8G unknown Platform Backup
2 20482048 21096447 300M EFI System EFI System Partition
3 21096448 22120447 500M Microsoft basic primary
4 22120448 63080447 19.5G Microsoft basic primary
5 63080448 539133951 227G Linux LVM extended

Error log:
2020-07-09T18:54:33.177 Notice: 2020-07-09 18:54:33 +0000 /Stage[main]/Platform::Partitions/Platform_manage_partition[check]/Exec[manage-partitions-check]/returns: 2020-07-09 18:54:32.968 84608 ERROR sysinv IOError: Could not create partition 6 of 234496MiB on disk /dev/disk/by-path/pci-0000:12:00.0-nvme-1: Error: You requested a partition from 255057MiB to 489553MiB (sectors 522356736..1002604543).
2020-07-09T18:54:33.180 Notice: 2020-07-09 18:54:33 +0000 /Stage[main]/Platform::Partitions/Platform_manage_partition[check]/Exec[manage-partitions-check]/returns: 2020-07-09 18:54:32.968 84608 ERROR sysinv The closest location we can manage is 263249MiB to 489553MiB (sectors 539133952..1002604543).

Test Activity
-------------
Feature Testing

Workaround
----------
None.

[Frank Miller (sensfan22)]

Tagging for stx.5.0 release as most users should not require 2 cgts-vg partitions.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/740658

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/740658
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=c3c561e81171c619bf7218eb16daddd46f8ee012
Submitter: Zuul
Branch: master

commit c3c561e81171c619bf7218eb16daddd46f8ee012
Author: Robert Church <email address hidden>
Date: Sun Jul 12 22:12:08 2020 -0400

    Upgrades: Add AIO partition data migration

    In STX 4.0 the /scratch partition increased from 8G to 16G. This
    increases the size of primary Linux LVM partition created by Anaconda as
    compared to the size provided in STX 3.0.

    To support the upgrade path from STX 3.0 to STX 4.0 we must migrate the
    sysinv partition information for the primary Linux LVM partition and any
    user created partitions on the root disk.

    This migration allows the new partition layout on disk to match what is
    expected in the sysinv database and will create any missing user defined
    partitions on system unlock.

    Change-Id: I060e7055d524d4ae44b595b9a172752aa5ac77ae
    Closes-Bug: #1887192
    Signed-off-by: Robert Church <email address hidden>