StarlingX/master download_mirror fails in Docker

[Davlet Panech]

Title
-----
stx-tools: StarlingX/master download_mirror fails in Docker

Brief Description
-----------------
Follow https://docs.starlingx.io/developer_resources/build_guide.html to setup docker container and run "download_mirror.sh", it always fails to download the required rpms.

Severity
--------
Critical

Steps to Reproduce
------------------
Follow the steps in build guide for creating a Docker container: https://docs.starlingx.io/developer_resources/build_guide.html . This step always fails:

cd $MY_REPO_ROOT_DIR/stx-tools/centos-mirror-tools && bash download_mirror.sh

Expected Behavior
------------------
No errors when downloading the the required files

Actual Behavior
---------------
Most downloads fail with an "rpm not found" error

Reproducibility
---------------
Reproducible

Branch
------
master/ June 29 2020 14:30 -0400

Logs
-----------------
...
Looking for libss-devel-1.42.9-13.el7.x86_64.rpm
--> run: sudo -E yumdownloader -q -C -c /tmp/stx_mirror_Wkhauy/yum.conf --releasever=7 --archlist=noarch,x86_64 libss-devel-1.42.9-13.el7
No Match for argument libss-devel-1.42.9-13.el7
Nothing to download
Warning: libss-devel-1.42.9-13.el7.x86_64.rpm not found
Looking for libss-devel-1.42.9-13.el7.x86_64.rpm
--> run: sudo -E yumdownloader -q -C -c /tmp/stx_mirror_Wkhauy/yum.conf --releasever=7 --archlist=noarch,x86_64 libss-devel-1.42.9-13.el7
No Match for argument libss-devel-1.42.9-13.el7
Nothing to download
Warning: libss-devel-1.42.9-13.el7.x86_64.rpm not found
Error: libss-devel-1.42.9-13.el7.x86_64.rpm not found
[...]

[Davlet Panech (dpanech)]

Review: https://review.opendev.org/#/c/738484/

[Ghada Khalil (gkhalil)]

stx.4.0 / high priority - given this can cause build failures

@Davlet, Is this an issue for r/stx.3.0 as well?

[Davlet Panech (dpanech)]

@Ghada: yes; this will need to be cherry picked to stx.3.0 once approved. stx.3.0 will likely need more cherry picks from other master commits though.

[Ghada Khalil (gkhalil)]

Adding the stx.3.0 label as per above

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738484
Committed: https://git.openstack.org/cgit/starlingx/tools/commit/?id=aa23b041b133c032efce238afb529e840fac58a8
Submitter: Zuul
Branch: master

commit aa23b041b133c032efce238afb529e840fac58a8
Author: Davlet Panech <email address hidden>
Date: Mon Jun 29 10:45:31 2020 -0400

    Dockerfile: add mirror repos to global yum config

    Copy mirror repo files to /etc/yum.repos.d because tb.sh needs them.
    This change fixes a problem introduced by

      Commit: 78263e8784c5f596af2a20b9c6e214fc6fea4878
      Dockerfile: pin centos & epel repo versions

    that caused centos-mirror-tools/download_mirror.sh to fail when executed
    from a docker container created by tb.sh -- "rpm not found" for most
    packages being downloaded.

    This is because download_mirror.sh without additional arguments expects
    toCOPY/yum.repos.d/ files to have been copied to /etc/yum.repos.d/ in the
    docker container by default.

    Change-Id: If214aea6560632837d0f196c21801fc2d06c8259
    Closes-Bug: 1885624
    Signed-off-by: Davlet Panech <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.3.0
Review: https://review.opendev.org/739092