resized /scratch ignored on controller-1 reinstall

[Don Penney]

Brief Description
-----------------
A recent update resized the /scratch filesystem to 16G for controllers in a hardcoded puppet manifest, as opposed to the kickstart. If the user resizes the FS to greater than 16G, it relies on sysinv to apply a runtime manifest to make the change. However, if the user then reinstalls controller-1, the sysinv config is ignored and the scratch FS is resized to 16G by the puppet manifest.

Severity
--------
Major

Steps to Reproduce
------------------
1. Install and configure AIO-DX
2. Resize /scratch to 20G:
system host-fs-modify controller-1 scratch=20
3. Lock and reinstall controller-1

Expected Behavior
------------------
After reinstall, /scratch on controller-1 is 20G

Actual Behavior
----------------
After reinstall, /scratch on controller-1 is 16G

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Duplex controllers

Branch/Pull Time/Commit
-----------------------
master, seen on June 24, 2020, baseline

Test Activity
-------------
Developer Testing

[Ghada Khalil (gkhalil)]

stx.4.0 / high priority - as noted by the reporter, issue introduced recently and breaks fs resize

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738084
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=f8c508ca062308d298aba276419086d0f9e092d7
Submitter: Zuul
Branch: master

commit f8c508ca062308d298aba276419086d0f9e092d7
Author: Don Penney <email address hidden>
Date: Thu Jun 25 14:15:30 2020 -0400

    Resize /scratch to 16G in controller kickstarts

    Update controller kickstarts to create /scratch as a 16G volume on
    installation.

    Change-Id: I68a0a67642887373924eea13a1074db753185734
    Partial-Bug: 1885168
    Signed-off-by: Don Penney <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738085
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=2ddb029f730e22adc7bf825d3088747e517a3585
Submitter: Zuul
Branch: master

commit 2ddb029f730e22adc7bf825d3088747e517a3585
Author: Don Penney <email address hidden>
Date: Thu Jun 25 14:17:44 2020 -0400

    Remove hardcoded /scratch size from manifest

    This update removes the hardcoded sizing of /scratch on controllers
    from the filesystem manifest, and instead using the configured lv_size
    from sysinv. Currently, on a reinstall of the controller, the
    configured size would be ignored, and /scratch would be resized to the
    hardcoded 16G value. Instead, the initial sizing is updated to 16G in
    the controller kickstarts, sizing /scratch to the desired default size
    on installation. If the filesystem has been resized in sysinv
    configuration to a higher value, then the filesystem manifest will now
    resize accordingly on a reinstall.

    Depends-On: https://review.opendev.org/738084
    Change-Id: Id0f7072d555018f8b19b91fd291ac3b008c10173
    Closes-Bug: 1885168
    Signed-off-by: Don Penney <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/762919