Host remains in config out of date after reinstall

[David Sullivan]

Brief Description
-----------------
After a host reinstall or upgrade the host-unlock command can be issued while the initial inventory is ongoing. This can result in the host remaining in a config-out-of-date state after unlock, requiring an additional lock/unlock to clear.

Severity
--------
Minor

Steps to Reproduce
------------------
Lock a worker host.
Issue host-reinstall
As soon as the host is back online issue host-unlock

Expected Behavior
------------------
The host unlocks and clears any config out of date alarms.

Actual Behavior
----------------
The host unlocks and a config out of date alarm remains.

Reproducibility
---------------
Reproducible - If fast enough

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
2020-06-10_20-00-00

Last Pass
---------
Unknown

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Feature Testing

Workaround
----------
Wait about 30s after the host comes online for inventory to complete.

[Ghada Khalil (gkhalil)]

stx.4.0 - would be nice to fix to avoid a stale alarm

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/737395
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=e6570225a672a1e4fb0ca367713f8dd2b8684c89
Submitter: Zuul
Branch: master

commit e6570225a672a1e4fb0ca367713f8dd2b8684c89
Author: David Sullivan <email address hidden>
Date: Mon Jun 22 18:50:45 2020 -0400

    Reset host inv_state during host-reinstall/upgrade

    Set the inv_state to 'reinstalling' during
    host-upgrade/downgrade/reinstall commands. Allow manifest generation
    when the inv_state is reinstalling. This will ensure any
    update_grub_config calls will come before the host-unlock.

    Change-Id: I6b3a5a8a65943670d0e405ba57862728dddb1210
    Closes-Bug: 1884676
    Signed-off-by: David Sullivan <email address hidden>