DC system patch strategy create/delete failed on Horizon

Bug #1883993 reported by Nimalini Rasa
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Al Bailey

Bug Description

Brief Description
-----------------
couldn't create/delete dc system patch orchestration strategy from Horizon.

Severity
--------
Major

Steps to Reproduce
------------------
Upload a patch (sw-patch --os-region-name SystemController upload)
apply the patch (sw-patch --os-region-name SystemController apply)
Try to create patch orchestration strategy from horizon
If you create the strategy via cli try deleting from horizon (dcmanager patch-strategy create --max-parallel-subclouds 100)

Expected Behavior
------------------
Patch orchestration strategy to be created.

Actual Behavior
----------------
Patch orchestration strategy creation failed

Reproducibility
---------------
Reproducible

System Configuration
--------------------
DC system controllers:Two node system with worker
Subclouds: One node system
IPv6

Branch/Pull Time/Commit
-----------------------
2020-06-11_20-00-00

Last Pass
---------
2020-04-24_11-42-06

Timestamp/Logs
--------------
2020-06-17 22:48:27

Error: 'Client' object has no attribute 'sw_update_manager'
2020-06-17 22:48:27,752 [ERROR] starlingx_dashboard.dashboards.dc_admin.dc_software_management.tables: 'Client' object has no attribute 'sw_update_manager'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/starlingx_dashboard/dashboards/dc_admin/dc_software_management/tables.py", line 92, in allowed
    strategy = get_cached_cloud_strategy(request, self.table)
  File "/usr/lib/python2.7/site-packages/starlingx_dashboard/dashboards/dc_admin/dc_software_management/tables.py", line 56, in get_cached_cloud_strategy
    api.dc_manager.get_strategy(request)
  File "/usr/lib/python2.7/site-packages/starlingx_dashboard/api/dc_manager.py", line 93, in get_strategy
    response = dcmanagerclient(request).sw_update_manager.\
AttributeError: 'Client' object has no attribute 'sw_update_manager'

Test Activity
-------------
System Test

Workaround
----------
Working via cli.

Revision history for this message
Nimalini Rasa (nrasa) wrote :
  • Logs Edit (278.7 MiB, application/x-tar)
tags: added: stx.distcloud
Changed in starlingx:
assignee: nobody → Al Bailey (albailey1974)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/736713

Changed in starlingx:
status: New → In Progress
Revision history for this message
Al Bailey (albailey1974) wrote :

Horizon only supports creating and performing a 'patch' strategy.
Be aware that there can only be one strategy at a time in a system (patch or upgrade strategy).

Therefore Horizon can abort/delete/list ALL strategies (including upgrade) since it may need to delete that upgrade strategy in order to create a new patch strategy.
Without being able to see all strategies, the error of "a strategy already exists" would seem bizarre in horizon.

Other strategies will be added in the future.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (master)

Reviewed: https://review.opendev.org/736713
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=798b0c9f3f40335163c8f52e3f2eadc492221c33
Submitter: Zuul
Branch: master

commit 798b0c9f3f40335163c8f52e3f2eadc492221c33
Author: albailey <email address hidden>
Date: Thu Jun 18 08:14:22 2020 -0500

    Fix DC patch strategy commands in Horizon

    The patch strategy classes in DC client were refactored
    to support multiple update types by
    https://review.opendev.org/#/c/720457/

    The Horizon code now uses the updated classes and methods.

    Change-Id: Idf0711fcd1c4341c6b5599c2414ba49868117cb7
    Closes-Bug: 1883993
    Signed-off-by: albailey <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
tags: added: stx.4.0 stx.update
Changed in starlingx:
importance: Undecided → Medium
Revision history for this message
Nimalini Rasa (nrasa) wrote :

Verified with load build on:2020-06-23_10-10-14

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/792252

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (f/centos8)
Download full text (16.7 KiB)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/792252
Committed: https://opendev.org/starlingx/gui/commit/63d6de4701a7f21779ad9ea4060fce9ed85bc71f
Submitter: "Zuul (22348)"
Branch: f/centos8

commit e05e1a43531499d94cfb1e538683ee36eea92b43
Author: Teresa Ho <email address hidden>
Date: Thu May 13 23:04:04 2021 -0400

    Do not display primary_reselect if not specified

    If the attribute 'primary_reselect' is not specified, the sysinv API
    will leave it as null and GUI will not display the attribute.

    Closes-Bug: 1928461

    Change-Id: I5b8ef8b29fb7775dde8607bb14cd733015269f82
    Signed-off-by: Teresa Ho <email address hidden>

commit f1a4d30eca91c7a239ebd7479a56fef7870a4b2e
Author: Pablo Bovina <email address hidden>
Date: Fri May 7 16:59:50 2021 -0300

    Display DataNetworks list

    DataNetworks are listed for pci-sriov
    under Create/Edit Interface forms.

    Closes-bug: 1927782
    Signed-off-by: Pablo Bovina <email address hidden>
    Change-Id: If927bb0facdec9e587a13354bef56eca5df08785

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu May 6 07:32:59 2021 -0400

    In AIO-SX, interface edit rejected with Host administrative unlocked

    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".

    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.

    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):

    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected

    Locked state:
    all conversions (with network/datanetwork assignment) are accepted

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

commit ddcc4fd3ccb4c02580c71414345993252b089761
Author: Enzo Candotti <email address hidden>
Date: Tue May 4 11:08:57 2021 -0300

    Enable add/edit Worker personality on DC AIO-DX's GUI

    This update is to allow the option to add a new host with Worker
    personality on Distributed Cloud mode.

    Closes-Bug: 1927107

    Signed-off-by: Enzo Candotti <email address hidden>
    Change-Id: Idfed9352c7c6467014a2ed2cf10b70f6b470c28c

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fer...

tags: added: in-f-centos8
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on gui (f/centos8)

Change abandoned by "Bart Wensley <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/765064
Reason: This patch has been idle for more than six months. I am abandoning it to keep the review queue sane. If you are still interested in working on this patch, please unabandon it and upload a new patchset.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.