branching scripts fail due to unexpected operator in repo forall sub-script

[Saul Wold]

When running the branching/create_branches_and_tags.sh script, I was seeing errors similar to this:

 if [ $REPO_PATH == cgcs-root ]; then echo $REPO_PROJECT; fi: 1: [: cgcs-root: unexpected operator

This is due to the double '==' in the if statement. When changed to the single '=', which is the more correct form, this if statement works correctly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/735993

[Ghada Khalil (gkhalil)]

Marking as high priority assuming this is required to enable the stx.4.0 RC1 branch creation.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/735993
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=4cb7539a9f676f652fbb4823caf721065db1352a
Submitter: Zuul
Branch: master

commit 4cb7539a9f676f652fbb4823caf721065db1352a
Author: Saul Wold <email address hidden>
Date: Tue Jun 16 11:34:51 2020 -0700

    use single '=' for string equality in repo forall

    The sub-script fails when a double '==' is used inside of a repo
    forall -c option. The single '=' is preferred when used in 'test'
    or '['.

    The error is similar to this:
    if [ $REPO_PATH == cgcs-root ]; then echo $REPO_PROJECT; fi: 1: [: cgcs-root: unexpected operator

    Closes-Bug: 1883772
    Change-Id: If17de30a03939240f0cc329179d452820a691e32
    Signed-off-by: Saul Wold <email address hidden>