Cannot delete image-conversion filesystem with system host-fs-delete

[Melissa Wang]

Brief Description
-----------------
When attempting to delete the filesystem "image-conversion" from a controller, it results in the error "not enough arguments for format string"

Severity
--------
Major

Steps to Reproduce
------------------
1. Install a distributed cloud
2. On the central cloud, execute "system host-fs-add controller-0 image-conversion=1"
3. Execute "system host-fs-delete controller-0 image-conversion"

Expected Behavior
------------------
[sysadmin@controller-0 ~(keystone_admin)]$ system host-fs-list controller-0
+--------------------------------------+------------------+-------------+----------------+
| UUID | FS Name | Size in GiB | Logical Volume |
+--------------------------------------+------------------+-------------+----------------+
| bbc918c0-6daf-4376-9a65-267ed120966c | backup | 20 | backup-lv |
| 56249984-fb90-44ba-82cf-c1184c1a9693 | docker | 30 | docker-lv |
| 4dc641ad-7211-49aa-9045-a7a465513d42 | image-conversion | 1 | conversion-lv |
| f3130f96-7261-4c9f-b89d-d9d680a95828 | kubelet | 10 | kubelet-lv |
| 697cd8ff-5e3c-4520-b258-cf4bb624db25 | scratch | 16 | scratch-lv |
+--------------------------------------+------------------+-------------+----------------+

[sysadmin@controller-0 ~(keystone_admin)]$ system host-fs-delete controller-0 image-conversion
[sysadmin@controller-0 ~(keystone_admin)]$ system host-fs-list controller-0
+--------------------------------------+------------------+-------------+----------------+
| UUID | FS Name | Size in GiB | Logical Volume |
+--------------------------------------+------------------+-------------+----------------+
| bbc918c0-6daf-4376-9a65-267ed120966c | backup | 20 | backup-lv |
| 56249984-fb90-44ba-82cf-c1184c1a9693 | docker | 30 | docker-lv |
| f3130f96-7261-4c9f-b89d-d9d680a95828 | kubelet | 10 | kubelet-lv |
| 697cd8ff-5e3c-4520-b258-cf4bb624db25 | scratch | 16 | scratch-lv |
+--------------------------------------+------------------+-------------+----------------+

Actual Behavior
----------------
[sysadmin@controller-0 ~(keystone_admin)]$ system host-fs-delete controller-0 image-conversion
not enough arguments for format string

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Distributed Cloud, on the system controller

Branch/Pull Time/Commit
-----------------------
starling-x/master, bootimage built on June 3, 2020

Timestamp/Logs
--------------
From /var/log/sysinv.log:

sysinv 2020-06-08 17:19:10.653 23501 ERROR wsme.api [-] Server-side error: "not enough arguments for format string". Detail:
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/wsmeext/pecan.py", line 85, in callfunction
    result = f(self, *args, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host_fs.py", line 341, in delete
    _delete(host_fs)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host_fs.py", line 484, in _delete
    constants.HELM_APP_OPENSTACK, host_fs['name'])

TypeError: not enough arguments for format string

Test Activity
-------------
Manual

Workaround
----------
N/A

[Ghada Khalil (gkhalil)]

stx.5.0 / medium - very specific failure, not urgent for stx.4.0; suggest to fix for stx.5.0

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/735507
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=d2f7aaaf6ba9ad5a91ef666058259ba1094603ad
Submitter: Zuul
Branch: master

commit d2f7aaaf6ba9ad5a91ef666058259ba1094603ad
Author: Elena Taivan <email address hidden>
Date: Mon Jun 15 06:26:27 2020 +0000

    Fix system host-fs-delete command

    When the stx-openstack application is not present,
    the log function was malformed due to missing parantheses.
    Adding parantheses to fix it.

    Change-Id: I9bd55813b14f584467cc6fc012a1a0709456885b
    Closes-bug: 1883299
    Signed-off-by: Elena Taivan <email address hidden>

[Ghada Khalil (gkhalil)]

Changing the release tag to stx.4.0 since the fix was merged in stx master for that release.