900.006 alarm is not gone after device image is deleted

[Difu Hu]

Brief Description
-----------------
After device image is deleted, 900.006 alarm
"Device image update operation in progress" keeps there

Severity
--------
Major

Steps to Reproduce
------------------
create device image and apply label
900.006 alarm is raised
delete the image

Expected Behavior
------------------
900.006 alarm is gone

Actual Behavior
----------------
900.006 alarm keeps there

Reproducibility
---------------
permanent

System Configuration
--------------------
Lab-name: wp_16_17

Branch/Pull Time/Commit
-----------------------
Designer build from 2020-06-09_20-00-00

Last Pass
---------
N/A

Timestamp/Logs
--------------
[sysadmin@controller-1 ~(keystone_admin)]$ system device-image-state-list

[sysadmin@controller-1 ~(keystone_admin)]$ fm alarm-list
+-------+------------------------------------------------
| Alarm | Reason Text
| ID |
+-------+------------------------------------------------
| 900. | Device image update operation in progress
| 006 |
| |
+-------+------------------------------------------------

Test Activity
-------------
Functional Testing

[Ghada Khalil (gkhalil)]

@Difu, just to clarify, are you deleting the image while the update is in progress?

[Difu Hu (difuhu)]

No, hadn't done host-device-image-update.
image was deleted right after device-image-apply label.

[Ghada Khalil (gkhalil)]

stx.5.0 - minor issue; incorrect alarm handling

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/740113

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/740113
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=81f783c395a461827a8d23e20feda20a195a079f
Submitter: Zuul
Branch: master

commit 81f783c395a461827a8d23e20feda20a195a079f
Author: Teresa Ho <email address hidden>
Date: Tue Jul 7 13:22:36 2020 -0400

    Clear alarm after last device image deletion

    The in-progress alarm is raised when the first device image is applied
    to a device. If the host device image update is never issued and the
    device images are deleted, then the alarm should be cleared as it is
    returned to the initial state.
    This update is to clear the alarm when the last device image is deleted.

    Closes-Bug: 1883293

    Change-Id: I113895731880ee5312bb915639df65b06430a421
    Signed-off-by: Teresa Ho <email address hidden>

[Ghada Khalil (gkhalil)]

Re-opening as a follow-up commit is needed

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744051
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=5c24844b84403e766cf03a0966c659e7a2fb289b
Submitter: Zuul
Branch: master

commit 5c24844b84403e766cf03a0966c659e7a2fb289b
Author: Teresa Ho <email address hidden>
Date: Thu Jul 30 15:31:33 2020 -0400

    Fixes for device image alarm

    This commit clears the in-progress alarm if there is no more
    pending, failed or in-progress device images to be updated
    after a device image is removed.

    It also raises the alarm only when there are pending image updates.
    If the system does not have any FPGA devices then the alarm is not
    raised as there is no image update to be processed.

    This commit also improved some comments about the applied field.

    Story: 2007875
    Task: 40392
    Closes-Bug: 1883293

    Change-Id: Ie8a8e6071ba9d5296992d46e410a7cbf19f8e1d1
    Signed-off-by: Teresa Ho <email address hidden>

[Difu Hu (difuhu)]

Verified on build 2020-08-06_20-00-00.