system helm-override-show stx-openstack mariadb openstack crash

[Austin Sun]

StarlingX bug reporting guidelines:
Please use the template below when opening StarlingX bugs.

Brief Description
-----------------
once stx-openstack uploaded. run command
"system helm-override-show stx-openstack mariadb openstack "
commmand will prompt crash

Severity
--------
Provide the severity of the defect.
<Critical: System/Feature is not usable due to the defect>
<Major: System/Feature is usable but degraded>
<Minor: System/Feature is usable with minor issue>
Minor
Steps to Reproduce
------------------
deploy system , run any openstack helm-override command

Expected Behavior
------------------
expect see overrides result

Actual Behavior
----------------
return
File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 10764, in get_helm_chart_overrides
    cnamespace)

  File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 49, in _wrapper
    return func(self, *args, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 268, in get_helm_chart_overrides
    return self._get_helm_chart_overrides(chart_name, cnamespace)

  File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 311, in _get_helm_chart_overrides
    cnamespace))

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/mariadb.py", line 31, in get_overrides
    'endpoints': self._get_endpoints_overrides(),

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/mariadb.py", line 64, in _get_endpoints_overrides
    self.CHART, [])

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/openstack.py", line 318, in _get_endpoints_oslo_db_overrides
    'password': self._get_common_password('admin_db'),

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/openstack.py", line 356, in _get_common_password
    'keystone', common.HELM_NS_OPENSTACK, name)

AttributeError: 'NoneType' object has no attribute 'HELM_NS_OPENSTACK'

Reproducibility
---------------
<Reproducible/Intermittent/Seen once>
100%

System Configuration
--------------------
All

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
NA

Timestamp/Logs
--------------
File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 10764, in get_helm_chart_overrides
    cnamespace)

  File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 49, in _wrapper
    return func(self, *args, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 268, in get_helm_chart_overrides
    return self._get_helm_chart_overrides(chart_name, cnamespace)

  File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 311, in _get_helm_chart_overrides
    cnamespace))

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/mariadb.py", line 31, in get_overrides
    'endpoints': self._get_endpoints_overrides(),

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/mariadb.py", line 64, in _get_endpoints_overrides
    self.CHART, [])

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/openstack.py", line 318, in _get_endpoints_oslo_db_overrides
    'password': self._get_common_password('admin_db'),

  File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/openstack.py", line 356, in _get_common_password
    'keystone', common.HELM_NS_OPENSTACK, name)

AttributeError: 'NoneType' object has no attribute 'HELM_NS_OPENSTACK'
Test Activity
-------------
Develop Testing

 Workaround
 ----------

[Austin Sun (sunausti)]

This should be related "Enable helm/armada plugin delivery with the application"
https://review.opendev.org/#/c/688190/

[Austin Sun (sunausti)]

In codes.there are several places to deactivate_plugins, for example _save_images_list and _upload_helm_charts. once remove deactivate_plugins in that places ,the show command can be successfully .

I don't know the logic why need to call deactivate_plugins, suggest helm plugin take it.

[Ghada Khalil (gkhalil)]

stx.4.0 - issue introduced by new code changes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/733510

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/733510
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=4617f4d0bec8af850cc77d7504fd02667857ff6b
Submitter: Zuul
Branch: master

commit 4617f4d0bec8af850cc77d7504fd02667857ff6b
Author: Robert Church <email address hidden>
Date: Wed Jun 3 13:52:57 2020 -0400

    Robustness updates to support application plugins

    Changes include:
    - Supporting viewing overrides for non-applied uploaded only
      applications
    - Re-enable sysinv-helm commands to support plugin development
    - Expand version pattern match when discovering plugins to account for
      tarball versions produced from the Cengn build
    - Ensure that applications which are in an apply related state have
      their plugins enabled when the conductor is restarted.

    Change-Id: Ic233ec529065de80105a077d83e56afda2f3ee14
    Closes-Bug: #1881711
    Closes-Bug: #1881454
    Signed-off-by: Robert Church <email address hidden>