openstack application upload failed if no storage backend is provisioned

[Austin Sun]

Please use the template below when opening StarlingX bugs.

Brief Description
-----------------
The openstack application is upload fail if no storage backend
Severity
--------
Provide the severity of the defect.
<Critical: System/Feature is not usable due to the defect>
<Major: System/Feature is usable but degraded>
<Minor: System/Feature is usable with minor issue>
Minor

Steps to Reproduce
------------------
Write down the steps to reproduce the issue
not enable storage backend
system application-upload stx-openstack-1.0-21-centos-stable-latest.tgz

Expected Behavior
------------------
application could be uploaded

Actual Behavior
----------------
application upload failure

Reproducibility
---------------
100%
System Configuration
--------------------
All system config
Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info

Last Pass
---------
Did this test scenario pass previously? If so, please indicate the load/pull time info of the last pass.
Use this section to also indicate if this is a new test scenario.

Timestamp/Logs
--------------
sysinv 2020-06-02 06:10:02.480 95343 INFO sysinv.conductor.manager [-] Platform managed application platform-integ-apps: Prerequisites not met.
sysinv 2020-06-02 06:10:02.489 95343 INFO sysinv.conductor.manager [-] Platform managed application oidc-auth-apps: Prerequisites not met.
sysinv 2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app [-] 'NoneType' object has no attribute 'capabilities': AttributeError: 'NoneType' object has no attribute 'capabilities'
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app Traceback (most recent call last):
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1962, in perform_app_upload
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app self._save_images_list(app)
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 633, in _save_images_list
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app armada_format=True, armada_chart_info=app.charts, combined=True)
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 49, in _wrapper
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app return func(self, *args, **kwargs)
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 643, in generate_helm_application_overrides
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app cnamespace)
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 406, in _get_helm_application_overrides
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app cnamespace)})
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 311, in _get_helm_chart_overrides
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app cnamespace))
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/nova.py", line 81, in get_overrides
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app 'ephemeral_storage': self._get_rbd_ephemeral_storage()
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/opt/platform/helm/20.06/stx-openstack/1.0-21-centos-stable-latest/plugins/k8sapp_openstack/helm/nova.py", line 565, in _get_rbd_ephemeral_storage
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app StorageBackendConfig.get_ceph_pool_replication(self.dbapi)
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/common/storage_backend_conf.py", line 310, in get_ceph_pool_replication
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app pool_size = int(ceph_backend.capabilities[
2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app AttributeError: 'NoneType' object has no attribute 'capabilities

2020-06-02 06:10:04.504 95343 ERROR sysinv.conductor.kube_app
sysinv 2020-06-02 06:10:04.578 95343 ERROR sysinv.conductor.kube_app [-] Application upload aborted!.
sysinv 2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp [-] Exception during message handling: KubeAppUploadFailure: Upload of application stx-openstack (1.0-21-centos-stable-latest) failed: 'NoneType' object has no attribute 'capabilities'
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp Traceback (most recent call last):
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/amqp.py", line 437, in _process_data
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp **args)
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/dispatcher.py", line 172, in dispatch
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp result = getattr(proxyobj, method)(ctxt, **kwargs)
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 10958, in perform_app_upload
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp self._app.perform_app_upload(rpc_app, tarfile)
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1980, in perform_app_upload
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp name=app.name, version=app.version, reason=e)
2020-06-02 06:10:04.579 95343 ERROR sysinv.openstack.common.rpc.amqp KubeAppUploadFailure: Upload of application stx-openstack (1.0-21-centos-stable-latest) failed: 'NoneType' object has no attribute 'capabilities'

Test Activity
-------------
Sanity
 Workaround
 ----------
 Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/732484

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/732484
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=1038873196089a7f171616582bc693afa45955b0
Submitter: Zuul
Branch: master

commit 1038873196089a7f171616582bc693afa45955b0
Author: Sun Austin <email address hidden>
Date: Tue Jun 2 14:46:51 2020 +0800

    return default value if no storage backend enable

    if no storage backend enable, once upload stx-openstack application
    the sysinv will crash and upload abort
    AttributeError: 'NoneType' object has no attribute 'capabilities'
    to avoid this ,return default value if no storage backend

    Change-Id: I00b561ff297a1e2567e591f82bbc5b8ba8bd36f4
    Closes-Bug: 1881706
    Signed-off-by: Sun Austin <email address hidden>