Distributed Cloud: temp files that used by patch-api-proxy to upload a large patch are not closed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Medium
|
Tao Liu |
Bug Description
Brief Description
-----------------
After a single upload of ~900MB patch is complete, /scratch usage jumped from 3% to 26%. The temporary files that opened by the third-party libraries are not closed after upload is completed. As a result, a few of large patch uploads will exhaust /scratch space.
Here are the deleted files held by one of the patching-api-proxy workers
dcorch-ap 118991 root 4u REG 253,0 941866267 15 /scratch/
dcorch-ap 118991 root 9u REG 253,0 941866434 14 /scratch/
A change is required in the patch-api-proxy process to close any temporary files that used to upload a large patch.
Severity
--------
Major
Steps to Reproduce
------------------
Install DC system with 1 or 2 subclouds, upload a large patch using SystemController region:
sw-patch --os-region-name SystemController upload LARGE_patch_
Expected Behavior
------------------
The system resources that used for upload free up after upload is completed.
Actual Behavior
----------------
Two temporary files are not released.
Reproducibility
---------------
Reproducible
System Configuration
-------
Distributed Cloud with 2 subclouds
Branch/Pull Time/Commit
-------
2020-05-22_04-10-00
Last Pass
---------
unknown
Timestamp/Logs
--------------
N/A
Changed in starlingx: | |
assignee: | nobody → Tao Liu (tliu88) |
tags: | added: stx.distcloud |
Changed in starlingx: | |
importance: | Undecided → Medium |
tags: | added: stx.4.0 |
Fix proposed to branch: master /review. opendev. org/730675
Review: https:/