StarlingX

sriov device plugin image build fails

Bug #1878224 reported by Steven Webster on 2020-05-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	StarlingX	Fix Released	Critical	Steven Webster

Bug Description

Brief Description
-----------------
A recent commit to uprev the SR-IOV device plugin required changes to the image build:

https://opendev.org/starlingx/integ/commit/d204f10ab53414dd46d5eb51fd99950d3ab70fa8

The build script introduced in this commit utilizes a Makefile to do build the plugin binary, then the image.

Building the binary depends on go being present on the host. If it is not, the build will fail.

Building the binary is actually not required, as it will be also done in a container as part of the 'make image', rather than copying the binary from the host.

Severity
--------
Critical: This is causing the CENGN docker image build to fail

Steps to Reproduce
------------------
Run the build-stx-images.sh without go installed on the build host

Expected Behavior
------------------
Image should be built without failure

Actual Behavior
----------------
The CENGN docker image build fails to perform the go build.

Workaround
----------
The build-sriov-network-device-plugin-image.sh script should not perform a 'make build'

Tags:

Steven Webster (swebster-wr) on 2020-05-12

Changed in starlingx:
assignee:	nobody → Steven Webster (swebster-wr)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-12: Fix proposed to integ (master)

Fix proposed to branch: master
Review: https://review.opendev.org/727218

Changed in starlingx:
status:	New → In Progress

Revision history for this message

Ghada Khalil (gkhalil) wrote on 2020-05-12:

stx.4.0 / critical severity - build issue introduced by recent commits

tags:	added: stx.netwo2
tags:	added: stx.4.0 stx.build stx.networking removed: stx.netwo2
Changed in starlingx:
importance:	Undecided → Critical

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-12: Fix merged to integ (master)

Reviewed: https://review.opendev.org/727218
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=e2dc5c2dd0042788697ade268ac5c24fe9dc2f8c
Submitter: Zuul
Branch: master

commit e2dc5c2dd0042788697ade268ac5c24fe9dc2f8c
Author: Steven Webster <email address hidden>
Date: Tue May 12 10:32:21 2020 -0400

Fix sriov device plugin image build

Previous commit d204f10ab5 introduced a build script to assist
in building the SR-IOV device plugin.

The script utilizes a Makefile to do build the plugin binary,
then the image.

Building the binary depends on go being present on the host. If it
is not, the build will fail.

    Building the binary is actually not required, as it will be also
    done in a container as part of the 'make image', rather than copying
    the binary from the host.

    Closes-Bug: #1878224
    Change-Id: I4499ea2bbef4b3da8a154c69a07b415574517500
    Signed-off-by: Steven Webster <email address hidden>

Changed in starlingx:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-21: Fix proposed to integ (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729834

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-21: Fix merged to integ (f/centos8)

Download full text (15.2 KiB)

Reviewed: https://review.opendev.org/729834
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=e4d12decc4c702e1e908d2430c7b4bc524c31c07
Submitter: Zuul
Branch: f/centos8

commit 5bb777d3725a48bc18431daedb6fd67198cd053a
Author: SidneyAn <email address hidden>
Date: Wed May 20 23:22:06 2020 +0800

Add python-daemon to srpm list

add python-daemon-2.2.3-7.el8.src.rpm to srpm list
for pkg python3-daemon building.

    Change-Id: I0ad60d1083222130e72f935e08f97a8608b75880
    Story: 2007106
    Task: 39291
    Signed-off-by: SidneyAn <email address hidden>

commit fc125a7a24c00850aafd4a791a63e8e627b5ee1e
Author: Ran An <email address hidden>
Date: Thu May 14 11:41:50 2020 +0000

Revert "Add python3-daemon required by logmgmt"

This reverts commit 97cd7ea5c1037dd22488793ea9271462fedc4c7a.

Change-Id: I3f09054c1546252493f8eb29dc70806829324a52

commit 97cd7ea5c1037dd22488793ea9271462fedc4c7a
Author: SidneyAn <email address hidden>
Date: Fri Apr 3 15:48:09 2020 +0800

Add python3-daemon required by logmgmt

pkg logmgmt upgraded to python3 requires python3 model "daemon",
and no pkgs in Centos7 offical repo provide it.

this patch refer to the python3-daemon pkg build by rdo
for CentOS 8: python-daemon-2.2.3-7.el8.src.rpm

disable the rpm check part which is not required in stx to
reduce python3 dependencies that not supported by CentOS 7

    Depends-on: https://review.opendev.org/#/c/727657/
    Depends-on: https://review.opendev.org/#/c/727662/
    Change-Id: Ie08ea9c7adf830ad4e8e924fa69352fb2a923a6f
    Story: 2007106
    Task: 39291
    Signed-off-by: SidneyAn <email address hidden>

commit e2dc5c2dd0042788697ade268ac5c24fe9dc2f8c
Author: Steven Webster <email address hidden>
Date: Tue May 12 10:32:21 2020 -0400

Fix sriov device plugin image build

Previous commit d204f10ab5 introduced a build script to assist
in building the SR-IOV device plugin.

The script utilizes a Makefile to do build the plugin binary,
then the image.

Building the binary depends on go being present on the host. If it
is not, the build will fail.

    Building the binary is actually not required, as it will be also
    done in a container as part of the 'make image', rather than copying
    the binary from the host.

    Closes-Bug: #1878224
    Change-Id: I4499ea2bbef4b3da8a154c69a07b415574517500
    Signed-off-by: Steven Webster <email address hidden>

commit d204f10ab53414dd46d5eb51fd99950d3ab70fa8
Author: Steven Webster <email address hidden>
Date: Fri Apr 24 10:59:59 2020 -0400

Uprev the SR-IOV device plugin to the latest version

This is intended primarily to pick up support for SR-IOV
accelerators.

    The builder has been changed to a script model, as the
    device plugin's Dockerfile has been moved to a separate
    directory. The build-stx-images script does find this file,
    but the docker build will fail as the device plugin's
    source directory is no longer where the builder expects
    it to be. Instead, use the existing Makefile to assist
    in building the bi...

Reviewed:  https://review.opendev.org/729834
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=e4d12decc4c702e1e908d2430c7b4bc524c31c07
Submitter: Zuul
Branch:    f/centos8

commit 5bb777d3725a48bc18431daedb6fd67198cd053a
Author: SidneyAn <ran1.an@intel.com>
Date:   Wed May 20 23:22:06 2020 +0800

Add python-daemon to srpm list
    
    add python-daemon-2.2.3-7.el8.src.rpm to srpm list
    for pkg python3-daemon building.
    
    Change-Id: I0ad60d1083222130e72f935e08f97a8608b75880
    Story: 2007106
    Task: 39291
    Signed-off-by: SidneyAn <ran1.an@intel.com>

commit fc125a7a24c00850aafd4a791a63e8e627b5ee1e
Author: Ran An <ran1.an@intel.com>
Date:   Thu May 14 11:41:50 2020 +0000

Revert "Add python3-daemon required by logmgmt"
    
    This reverts commit 97cd7ea5c1037dd22488793ea9271462fedc4c7a.
    
    Change-Id: I3f09054c1546252493f8eb29dc70806829324a52

commit 97cd7ea5c1037dd22488793ea9271462fedc4c7a
Author: SidneyAn <ran1.an@intel.com>
Date:   Fri Apr 3 15:48:09 2020 +0800

Add python3-daemon required by logmgmt
    
    pkg logmgmt upgraded to python3 requires python3 model "daemon",
    and no pkgs in Centos7 offical repo provide it.
    
    this patch refer to the python3-daemon pkg build by rdo
    for CentOS 8: python-daemon-2.2.3-7.el8.src.rpm
    
    disable the rpm check part which is not required in stx to
    reduce python3 dependencies that not supported by CentOS 7
    
    Depends-on: https://review.opendev.org/#/c/727657/
    Depends-on: https://review.opendev.org/#/c/727662/
    Change-Id: Ie08ea9c7adf830ad4e8e924fa69352fb2a923a6f
    Story: 2007106
    Task: 39291
    Signed-off-by: SidneyAn <ran1.an@intel.com>

commit e2dc5c2dd0042788697ade268ac5c24fe9dc2f8c
Author: Steven Webster <steven.webster@windriver.com>
Date:   Tue May 12 10:32:21 2020 -0400

Fix sriov device plugin image build
    
    Previous commit d204f10ab5 introduced a build script to assist
    in building the SR-IOV device plugin.
    
    The script utilizes a Makefile to do build the plugin binary,
    then the image.
    
    Building the binary depends on go being present on the host. If it
    is not, the build will fail.
    
    Building the binary is actually not required, as it will be also
    done in a container as part of the 'make image', rather than copying
    the binary from the host.
    
    Closes-Bug: #1878224
    Change-Id: I4499ea2bbef4b3da8a154c69a07b415574517500
    Signed-off-by: Steven Webster <steven.webster@windriver.com>

commit d204f10ab53414dd46d5eb51fd99950d3ab70fa8
Author: Steven Webster <steven.webster@windriver.com>
Date:   Fri Apr 24 10:59:59 2020 -0400

Uprev the SR-IOV device plugin to the latest version
    
    This is intended primarily to pick up support for SR-IOV
    accelerators.
    
    The builder has been changed to a script model, as the
    device plugin's Dockerfile has been moved to a separate
    directory.  The build-stx-images script does find this file,
    but the docker build will fail as the device plugin's
    source directory is no longer where the builder expects
    it to be.  Instead, use the existing Makefile to assist
    in building the binary and image.
    
    Testing has been performed as follows:
    
    System Types:
        AIO-SX, Standard
    Cluster network types:
        IPv4, IPv6
    NIC types:
        82599ES 10-Gigabit [10fb],
        MT27710 Family [ConnectX-4 Lx] [1015],
        X710 for 10GbE [1572]
    IPAM types:
        host-local,
        calico,
        dhcp,
        static
    Connectivity between pods:
        DPDK,
        netdevice
    
    Story: 2006740
    Task: 39610
    Change-Id: If07bf2baa7d1cc32067cc73b37011ff808f0a527
    Signed-off-by: Steven Webster <steven.webster@windriver.com>

commit 16ec1ab35e94a1dfa7a66c876ea7537d53a2c691
Author: Saul Wold <sgw@linux.intel.com>
Date:   Thu May 7 09:57:42 2020 -0700

Fix TIS_PATCH_VER for keystone and openstacklib
    
    Packages were not getting versioned correctly after they were updated
    because the TIS_PATCH_VER was not updated. When we update a package
    the TIS_PATCH_VER needs to be updated otherwise the build system will
    not see the update correctly.
    
    Build packages, ISO verified updated packages installed and system ran
    ansible-playbook correctly.
    
    Closes-Bug: 1877035
    Change-Id: Ifd38b42b0403796bb2445e433cef43100a5434ef
    Signed-off-by: Saul Wold <sgw@linux.intel.com>

commit 02dd02d591e4139cf1d3d9e237f55952cf9805a4
Author: Jim Somerville <Jim.Somerville@windriver.com>
Date:   Tue May 5 14:21:51 2020 -0400

Move mellanox userspace from integ repo
    
    libibverbs and rdma-core are part of the mellanox driver
    software package and to facilitate layering, shouldn't
    be split across different repos.
    
    Move them from the integ repo to the kernel repo so they
    can co-reside with the kernel module portion.
    
    Change-Id: I4c8582dadbae52b342d7178313d8b62beeb61148
    Closes-Bug: 1877160
    Depends-On: I41153feceef4eb26a41ff634c60dc3adaaf238b1
    Signed-off-by: Jim Somerville <Jim.Somerville@windriver.com>

commit 838bdd44b6c7073a8362f5770bb85303ed90c84f
Author: Scott Little <scott.little@windriver.com>
Date:   Mon May 4 15:02:39 2020 -0400

fix mellanox lst file entries
    
    Build broken by commit 5056c8458696acb429279a3c07f12971f0b386df
    which changed the version of the libibverbs and rdms-core packages
    without a matching change to the lst files.
    
    This update brings the lst file into line with the new version.
    
    Story: 2007308
    Task: 38805
    Task: 38806
    Change-Id: I0a305804e0a4cf7c1dd06c3a6ec1af5724dcdfc5
    Signed-off-by: Scott Little <scott.little@windriver.com>

commit fcda408c78a16a2fdc04e79cf30d475c57a71895
Author: Shuicheng Lin <shuicheng.lin@intel.com>
Date:   Wed Mar 4 15:02:54 2020 +0800

Fix net-tools build issue with 4.18 kernel from CentOS 8
    
    Fix struct redefinition issue caused by new kernel header file.
    Merge versioning patch with tis patch.
    
    Story: 2007308
    Task: 38928
    Depends-On: https://review.opendev.org/720325
    
    Change-Id: I073cb3789bcadc0720bf37c0eb12e53d1afffa8c
    Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>

commit 5056c8458696acb429279a3c07f12971f0b386df
Author: Dongqi Chen <chen.dq@neusoft.com>
Date:   Thu Apr 16 15:13:20 2020 +0800

Upgrade mellanox drivers to 4.7-3.2.9.0 to support CentOS 8.1
    
    (cherry picked from commit e14efd21d02f9d2fd2290625107958a84c29f713)
    
    2 modules are upgraded: rdma-core and libibverbs.
    driver sign method is updated to align with 4.18 kernel.
    
    Change-Id: I446a319d682d50f7e6f08b53b902f31309eb8ecf
    Story: 2007308
    Task: 38805
    Task: 38806
    Depends-On: https://review.opendev.org/720325
    Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
    Signed-off-by: Dongqi Chen <chen.dq@neusoft.com>

commit 52a66268db015798c9ec3998933952470b50c178
Author: Stefan Dinescu <stefan.dinescu@windriver.com>
Date:   Thu Apr 30 17:43:55 2020 +0000

Fix trident-installer license
    
    The proper license is Apache-2.0
    
    Change-Id: I67f6dfb426e274102a4a94541278e21100e6e34d
    Story: 2007391
    Task: 39603
    Signed-off-by: Stefan Dinescu <stefan.dinescu@windriver.com>

commit 530c27f2c9d540f99ceb5717a0f04134b5795046
Author: Stefan Dinescu <stefan.dinescu@windriver.com>
Date:   Wed Apr 29 07:11:28 2020 +0000

Upversion Netapp installer to version 20.04
    
    Change-Id: Ia435fe7be3b9bcd4e7daed9d3ce05176b7192343
    Story:2007391
    Task: 39593
    Signed-off-by: Stefan Dinescu <stefan.dinescu@windriver.com>

commit a8446da39ecce4570573dbe4aeee0d97c1f374db
Author: Yong Fu <fuyong@neusoft.com>
Date:   Wed Apr 29 10:14:17 2020 +0800

[kernel-rt 4.18] adding rt-setup project
    
    rt-setup is requested for kernel-rt 4.18.0-147.3.1
    
    Change-Id: Ifafa115ce7f76845bb6c93abf5ec743632f79694
    Story: 2007308
    Task: 38884
    Depends-on: https://review.opendev.org/#/c/716210/
    Depends-on: https://review.opendev.org/#/c/722569/
    Signed-off-by: Sun Austin <austin.sun@intel.com>
    Signed-off-by: Dongqi Chen <chen.dq@neusoft.com>
    Signed-off-by: Yong Fu <fuyong@neusoft.com>

commit ae66f40278142252182b53dc92baf32ee5c10d1f
Author: Robert Church <robert.church@windriver.com>
Date:   Tue Apr 28 01:53:10 2020 -0400

Fix storage topology pylint 2.5.0 error
    
    pylint 2.5.0 was recently introduced with:
    - Added a new warning, 'unsupported-assignment-operation', which is
      emitted when item assignment is tried on an object which doesn't have
      this ability. Closes issue #591.
    
    Looking at the implementation of prettytable, this appears to be a false
    positive. Disable the check via pragma.
    
    Change-Id: Iebaee525e2af958ca4f877be40768641391c2525
    Signed-off-by: Robert Church <robert.church@windriver.com>

commit e61f896475ca22a7fab38320b38522110f600f90
Author: Robert Church <robert.church@windriver.com>
Date:   Thu Apr 23 17:16:03 2020 -0400

Add volumesnapshots cluster addon to k8s RPM
    
    To support the NetApp Trident project, include the volumesnapshots CRD
    and controller for deployment when applicable.
    
    Change-Id: I999ed6c8acce8de42f12fa331505225f43d580a6
    Story: 2007391
    Task: 39542
    Signed-off-by: Robert Church <robert.church@windriver.com>

commit 05601cbc40ebb9a4bcc1c6bf4bb7882b8d660de2
Author: Chen, Yan <yan.chen@intel.com>
Date:   Fri Mar 27 05:19:00 2020 +0000

update keystone and openstacklib puppet for Train
    
    puppet-keystone and puppet-openstacklib need to be updated
    because of the Train upgrade, to avoid ansible failure. The puppet
    packages are not fully upgraded because the new versions request
    an upgrade for Puppet 5.
    
    keystone: 0007-update-for-openstackclient-Train-upgrade
     - Remove deprecated role list options --project and --user. Use role
       assignment list options --project and --user instead.
     - Ported from puppet-keystone v15.4.0.
    
    openstacklib: 0002-update-for-openstackclient-Train
     - Add endpoint parameter for Puppet::Provider::Openstack::Credentials,
       ported from puppet-openstacklib v15.4.0.
    
    Ref:
    https://docs.openstack.org/releasenotes/python-openstackclient/train.html
    https://docs.openstack.org/releasenotes/puppet-keystone/train.html
    https://docs.openstack.org/releasenotes/puppet-openstacklib/train.html
    
    Tests have been done:
    1. Deploy StarlingX with simplex/duplex/multi-node with or without
       dedicated storage nodes.
    2. Apply latest openstack application based on the above deployments.
    3. Add node with BMC.
    4. Openstack client tests:
       Create flavor, image, volume, network, subnet and instances.
       Instance Operations:
          Pause/Unpause; Suspend/Resume; Stop/Start;
          Reboot (soft); Reboot (hard)
    
    Story: 2007502
    Task: 39266
    
    Depends-on: https://review.opendev.org/#/c/716818
    Change-Id: I21c0fa2aaa41bae6d0d309763c84afb9e2e5ded9
    Signed-off-by: Chen, Yan <yan.chen@intel.com>

commit 645464fd8ec4590041d334bb30a7b0a3fed876b6
Author: Robert Church <robert.church@windriver.com>
Date:   Tue Apr 14 23:56:06 2020 -0400

Update kubernetes spec to the min golang version for v1.18
    
    Per https://github.com/kubernetes/kubernetes/commit/e3ff39f update the
    build spec to require a minimal version of golang.
    
    Change-Id: Ie4e3de94d0ecee05499d8eb06d3652165cdd6d25
    Story: 2006999
    Task: 39474
    Signed-off-by: Robert Church <robert.church@windriver.com>

commit e7bbd7e7b1d0dbf0fdfe97ca986197f3857e3b0d
Author: Dan Voiculeasa <dan.voiculeasa@windriver.com>
Date:   Fri Apr 10 17:02:39 2020 +0300

Change ceph manager port
    
    Free port 5001 to be used by keystone.
    
    Story: 2007347
    Task: 39392
    
    Change-Id: Id789591bf22931494e970aaf3b12e9e5cbe223fa
    Signed-off-by: Dan Voiculeasa <dan.voiculeasa@windriver.com>

commit 23a2ba0cb6d76189063d152f8d96f8487c0724e6
Author: Robert Church <robert.church@windriver.com>
Date:   Mon Mar 23 20:56:32 2020 -0400

Upversion kubernetes to v1.18.1
    
    Upgrade to kubernetes v1.18.1 and include a temporary patch for the
    current StarlngX behavior related to hugepages.
    
    Based on the current StarlingX configuration, container hugepages are
    mounted with the following option that already contains an 'i' as a
    suffix: pagesize=1Gi.
    
    This temporary patch updates the logic associated with
    https://github.com/kubernetes/kubernetes/commit/03ecc20 to avoid
    appending an additional 'i' at the end of the size string. This extra
    'i' is not handled by ParseQuantity() and results is a pod stuck
    Terminating as the mount is not removed from the container.
    
    The new multiple hugepage feature will be enabled an evaluated with the
    intent of upstreaming this (or a comparable fix) OR adjusting StarlingX
    hugepage behavior to align with the expected upstream behavior and
    dropping this patch.
    
    In addition:
    - Update kubelet-cgroup-setup.sh, as now pids and hugetlb both appear to
      get auto-deleted on reboot so make sure these are recreated.
    - Update spec to remove hyperkube dependencies as each component is now
      built independently and needs to be install individually.
    
    Change-Id: I34263fa33c61c7a5bce1002a4f5edf5b850aa189
    Story: 2006999
    Task: 37770
    Depends-On: https://review.opendev.org/#/c/718370/
    Depends-On: https://review.opendev.org/#/c/718566/
    Signed-off-by: Robert Church <robert.church@windriver.com>

commit 5ac3a294a1be243c4fcb8eac35536bfd9b46829a
Author: Robert Church <robert.church@windriver.com>
Date:   Fri Apr 3 17:03:57 2020 -0400

Upversion containerd components to align with k8s v1.18.0
    
    To align with k8s v1.18.0. This moves containerd to v1.3.3, runc to
    1.0.0-rc10, and crictl to v1.18.0.
    
    Change-Id: I2e5afb63c494a87e29c8f981189ce019225feaf9
    Story: 2006999
    Task: 39340
    Depends-On: https://review.opendev.org/#/c/718370/
    Signed-off-by: Robert Church <robert.church@windriver.com>

commit bceb6c148cb5771c5de3d87cade866c5ce34c71a
Author: Davlet Panech <davlet.panech@windriver.com>
Date:   Tue Apr 7 11:20:16 2020 -0400

Subdirectory kernel relocated to new repo starlingx/kernel
    
    * Moved subdirectories from kernel/ into a new repo
    * Removed references to kernel from this repo's file lists
    
    Change-Id: I386418f51169dd9b8c977bae328060077ac44b93
    Depends on: I4b171accd8b489c92f6d2c69cb7aa5c63e75f336
    Signed-off-by: Davlet Panech <davlet.panech@windriver.com>

commit 5694c7221890e67bc1c2706bbaf08aef4c2d9745
Author: Mingyuan Qi <mingyuan.qi@intel.com>
Date:   Fri Apr 10 05:29:19 2020 +0000

Fix QAT plugin image pull failed
    
    Fix several image pull failure issue caused by a containerd chmod
    issue resolve by upstream commit e2269f2.
    
    Original commit message:
    
    handleLChmod() does not properly check that files behind the
    handlinks exist before calling os.Chmod(). We've seen base images
    where this results in "no such file or directory" error from
    os.Chmod() when unpacking the image.
    
    To keep the existing logic but fix the problem, this commit simply
    skips IsNotExist error.
    
    Closes-bug: 1869236
    
    Change-Id: I2e77adbf89ad5505f2d7127a3f06ccfb805c0f24
    Signed-off-by: Mingyuan Qi <mingyuan.qi@intel.com>

tags:

added: in-f-centos8

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.