VIM: patch orchestration should patch controller hosts first in AIO-DX plus worker configs

[Bart Wensley]

Brief Description
-----------------
The VIM's patch orchestration was designed to patch controller hosts before worker hosts. However, when the AIO-DX plus worker hosts configuration was allowed, the VIM was not updated, so patch orchestration does not patch the AIO-DX controller hosts before the worker hosts.

Severity
--------
Minor: There is no functional impact if worker hosts are patched before the controller hosts.

Steps to Reproduce
------------------
Install an AIO-DX plus worker configuration.
Use patch orchestration to apply a patch.

Expected Behavior
------------------
The AIO-DX hosts should be patched first.

Actual Behavior
----------------
Some (or all) of the worker hosts may be patched before the AIO-DX hosts.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-DX plus worker hosts

Branch/Pull Time/Commit
-----------------------
This is a day one issue (since stx.1.0).

Last Pass
---------
Never

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Developer Testing

Workaround
----------
None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/726905

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - day 1 issue, but would be nice to fix for the upcoming release.
Review is already in progress

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726905
Committed: https://git.openstack.org/cgit/starlingx/nfv/commit/?id=7540e7905b92a3d62ff5b72b8bfec6dd8c3c4201
Submitter: Zuul
Branch: master

commit 7540e7905b92a3d62ff5b72b8bfec6dd8c3c4201
Author: Bart Wensley <email address hidden>
Date: Mon May 11 12:00:41 2020 -0500

    VIM: patch AIO-DX hosts before worker hosts

    The VIM's patch orchestration was designed to patch controller
    hosts before worker hosts. However, when the AIO-DX plus worker
    hosts configuration was allowed, the VIM was not updated, so
    patch orchestration does not patch the AIO-DX controller hosts
    before the worker hosts.

    This change ensures AIO-DX hosts are patched before worker hosts.

    Change-Id: I15acd44348c6065741bcf3cbe5c183e6aafb463d
    Closes-Bug: 1878052
    Signed-off-by: Bart Wensley <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729823

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/729823
Committed: https://git.openstack.org/cgit/starlingx/nfv/commit/?id=f4b59c4f5320f4e99ee5b987ef589a6380c931e0
Submitter: Zuul
Branch: f/centos8

commit 615340ce6230b4f1831298f68241e27a939bf151
Author: Eric MacDonald <email address hidden>
Date: Wed Apr 22 07:59:27 2020 -0400

    Add orchestrated fw update support to vim

    This update adds firmware update orchestration support to
    the VIM for host device fpga images as described in the
    'N3000 FPGA device image update orchestration' feature
    specification. See https://review.opendev.org/#/c/713302/

    The firmware update orchestration strategy added to the VIM
    is modeled after the VIM's existing patch orchestration
    and includes strategy create/apply/show/abort/delete.

    The strategy can be managed through the existing sw-manager
    tool via the VIM's REST API.

    Only unlocked hosts with the worker function are included
    in the strategy.

    The strategy includes a stage for each host or group of hosts
    with ordered step sequences of firmware update followed by a
    lock and unlock of each updated host.

    Change-Id: I4eea7ca3f00782d27cdbb5d5615c6a255ac6966e
    Story: 2006740
    Task: 39145
    Signed-off-by: Eric MacDonald <email address hidden>

commit 7540e7905b92a3d62ff5b72b8bfec6dd8c3c4201
Author: Bart Wensley <email address hidden>
Date: Mon May 11 12:00:41 2020 -0500

    VIM: patch AIO-DX hosts before worker hosts

    The VIM's patch orchestration was designed to patch controller
    hosts before worker hosts. However, when the AIO-DX plus worker
    hosts configuration was allowed, the VIM was not updated, so
    patch orchestration does not patch the AIO-DX controller hosts
    before the worker hosts.

    This change ensures AIO-DX hosts are patched before worker hosts.

    Change-Id: I15acd44348c6065741bcf3cbe5c183e6aafb463d
    Closes-Bug: 1878052
    Signed-off-by: Bart Wensley <email address hidden>

commit f1413b76821a9856814e23e341c8d59bd98257f7
Author: Sharath Kumar K <email address hidden>
Date: Wed Apr 8 09:09:44 2020 +0200

    De-branding in starlingx/nfv: Titanium Cloud -> StarlingX

    1. Rename Titanium Cloud to StarlingX for .service file

    Test:
    After the de-brand change, bootimage.iso has been built in the flock layer
    and installed on the dev machine to validate the changes.

    Please note, doing de-brand changes in batches, this is batch7 changes.

    Story: 2006387
    Task: 39241

    Change-Id: I9aa2f33fd531ab7bfb7d42b31fd09066c03aa6ed
    Signed-off-by: Sharath Kumar K <email address hidden>