Fix potential infinit loop in build-iso

Bug #1877483 reported by Scott Little
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Scott Little

Bug Description

Brief Description
-----------------

build-iso sometimes fails, reporting an infinite loop during
dependency resolution.

Severity
--------
Major

Steps to Reproduce
------------------
build-iso

Expected Behavior
------------------
iso is produced

Actual Behavior
----------------
build-iso fails, reporting an infinite loop during
dependency resolution.

Reproducibility
---------------
rare, but can be reproduced within the workspace where it has just occurred.
Perhaps the order of files coming out of a 'find' or similar command?

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master, May 7, 2020

Last Pass
---------
May 6, 2020

Timestamp/Logs
--------------
18:43:37 Warning: Infinite loop detected in dependency resolution. See /localdisk/loadbuild/slittle1/WRCP_DEV/export/deps.txt for details -- exiting
18:43:37 These RPMS had problems (likely version conflicts)
18:43:37 installing package acpid-2.0.19-9.el7.x86_64 needs 48MB on the / filesystem
18:43:37 installing package attr-2.4.46-13.el7.x86_64 needs 274MB on the / filesystem
...
18:43:37 installing package xml-common-0.6.3-39.el7.noarch needs 274MB on the / filesystem
18:43:37 installing package zip-3.0-11.el7.x86_64 needs 274MB on the / filesystem
18:43:37 Could not install dependencies

Test Activity
-------------
Build

 Workaround
 ----------
N/A

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (master)

Reviewed: https://review.opendev.org/726260
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=eb971b6f7c8321064b3ca334e21f0609ffb70efe
Submitter: Zuul
Branch: master

commit eb971b6f7c8321064b3ca334e21f0609ffb70efe
Author: Scott Little <email address hidden>
Date: Thu May 7 19:12:03 2020 -0400

    Fix potential infinite loop in build-iso

    Function generate_dep_list is creating a DEPLISTFILE
    with a lot of unwanted 'installing package xxx' messages
    when it should only contain a list of unresolved
    dependencies.

    On the next iteration we waste a lot of time trying to install
    nonexistant packages 'installing' and 'packages', and re-installing
    packages we already have.

    Instead of converging on an empty DEPLISTFILE, we converge
    on a DEPLISTFILE that just reiterates the same list of
    'installing package' if we are lucky, which we usually are,
    but not always.

    Closes-Bug: 1877483
    Change-Id: I971725558eb628c6d6b5d0b42d0bcab6b46e722b
    Signed-off-by: Scott Little <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
assignee: nobody → Scott Little (slittle1)
importance: Undecided → High
tags: added: stx.build
Changed in starlingx:
importance: High → Medium
tags: added: stx.4.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to root (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729808

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (f/centos8)
Download full text (13.0 KiB)

Reviewed: https://review.opendev.org/729808
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=c2319db9d2a109936ba5ff366edac6f59b64ff6e
Submitter: Zuul
Branch: f/centos8

commit 89543b25b4f2733968e4a17fbc6e791f4eaa25cd
Author: Don Penney <email address hidden>
Date: Wed May 13 13:00:36 2020 -0400

    Add subdir PKG_GITREVCOUNT support

    This update introduces the PKG_GITREVCOUNT variable for package-based
    auto-versioning. Similar to GITREVCOUNT, PKG_GITREVCOUNT will
    calculate the number of commits in the corresponding package's
    directory. This allows each package within a git repo to be
    independently auto-versioned.

    Use of the PKG_BASE_SRCREV variable is optional. If it is not defined,
    the PKG_GITREVCOUNT will count all commits in the package directory.
    If it is defined, it will count a range of commits, with
    PKG_BASE_SRCREV as the starting point.

    To use this, include the following in the package's build_srpm.data
    file:
    TIS_PATCH_VER=PKG_GITREVCOUNT

    This can also be combined with GITREVCOUNT, if a package has local
    files in addition to an external repo to be factored in. This would
    add the count from PKG_GITREVCOUNT to GITREVCOUNT in calculating the
    TIS_PATCH_VER value:
    TIS_PATCH_VER=GITREVCOUNT+PKG_GITREVCOUNT

    Change-Id: Iab3a8c8a212d292f26d5418a881de69566758134
    Story: 2006166
    Task: 39765
    Signed-off-by: Don Penney <email address hidden>

commit 3dcebf7b592d1c43a1f30ba7897e57f8fcade1ec
Author: Steven Webster <email address hidden>
Date: Tue May 19 09:19:18 2020 -0400

    Uprev the SR-IOV device plugin to the latest version

    This is intended primarily to pick up support for SR-IOV
    accelerators.

    Testing has been performed as follows:

    System Types:
        AIO-SX, Standard
    Cluster network types:
        IPv4, IPv6
    NIC types:
        82599ES 10-Gigabit [10fb],
        MT27710 Family [ConnectX-4 Lx] [1015],
        X710 for 10GbE [1572]
    IPAM types:
        host-local,
        calico,
        dhcp,
        static
    Connectivity between pods:
        DPDK,
        netdevice

    Change-Id: Id0d5fcbfbf93ab581a07f26e375bcc2feee6bf69
    Story: 2006740
    Task: 39614
    Signed-off-by: Steven Webster <email address hidden>

commit a0e51f0cab911891376d4002a71b6161ce5edc44
Author: Dongqi Chen <email address hidden>
Date: Wed May 13 17:00:12 2020 +0800

    Remove tpm from update-pxe-network-installer script

    Now use the kernel built-in tpmdd instead of tpmdd
    out-of-tree, so the rpm package is no longer provided.

    Change-Id: I0f322c81d1a9aa20b2ad43a8f5b7b17abfd5782a
    Story: 2007308
    Task: 39756
    Depends-On: https://review.opendev.org/#/c/726999/
    Signed-off-by: Dongqi Chen <email address hidden>

commit 89d38925cade03e5d724b0c7bf8ecf78dab2b830
Author: Dongqi Chen <email address hidden>
Date: Mon May 11 09:37:28 2020 +0800

    [kernel-rt 4.18] Fix build-pkgs --rt --edit kernel error

    Extract commands from spec
    VERSION = 4.18.0
    ./generate_all_configs.sh kernel-rt

    When executing the script ‘./gene...

tags: added: in-f-centos8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.