stx-oidc-client liveness probe failing

[Bart Wensley]

Brief Description
-----------------
The stx-oidc-client pod liveness probe is failing repeatedly:
  Warning ProbeWarning 4m51s (x7466 over 20h) kubelet, controller-0 Liveness probe warning: <a href="https://[2620:10a:a001:a103::1181]:30556/dex/auth?client_id=stx-oidc-client-app&amp;redirect_uri=https%3A%2F%2F%5B2620%3A10a%3Aa001%3Aa103%3A%3A1181%5D%3A30555%2Fcallback&amp;response_type=code&amp;scope=openid+profile+email+groups+offline_access&amp;state=I+wish+to+wash+my+irish+wristwatch">See Other</a>.

It seems to pass often enough to keep the kubelet happy but these failures should not be happening (about 6 times per minute in the example above).

Severity
--------
Minor: this doesn't seem to break anything (yet).

Steps to Reproduce
------------------
Install a system and then install the oidc-auth-apps application.

Expected Behavior
------------------
The liveness probe should not be failing.

Actual Behavior
----------------
The liveness probe is failing.

Reproducibility
---------------
Reproducible - seen on more than one system.

System Configuration
--------------------
Seen in AIO-SX system - expect it is happening everywhere.

Branch/Pull Time/Commit
-----------------------
Load built "2020-04-30 20:02:11"

Last Pass
---------
Not sure. May have always been this way.

Timestamp/Logs
--------------
See above

Test Activity
-------------
Developer Testing

Workaround
----------
None

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - these errors are not expected and should be investigated

[Ghada Khalil (gkhalil)]

Confirmed with Teresa that this has no functional impact. Re-gating to stx.5.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/739032

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739032
Committed: https://git.openstack.org/cgit/starlingx/oidc-auth-armada-app/commit/?id=957fc7c2092c7574a0a931012a0ec1cf5bb66429
Submitter: Zuul
Branch: master

commit 957fc7c2092c7574a0a931012a0ec1cf5bb66429
Author: Teresa Ho <email address hidden>
Date: Tue Jun 30 09:32:39 2020 -0400

    Fix liveness probe in oidc client

    The liveness probe was not setup correctly causing probe warnings.
    This update added the handling for the readiness and liveness probes.
    The probe parameters are also setup to be configurable in the helm
    charts.

    Partial-bug: 1877172

    Change-Id: Ibe2d760897e761d361c3d4fe8c1ce41b33609d54
    Signed-off-by: Teresa Ho <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/750680

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/750690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/750690
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=dbb2a0c34fd66019caa484ee5264468d1c981637
Submitter: Zuul
Branch: master

commit dbb2a0c34fd66019caa484ee5264468d1c981637
Author: Teresa Ho <email address hidden>
Date: Wed Sep 9 11:39:24 2020 -0400

    Update tag for stx-oidc-client to stx.5.0-v1.0.3

    Closes-Bug: 1877172

    Change-Id: Ic6aa7317ac9a18e19dcaab1572359d1060a532ce
    Signed-off-by: Teresa Ho <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/750680
Committed: https://git.openstack.org/cgit/starlingx/oidc-auth-armada-app/commit/?id=f086d9b643b07e1c8e34b85719b35125deb78235
Submitter: Zuul
Branch: master

commit f086d9b643b07e1c8e34b85719b35125deb78235
Author: Teresa Ho <email address hidden>
Date: Wed Sep 9 09:09:56 2020 -0400

    Update image tag for stx-oidc-client

    Change image tag from stx.4.0-v1.0.2 to stx.5.0-v1.0.3

    Closes-Bug: 1877172

    Change-Id: I2fa962e29ec505259c9082679e941cb349a8f8d1
    Signed-off-by: Teresa Ho <email address hidden>