kernel repo not completely segregated from integ

Bug #1877160 reported by Jim Somerville
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Jim Somerville

Bug Description

Brief Description
-----------------
The userspace build parts of the mellanox driver code were left back in the integ repo.

Severity
--------
Minor. Software architecture is compromised with a negative effect on layering, it is not a runtime issue.

Steps to Reproduce
------------------
N/A

Expected Behavior
------------------
Mellanox components including rdma-core and libibverbs are all built within the kernel repo.

Actual Behavior
----------------
rdma-core and libibverbs (userspace components) are built within integ

Reproducibility
---------------
100%. Build architecture issue.

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
N/A

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
N/A

Workaround
----------
N/A

Changed in starlingx:
assignee: nobody → Jim Somerville (jsomervi)
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
status: New → Triaged
tags: added: stx.buil2
tags: added: stx.4.0 stx.build
removed: stx.buil2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to integ (master)

Fix proposed to branch: master
Review: https://review.opendev.org/725945

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kernel (master)

Fix proposed to branch: master
Review: https://review.opendev.org/725946

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kernel (master)

Change abandoned by Jim Somerville (<email address hidden>) on branch: master
Review: https://review.opendev.org/725946
Reason: Replaced by Scott's containing history

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to integ (master)

Reviewed: https://review.opendev.org/725945
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=02dd02d591e4139cf1d3d9e237f55952cf9805a4
Submitter: Zuul
Branch: master

commit 02dd02d591e4139cf1d3d9e237f55952cf9805a4
Author: Jim Somerville <email address hidden>
Date: Tue May 5 14:21:51 2020 -0400

    Move mellanox userspace from integ repo

    libibverbs and rdma-core are part of the mellanox driver
    software package and to facilitate layering, shouldn't
    be split across different repos.

    Move them from the integ repo to the kernel repo so they
    can co-reside with the kernel module portion.

    Change-Id: I4c8582dadbae52b342d7178313d8b62beeb61148
    Closes-Bug: 1877160
    Depends-On: I41153feceef4eb26a41ff634c60dc3adaaf238b1
    Signed-off-by: Jim Somerville <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to integ (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729834

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to integ (f/centos8)
Download full text (15.2 KiB)

Reviewed: https://review.opendev.org/729834
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=e4d12decc4c702e1e908d2430c7b4bc524c31c07
Submitter: Zuul
Branch: f/centos8

commit 5bb777d3725a48bc18431daedb6fd67198cd053a
Author: SidneyAn <email address hidden>
Date: Wed May 20 23:22:06 2020 +0800

    Add python-daemon to srpm list

    add python-daemon-2.2.3-7.el8.src.rpm to srpm list
    for pkg python3-daemon building.

    Change-Id: I0ad60d1083222130e72f935e08f97a8608b75880
    Story: 2007106
    Task: 39291
    Signed-off-by: SidneyAn <email address hidden>

commit fc125a7a24c00850aafd4a791a63e8e627b5ee1e
Author: Ran An <email address hidden>
Date: Thu May 14 11:41:50 2020 +0000

    Revert "Add python3-daemon required by logmgmt"

    This reverts commit 97cd7ea5c1037dd22488793ea9271462fedc4c7a.

    Change-Id: I3f09054c1546252493f8eb29dc70806829324a52

commit 97cd7ea5c1037dd22488793ea9271462fedc4c7a
Author: SidneyAn <email address hidden>
Date: Fri Apr 3 15:48:09 2020 +0800

    Add python3-daemon required by logmgmt

    pkg logmgmt upgraded to python3 requires python3 model "daemon",
    and no pkgs in Centos7 offical repo provide it.

    this patch refer to the python3-daemon pkg build by rdo
    for CentOS 8: python-daemon-2.2.3-7.el8.src.rpm

    disable the rpm check part which is not required in stx to
    reduce python3 dependencies that not supported by CentOS 7

    Depends-on: https://review.opendev.org/#/c/727657/
    Depends-on: https://review.opendev.org/#/c/727662/
    Change-Id: Ie08ea9c7adf830ad4e8e924fa69352fb2a923a6f
    Story: 2007106
    Task: 39291
    Signed-off-by: SidneyAn <email address hidden>

commit e2dc5c2dd0042788697ade268ac5c24fe9dc2f8c
Author: Steven Webster <email address hidden>
Date: Tue May 12 10:32:21 2020 -0400

    Fix sriov device plugin image build

    Previous commit d204f10ab5 introduced a build script to assist
    in building the SR-IOV device plugin.

    The script utilizes a Makefile to do build the plugin binary,
    then the image.

    Building the binary depends on go being present on the host. If it
    is not, the build will fail.

    Building the binary is actually not required, as it will be also
    done in a container as part of the 'make image', rather than copying
    the binary from the host.

    Closes-Bug: #1878224
    Change-Id: I4499ea2bbef4b3da8a154c69a07b415574517500
    Signed-off-by: Steven Webster <email address hidden>

commit d204f10ab53414dd46d5eb51fd99950d3ab70fa8
Author: Steven Webster <email address hidden>
Date: Fri Apr 24 10:59:59 2020 -0400

    Uprev the SR-IOV device plugin to the latest version

    This is intended primarily to pick up support for SR-IOV
    accelerators.

    The builder has been changed to a script model, as the
    device plugin's Dockerfile has been moved to a separate
    directory. The build-stx-images script does find this file,
    but the docker build will fail as the device plugin's
    source directory is no longer where the builder expects
    it to be. Instead, use the existing Makefile to assist
    in building the bi...

tags: added: in-f-centos8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.