Failed distro build, python-django-horizon unpackaged files

[Scott Little]

Brief Description
-----------------
Distro Layer failes to build

Severity
--------
Critical

Steps to Reproduce
------------------
build-pkgs from within distro layer

Expected Behavior
------------------
build is successful

Actual Behavior
----------------
build failes

Reproducibility
---------------
100%

System Configuration
--------------------
NA

Branch/Pull Time/Commit
-----------------------
Apr 29, 2020

Last Pass
---------
Apr 24, 2020

Timestamp/Logs
--------------
Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/python-django-horizon-15.1.0-1.tis.2.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/share/openstack-dashboard/openstack_dashboard/conf/cinder_policy.d/consistencygroup.yaml
RPM build errors:
    Macro expanded in comment on line 511: %{_datadir}/openstack-dashboard/openstack_dashboard/dashboards/theme
    Macro expanded in comment on line 512: %{_datadir}/openstack-dashboard/openstack_dashboard/enabled/_99_customization.*
    Installed (but unpackaged) file(s) found:
   /usr/share/openstack-dashboard/openstack_dashboard/conf/cinder_policy.d/consistencygroup.yaml
Child return code was: 1

Test Activity
-------------
Build

Workaround
----------
NA

[Scott Little (slittle1)]

Issue was tracked down to a failure to update the distro manifest. Horizon was still pulling stein, rather than train.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/724739

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/724739
Committed: https://git.openstack.org/cgit/starlingx/manifest/commit/?id=a24beb13da5222558124794d6675fd1f94686e34
Submitter: Zuul
Branch: master

commit a24beb13da5222558124794d6675fd1f94686e34
Author: Scott Little <email address hidden>
Date: Thu Apr 30 15:19:58 2020 -0400

    horizon in distro layer was not updated to train

    Monolith build passes while layered build failed on
    package python-django-horizon.

    Root cause was a failure to update horizon in the
    distro layer from stein to train.

    Closes-Bug: 1875976
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: Ib532ba9944674a3631be8a886eab9eabe2c1f399

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729842

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/729842
Committed: https://git.openstack.org/cgit/starlingx/manifest/commit/?id=39e2c3f2d7868aeed4c25ec583082bd1b3b3c04f
Submitter: Zuul
Branch: f/centos8

commit a24beb13da5222558124794d6675fd1f94686e34
Author: Scott Little <email address hidden>
Date: Thu Apr 30 15:19:58 2020 -0400

    horizon in distro layer was not updated to train

    Monolith build passes while layered build failed on
    package python-django-horizon.

    Root cause was a failure to update horizon in the
    distro layer from stein to train.

    Closes-Bug: 1875976
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: Ib532ba9944674a3631be8a886eab9eabe2c1f399

commit 48e2527f494e0eca564b078b1b652a5a631b0de5
Author: Joseph Richard <email address hidden>
Date: Mon Apr 27 13:43:41 2020 -0400

    Add new repo starlingx/portieris-armada-app

    Depends-On: https://review.opendev.org/#/c/723897/
    Story: 2007348
    Task: 39569
    Signed-off-by: Joseph Richard <email address hidden>
    Change-Id: I119baa63fc209688e1e447161115f32facce89d8

commit d29f5fbb4b0737abfcaf7b0f20a89118a3da4259
Author: chenyan <email address hidden>
Date: Fri Mar 27 11:18:15 2020 +0800

    manifest upgrade to Train

    Train upgrade for host side keystone, barbican, and openstack clients.

    Story: 2007502
    Task: 39247

    Change-Id: Icb62ee11f6fb12f6bdc8b318b5c0aab799109d64
    Signed-off-by: chenyan <email address hidden>

commit 173fccbdb690a21beaf88bc1f92afa8af990d3cd
Author: chron.xie <email address hidden>
Date: Thu Apr 2 19:23:44 2020 +0800

    upgrade starlingx dashboard with stable/train.

    Update manifest for horizon based dashboard

    Story: 2007502
    Task: 39267

    Change-Id: I25fa76d4d870c21fe7617c5093bf18ac9639d221
    Signed-off-by: Xie Quqiang <email address hidden>