Pylint 2.5.0 breaks zuul for most STX repos

Bug #1875705 reported by Al Bailey on 2020-04-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Critical
Al Bailey

Bug Description

Brief Description
-----------------
On April 25 a new version of pylint was released, which is causing all zuul jobs with pylint enabled to fail due to errors like this

(example from stx-puppet)

puppet-manifests/__init__.py:1:0: F0010: error while code parsing: Unable to load file puppet-manifests/__init__.py:
[Errno 2] No such file or directory: 'puppet-manifests/__init__.py' (parse-error)

The fix will be to clamp the upper version of pylint.

Severity
--------
Critical (blocks submissions)

Steps to Reproduce
------------------
Run pylint in a clean env for a repo that is failing (like stx-puppet)

Expected Behavior
------------------
Should pass

Actual Behavior
----------------
Fails due to F0010 parsing error

Reproducibility
---------------
100% between April 25 and April 28 (I have no idea if pylint will issue a newer version that changes this)

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
April 28

Last Pass
---------
April 24

Timestamp/Logs
--------------

************* Module puppet-manifests
puppet-manifests/__init__.py:1:0: F0010: error while code parsing: Unable to load file puppet-manifests/__init__.py:
[Errno 2] No such file or directory: 'puppet-manifests/__init__.py' (parse-error)

Test Activity
-------------
Zuul

 Workaround
 ----------
 None

Al Bailey (albailey1974) on 2020-04-28
Changed in starlingx:
assignee: nobody → Al Bailey (albailey1974)

Fix proposed to branch: master
Review: https://review.opendev.org/724104

Changed in starlingx:
status: New → In Progress
Al Bailey (albailey1974) wrote :

Note: 2.5.0 was released April 27, not April 25 as previously reported.

Ghada Khalil (gkhalil) wrote :

stx.4.0 / critical - blocks submissions to various repos

tags: added: stx.4.0 stx.zuul
Changed in starlingx:
importance: Undecided → Critical

Reviewed: https://review.opendev.org/724104
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=db97027fb7b8cf8484f6ddc9ee4906ca091107ec
Submitter: Zuul
Branch: master

commit db97027fb7b8cf8484f6ddc9ee4906ca091107ec
Author: albailey <email address hidden>
Date: Tue Apr 28 12:39:05 2020 -0500

    Clamp pylint to be less than 2.5.0

    A new version of pylint was released on April 25
    and it is breaking zuul jobs so submissions cannot merge.
    Clamping pylint to be less than 2.5.0 for now.

    Change-Id: Ibd62a5d67bf8f37119b612a274c2d472a3474859
    Partial-Bug: 1875705
    Signed-off-by: albailey <email address hidden>

Reviewed: https://review.opendev.org/724108
Committed: https://git.openstack.org/cgit/starlingx/utilities/commit/?id=785ab826e24f5adeef40f2aff8d764a0e7f9e850
Submitter: Zuul
Branch: master

commit 785ab826e24f5adeef40f2aff8d764a0e7f9e850
Author: albailey <email address hidden>
Date: Tue Apr 28 12:52:39 2020 -0500

    Clamp pylint to be less than 2.5.0

    A new version of pylint was released on April 27 and it is
    breaking zuul jobs so submissions cannot merge.

    Clamping pylint to be less than 2.5.0 for now.

    Change-Id: I77464800aa4ec5b94e10a5e9fbaeb0ddbd2e7845
    Partial-Bug: 1875705
    Signed-off-by: albailey <email address hidden>

Al Bailey (albailey1974) wrote :

Not all repos will break when running this version of pylint.

stx-puppet complains about the missing __init__.py
utilities complains about ceph-manager/ceph.py

However, stx/upgrade works fine with 2.5.0

A future task may be verify any code that needs to be changed for the latest version of pylint.

Al Bailey (albailey1974) wrote :

This bug can be closed.
Auditing the remaining tox.ini files in STX all the remaining use an older version of pylint, or are not impacted by the new checks that the newer version provides.

Changed in starlingx:
status: In Progress → Fix Committed
Al Bailey (albailey1974) wrote :

Apparently stx/test is also affected. I will submit a fix there as well.

Change abandoned by Al Bailey (<email address hidden>) on branch: master
Review: https://review.opendev.org/724326
Reason: My review is no longer required for tox to pass, with this review being merged https://review.opendev.org/#/c/725208/

Ghada Khalil (gkhalil) wrote :

Marking as "Fix Released". Based on comments above, this has been addressed in stx master.

Changed in starlingx:
status: Fix Committed → Fix Released
Download full text (16.7 KiB)

Reviewed: https://review.opendev.org/729825
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=d4617fbad74a05f2af81ee85a47565083991e6f8
Submitter: Zuul
Branch: f/centos8

commit 4134023ab84d8a635b118d5e3ff26ade3bbe535b
Author: Sharath Kumar K <email address hidden>
Date: Thu May 7 10:08:11 2020 +0200

    Tox and Zuul job for the bandit code scan in stx/stx-puppet

    Setting up the bandit tool for the scanning of HIGH severity issues
    in the python codes under Starlingx/stx-puppet folder.
    Expecting this merge will enable zuul job for CI/CD of bandit scan.

    Configuration files:
    1. tox.ini for adding bandit environment and command.
    2. test-requirements.txt for adding bandit version.
    3. .zuul.yaml file for adding bandit job and configuring under
       check job to run code scan every time before code commit.

    Test:
    Run tox -e bandit command inside the fault folder to validate the
    bandit scan and result.

    Story: 2007541
    Task: 39687
    Depends-On: https://review.opendev.org/#/c/721294/

    Change-Id: I2982268db2b5e75feeb287bc95420fedc9b0d816
    Signed-off-by: Sharath Kumar K <email address hidden>

commit 65daac29e4635f32a57e80cd18f96fd59dc8ebe0
Author: Bin Qian <email address hidden>
Date: Tue May 12 22:39:21 2020 -0400

    DC cert manifest should only apply to controller nodes

    DC cert manifest should only apply to controller nodes on system
    controller.
    This fix is for DC with worker nodes in central cloud.

    Change-Id: I4233509a6f0afb3013c01e81dea6f655d9e15371
    Closes-Bug: 1878260
    Signed-off-by: Bin Qian <email address hidden>

commit 04a3cb8cbad9b1700286c5de67aa5d974cf54400
Author: Elena Taivan <email address hidden>
Date: Wed Apr 29 08:44:13 2020 +0000

    Changing permissions for conversion folder

    Adding writing permissions to '/opt/conversion' mountpoint
    so openstack image conversion can happen there.

    Change-Id: Id1a91db6570dcbed3b8068e79e72f5bb800f24ad
    Partial-bug: 1819688
    Signed-off-by: Elena Taivan <email address hidden>

commit 4e9153cf234e714e4bbc9a9eb3d9b55b2828145a
Author: Tao Liu <email address hidden>
Date: Mon May 4 14:30:30 2020 -0500

    Move subcloud audit to separate process

    Subcloud audit is being removed from the dcmanager-manager
    process and it is running in dcmanager-audit process.

    This update adds associated puppet config.

    Story: 2007267
    Task: 39640
    Depends-On: https://review.opendev.org/#/c/725627/

    Change-Id: Idd2e675126a01d6113597646ddd9eb4a0bc5be44
    Signed-off-by: Tao Liu <email address hidden>

commit b793518f65ae932f3974ff85b797f505b5ef1c2a
Author: Robert Church <email address hidden>
Date: Wed Apr 29 12:49:04 2020 -0400

    Ensure containerd binds to the loopback interface

    Set the stream_server_address to bind to the loopback interface with a
    value of "127.0.0.1" for IPv4 and "::1" for IPv6.

    Without setting the stream_server_address in config.toml, containerd was
    binding to the OAM interface. Under most situations this resulted in
    containe...

tags: added: in-f-centos8
Download full text (8.8 KiB)

Reviewed: https://review.opendev.org/729829
Committed: https://git.openstack.org/cgit/starlingx/utilities/commit/?id=8b997e7817ae0a4a1886a0aac803b9d38c3e80eb
Submitter: Zuul
Branch: f/centos8

commit 115332ef6b0016393e6af9a65eadc1911be2be33
Author: Ran An <email address hidden>
Date: Thu May 14 11:41:43 2020 +0000

    Revert "Update logmgmt to use python3"

    This reverts commit dfbf7166b3a7317ed426023b1667553bfa9ad86c.

    Change-Id: I28c1b30edc4c97cda77724fdc20775f8b6b8faea

commit e84e6637d0ba2aea93d16f4ec82678fcf927de19
Author: Sharath Kumar K <email address hidden>
Date: Tue May 5 08:59:55 2020 +0200

    De-branding in starlingx/utilities: CGCS,TIS -> StarlingX

    1. Rename CGCS,TIS to StarlingX for .spec file

    Test:
    After the de-brand change, bootimage.iso has been built in the flock
    Layer and installed on the dev machine to validate the changes.

    Please note, doing de-brand changes in batches, this is batch13 changes.

    Story: 2006387
    Task: 39270

    Change-Id: Iee7156e3d4e2f326c70518abb444d0154b2d2648
    Signed-off-by: Sharath Kumar K <email address hidden>

commit dfbf7166b3a7317ed426023b1667553bfa9ad86c
Author: Long Li <email address hidden>
Date: Tue Apr 7 18:16:17 2020 +0800

    Update logmgmt to use python3

    Change python to python3 about script and spec
    fix log runtime errors in python3 env

    Change-Id: Ia7e00a4f5b8b4dc617cb17ab8b7dc37576e809b5
    Story: 2007106
    Task: 39288
    Depends-on: https://review.opendev.org/#/c/717211/
    Signed-off-by: Long Li <email address hidden>
    Signed-off-by: SidneyAn <email address hidden>

commit 785ab826e24f5adeef40f2aff8d764a0e7f9e850
Author: albailey <email address hidden>
Date: Tue Apr 28 12:52:39 2020 -0500

    Clamp pylint to be less than 2.5.0

    A new version of pylint was released on April 27 and it is
    breaking zuul jobs so submissions cannot merge.

    Clamping pylint to be less than 2.5.0 for now.

    Change-Id: I77464800aa4ec5b94e10a5e9fbaeb0ddbd2e7845
    Partial-Bug: 1875705
    Signed-off-by: albailey <email address hidden>

commit 58f6baa560beeb2fbe700a39bb6d9eb1463e0a28
Author: Jessica Castelino <email address hidden>
Date: Fri Apr 24 15:46:10 2020 -0400

    Rename the existing /opt/patch-vault filesystem to /opt/dc-vault

    The filesystem /opt/patch-vault is renamed to /opt/dc-vault so that
    it can be re-used to store FPGA images and software loads. Thus,
    necessary changes have been made in the collect tool.

    Change-Id: I701dcb90e6c9571b5dc0eda17d27a241a40677d2
    Story: 2006740
    Task: 39550
    Depends-On: https://review.opendev.org/#/c/723007/
    Signed-off-by: Jessica Castelino <email address hidden>

commit b82899d14441daac5f674440e9f88b12c0bc10bd
Author: Jessica Castelino <email address hidden>
Date: Thu Apr 23 10:25:06 2020 -0400

    Collect contents of etcd database

    When the collect tool is run, it does not include the contents
    of the etcd database. Fixes have been made for this to dump the
    contents in "etcd_database.dump" file.

    Change-Id: If52144a18f...

Read more...

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers