cert-manager & nginx apps should not be allowed to be deleted after post-install

[ayyappa]

Brief Description
-----------------
The cert-manager,nginx apps are not allowed to remove/delete after post-install

Severity
--------
Major

Steps to Reproduce
------------------
1) list the apps and remove, delete the cert-manager and nginx apps

[sysadmin@controller-0 ~(keystone_admin)]$ system application-list
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
| application | version | manifest name | manifest file | status | progress |
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
| cert-manager | 1.0-0 | cert-manager-manifest | certmanager-manifest.yaml | applied | completed |
| nginx-ingress-controller | 1.0-0 | nginx-ingress-controller-manifest | nginx_ingress_controller_manifest.yaml | applied | completed |
| oidc-auth-apps | 1.0-0 | oidc-auth-manifest | manifest.yaml | uploaded | completed |
| platform-integ-apps | 1.0-8 | platform-integration-manifest | manifest.yaml | applied | completed |
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
[sysadmin@controller-0 ~(keystone_admin)]$ system application-remove cert-manager
+---------------+----------------------------------+
| Property | Value |
+---------------+----------------------------------+
| active | True |
| app_version | 1.0-0 |
| created_at | 2020-04-27T20:11:59.649299+00:00 |
| manifest_file | certmanager-manifest.yaml |
| manifest_name | cert-manager-manifest |
| name | cert-manager |
| progress | None |
| status | removing |
| updated_at | 2020-04-27T20:12:54.305302+00:00 |
+---------------+----------------------------------+
Please use 'system application-list' or 'system application-show cert-manager' to view the current progress.
[sysadmin@controller-0 ~(keystone_admin)]$ system application-delete cert-manager
Application cert-manager deleted.
[sysadmin@controller-0 ~(keystone_admin)]$ system application-list
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
| application | version | manifest name | manifest file | status | progress |
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
| nginx-ingress-controller | 1.0-0 | nginx-ingress-controller-manifest | nginx_ingress_controller_manifest.yaml | applied | completed |
| oidc-auth-apps | 1.0-0 | oidc-auth-manifest | manifest.yaml | uploaded | completed |
| platform-integ-apps | 1.0-8 | platform-integration-manifest | manifest.yaml | applied | completed |
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
[sysadmin@controller-0 ~(keystone_admin)]$ system application-remove nginx-ingress-controller
+---------------+----------------------------------------+
| Property | Value |
+---------------+----------------------------------------+
| active | True |
| app_version | 1.0-0 |
| created_at | 2020-04-27T20:08:50.498722+00:00 |
| manifest_file | nginx_ingress_controller_manifest.yaml |
| manifest_name | nginx-ingress-controller-manifest |
| name | nginx-ingress-controller |
| progress | None |
| status | removing |
| updated_at | 2020-04-27T20:11:38.659686+00:00 |
+---------------+----------------------------------------+
Please use 'system application-list' or 'system application-show nginx-ingress-controller' to view the current progress.

[sysadmin@controller-0 ~(keystone_admin)]$ system application-list
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
| application | version | manifest name | manifest file | status | progress |
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+
| nginx-ingress-controller | 1.0-0 | nginx-ingress-controller-manifest | nginx_ingress_controller_manifest.yaml | uploaded | completed |
| oidc-auth-apps | 1.0-0 | oidc-auth-manifest | manifest.yaml | uploaded | completed |
| platform-integ-apps | 1.0-8 | platform-integration-manifest | manifest.yaml | applied | completed |
+--------------------------+---------+-----------------------------------+----------------------------------------+----------+-----------+

[sysadmin@controller-0 ~(keystone_admin)]$ system application-delete nginx-ingress-controller
Application nginx-ingress-controller deleted.

2)both the apps are removed and deleted from the list

[sysadmin@controller-0 ~(keystone_admin)]$ system application-list
+---------------------+---------+-------------------------------+---------------+----------+-----------+
| application | version | manifest name | manifest file | status | progress |
+---------------------+---------+-------------------------------+---------------+----------+-----------+
| oidc-auth-apps | 1.0-0 | oidc-auth-manifest | manifest.yaml | uploaded | completed |
| platform-integ-apps | 1.0-8 | platform-integration-manifest | manifest.yaml | applied | completed |
+---------------------+---------+-------------------------------+---------------+----------+-----------+
[sysadmin@controller-0 ~(keystone_admin)]$ ^C

Expected Behavior
------------------
The cert-manager,nginx apps are not allowed to remove,deleted from the system

Actual Behavior
----------------
Both the apps are allowed to removed,deleted

Reproducibility
---------------
100%

System Configuration
--------------------

duplex system,wcp_61_62

Branch/Pull Time/Commit
-----------------------
2020-04-25

Last Pass
---------
Never

Timestamp/Logs
--------------
2020-04-28 14:13:12.971

Test Activity
-------------
Feature testing

Workaround
----------
system application-upload /usr/local/share/applications/helm/nginx-ingress-controller-1.0-0.tgz
system application-upload /usr/local/share/applications/helm/cert-manager-1.0-0.tgz

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - semantic checks should be added to prevent the deletion of the cert-mgr & nginx app as they are mandatory on the platform

[Ghada Khalil (gkhalil)]

Moving to stx.5.0 as this can be avoided if the user doesn't attempt to remove/delete these mandatory apps.

[Ghada Khalil (gkhalil)]

Reviews merged on 2021-03-16:
https://review.opendev.org/c/starlingx/config/+/776518
https://review.opendev.org/c/starlingx/config/+/778976
https://review.opendev.org/c/starlingx/ansible-playbooks/+/780029
https://review.opendev.org/c/starlingx/config/+/779023
https://review.opendev.org/c/starlingx/cert-manager-armada-app/+/780045
https://review.opendev.org/c/starlingx/nginx-ingress-controller-armada-app/+/780046