Package stx-nginx-ingress-controller-helm fails to build

[Scott Little]

Brief Description
-----------------
Flock layer build is currently broken on CENGN.
Failing package is stx-nginx-ingress-controller-helm.
The spec file for stx-nginx-ingress-controller-helm spec lacks any BuildRequires.
The first thing it trips over is when it tries to run 'helm'.

Severity
--------
Critical

Steps to Reproduce
------------------
build-pkgs --clean
build-pkgs stx-nginx-ingress-controller-helm

Expected Behavior
------------------
Builds

Actual Behavior
----------------
Fails to build

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
20200417T224901Z

Last Pass
---------
N/A

Timestamp/Logs
--------------
03:07:47 ERROR: Exception(/localdisk/loadbuild/jenkins/master-flock/20200417T224901Z/std/rpmbuild/SRPMS/stx-nginx-ingress-controller-helm-1.0-0.tis.src.rpm) Config(mock/b0) 0 minutes 3 seconds
03:07:47 INFO: Results and/or logs in: /localdisk/loadbuild/jenkins/master-flock/20200417T224901Z/std/results/jenkins-master-flock-3.0-std/stx-nginx-ingress-controller-helm-1.0-0.tis
03:07:47 ERROR: state finish mismatch: current: rpmbuild stx-nginx-ingress-controller-helm-1.0-0.tis.src.rpm, state: build phase for stx-nginx-ingress-controller-helm-1.0-0.tis.src.rpm

+ helm repo rm local
+ helm serve --repo-path .
/var/tmp/rpm-tmp.o3i4HE: line 47: helm: command not found
/var/tmp/rpm-tmp.o3i4HE: line 48: helm: command not found
error: Bad exit status from /var/tmp/rpm-tmp.o3i4HE (%build)
RPM build errors:

Test Activity
-------------
Build

 Workaround

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/721306

[Ghada Khalil (gkhalil)]

stx.4.0 / high priority - impacts layered builds / issue newly introduced by recent commit

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/721306
Committed: https://git.openstack.org/cgit/starlingx/nginx-ingress-controller-armada-app/commit/?id=e3e4b9275845453efcbd4aeb81b24defe98ea00d
Submitter: Zuul
Branch: master

commit e3e4b9275845453efcbd4aeb81b24defe98ea00d
Author: Sabeel Ansari <email address hidden>
Date: Mon Apr 20 10:32:09 2020 -0400

    Fix layered build

    The nginx-ingress-controller app was missing a build requirement
    check for the 'helm' package, which was causing the layered build to
    fail. This commit adds the dependency check.

    Closes-Bug: 1873603

    Change-Id: If6792f5d4348d4f257fcf93a4d32760cb110bd97
    Signed-off-by: Sabeel Ansari <email address hidden>