PCI device attributes may be parsed incorrectly

Bug #1869249 reported by Steven Webster
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Won't Fix
Low
Unassigned

Bug Description

Brief Description
-----------------
The sysinv agent periodically collects PCI device information from the system and reports it back to the system controller. The attributes collected are:

address, class, vendor, device, revision, subsystem vendor, subsystem device

To collect this information, the lspci utility is used which outputs the data in a machine readable format via the command lspci -Dm.

As per the man page for lspci:

http://man7.org/linux/man-pages/man8/lspci.8.html

Using the 'm' option produces output in which the relative order of positional arguments and options is undefined.

Because of this, it's possible that the pci device information may assign incorrect values to the various attributes.

There exists code that tries to correct for this (format_lspci_output), but it's still possible for this to happen. In addition, this code is a bit confusing to follow because of the named positional arguments.

The agent should be parsing the PCI attributes more deterministically, perhaps using the output of lspci -Dvmm , which would provide the output as attribute: value pairs

Severity
--------
Minor: This has not caused any known defects/failures at this time.

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
Any

Test Activity
-------------
Developer observation

Tags: stx.config
Revision history for this message
Ghada Khalil (gkhalil) wrote :

not gating - since this hasn't caused any issues

tags: added: stx.con
tags: added: stx.config
removed: stx.con
Changed in starlingx:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Ramaswamy Subramanian (rsubrama) wrote :

No progress on this bug for more than 2 years. Candidate for closure.

If there is no update, this issue is targeted to be closed as 'Won't Fix' in 2 weeks.

Revision history for this message
Ramaswamy Subramanian (rsubrama) wrote :

Changing the status to 'Won't Fix' as there is no activity.

Changed in starlingx:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.