usage of /etc/kubernetes/kubeadm.yaml outside of bootstrap

Bug #1866695 reported by Jerry Sun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Jerry Sun

Bug Description

Brief Description
-----------------
/etc/kubernetes/kubeadm.yaml is being used outside of bootstrap. This file could contain stale data (for example, kube-apiserver parameters changing post-bootstrap).

Example of usage of this file:
https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/puppet/kubernetes.py#L86

These should be changed to use a freshly generated file from "kubeadm config view" instead of using "/etc/kubernetes/kubeadm.yaml"

We also have this in one of our puppet manifests which should be removed:
-> exec { 'create kubeadm.yaml':
      command => 'kubeadm config view > /etc/kubernetes/kubeadm.yaml',
      creates => '/etc/kubernetes/kubeadm.yaml'
    }

Currently there are no system impacts, but we should get rid of these so people stop trying to use "/etc/kubernetes/kubeadm.yaml"

Severity
--------
Minor

Steps to Reproduce
------------------
-

Expected Behavior
------------------
-

Actual Behavior
----------------
-

Reproducibility
---------------
-

System Configuration
--------------------
-

Branch/Pull Time/Commit
-----------------------
master, 2020-03-09

Last Pass
---------
-

Timestamp/Logs
--------------
-

Test Activity
-------------
Developer testing

 Workaround
 ----------
-

Ghada Khalil (gkhalil)
Changed in starlingx:
assignee: nobody → Jerry Sun (jerry-sun-u)
tags: added: stx.containers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/713020

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (master)

Fix proposed to branch: master
Review: https://review.opendev.org/713024

Revision history for this message
Ghada Khalil (gkhalil) wrote :

Low priority - code cleanup

Changed in starlingx:
importance: Undecided → Low
tags: added: stx.config
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/713020
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=d7c3822a52ecc3b4288106c4e544e67add80fbf5
Submitter: Zuul
Branch: master

commit d7c3822a52ecc3b4288106c4e544e67add80fbf5
Author: Jerry Sun <email address hidden>
Date: Fri Mar 13 12:37:39 2020 -0400

    Remove usage of /etc/kubernetes/kubeadm.yaml

    /etc/kubernetes/kubeadm.yaml could contain stale data, for example, from
    changing kube-apiserver parameters. There are currently no system impacts
    from using the stale file, but as we change more parameters, there could
    be system impact. This commit makes the existing usage of kubeadm.yaml
    generate a temp copy of the file with current data first.

    Change-Id: I62391d184e3e5d6397a9af4f43c7c7ec19314afc
    Partial-bug: 1866695
    Signed-off-by: Jerry Sun <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master)

Reviewed: https://review.opendev.org/713024
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=17ce7aa97eb485807a46181b2a7db7e02641e245
Submitter: Zuul
Branch: master

commit 17ce7aa97eb485807a46181b2a7db7e02641e245
Author: Jerry Sun <email address hidden>
Date: Fri Mar 13 12:44:48 2020 -0400

    Remove creation of /etc/kuberetes/kubeadm.yaml

    Now that we are not using /etc/kubernetes/kubeadm.yaml anymore,
    we can remove the creation of the file from puppet. Bootstrap will
    still create it for bootstrap use.

    Change-Id: Id08af049fac3fc68b70a7dae5aec8548865a4784
    Closes-bug: 1866695
    Depends-On: https://review.opendev.org/#/c/713020/
    Signed-off-by: Jerry Sun <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/716137

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/716153

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (f/centos8)
Download full text (7.5 KiB)

Reviewed: https://review.opendev.org/716153
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=da2659f53aa94b9818dc78b28b739abd785e5546
Submitter: Zuul
Branch: f/centos8

commit ed763e6a5db5df4a0005dd57bd11b4c411557ea5
Author: Steven Webster <email address hidden>
Date: Sat Mar 28 17:23:16 2020 -0400

    Fix SR-IOV runtime manifest apply

    When an SR-IOV interface is configured, the platform's
    network runtime manifest is applied in order to apply the virtual
    function (VF) config and restart the interface. This results in
    sysinv being able to determine and populate the puppet hieradata
    with the virtual function PCI addresses.

    A side effect of the network manifest apply is that potentially
    all platform interfaces may be brought down/up if it is determined
    that their configuration has changed. This will likely be the case
    for a system which configures SR-IOV interfaces before initial
    unlock.

    A few issues have been encountered because of this, with some
    services not behaving well when the interface they are communicating
    over suddenly goes down.

    This commit makes the SR-IOV VF configuration much more targeted
    so that only the operation of setting the desired number of VFs
    is performed.

    Closes-Bug: #1868584

    Change-Id: Ic867fccae89fe8bc9173598c3c84c94ba2d7511f
    Signed-off-by: Steven Webster <email address hidden>

commit 1ca6d5914266fc7f424ec88e1a466b9f8ab5da9d
Author: Robert Church <email address hidden>
Date: Wed Mar 18 21:56:09 2020 -0400

    Add kubelet support for volume plugins

    When upversioning Calico from 3.6 to 3.12 the --volume-plugin-dir
    argument needs to be provided to kubelet.

    Specifically, the configuration for Calico 3.8 "Adds a Flex Volume
    Driver that creates a per-pod Unix Domain Socket to allow Dikastes to
    communicate with Felix over the Policy Sync API."

    Change-Id: Ic76baa00de4402cbb65c37fe89835b114d424634
    Story: 2006999
    Task: 39111
    Signed-off-by: Robert Church <email address hidden>

commit 17ce7aa97eb485807a46181b2a7db7e02641e245
Author: Jerry Sun <email address hidden>
Date: Fri Mar 13 12:44:48 2020 -0400

    Remove creation of /etc/kuberetes/kubeadm.yaml

    Now that we are not using /etc/kubernetes/kubeadm.yaml anymore,
    we can remove the creation of the file from puppet. Bootstrap will
    still create it for bootstrap use.

    Change-Id: Id08af049fac3fc68b70a7dae5aec8548865a4784
    Closes-bug: 1866695
    Depends-On: https://review.opendev.org/#/c/713020/
    Signed-off-by: Jerry Sun <email address hidden>

commit 027727470da6dcbf3641ff2a701d0c7561476920
Author: Jerry Sun <email address hidden>
Date: Wed Mar 11 14:18:15 2020 -0400

    Clean up change_apiserver_parameters in kubernetes puppet

    Move excess puppet execs into the template already used in the class

    Story: 2006711
    Task: 38944

    Change-Id: Iad54064fa4056f9f30406646c95623a1e7c25bec
    Signed-off-by: Jerry Sun <email address hidden>

commit b39136dc686549c1c937ba30d885ed6958603dba
Author: J...

Read more...

tags: added: in-f-centos8
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8)
Download full text (32.3 KiB)

Reviewed: https://review.opendev.org/716137
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=cb4cf4299c2ec10fb2eb03cdee3f6d78a6413089
Submitter: Zuul
Branch: f/centos8

commit 16477935845e1c27b4c9d31743e359b0aa94a948
Author: Steven Webster <email address hidden>
Date: Sat Mar 28 17:19:30 2020 -0400

    Fix SR-IOV runtime manifest apply

    When an SR-IOV interface is configured, the platform's
    network runtime manifest is applied in order to apply the virtual
    function (VF) config and restart the interface. This results in
    sysinv being able to determine and populate the puppet hieradata
    with the virtual function PCI addresses.

    A side effect of the network manifest apply is that potentially
    all platform interfaces may be brought down/up if it is determined
    that their configuration has changed. This will likely be the case
    for a system which configures SR-IOV interfaces before initial
    unlock.

    A few issues have been encountered because of this, with some
    services not behaving well when the interface they are communicating
    over suddenly goes down.

    This commit makes the SR-IOV VF configuration much more targeted
    so that only the operation of setting the desired number of VFs
    is performed.

    Closes-Bug: #1868584
    Depends-On: https://review.opendev.org/715669
    Change-Id: Ie162380d3732eb1b6e9c553362fe68cbc313ae2b
    Signed-off-by: Steven Webster <email address hidden>

commit 45c9fe2d3571574b9e0503af108fe7c1567007db
Author: Zhipeng Liu <email address hidden>
Date: Thu Mar 26 01:58:34 2020 +0800

    Add ipv6 support for novncproxy_base_url.

    For ipv6 address, we need url with below format
    [ip]:port

    Partial-Bug: 1859641

    Change-Id: I01a5cd92deb9e88c2d31bd1e16e5bce1e849fcc7
    Signed-off-by: Zhipeng Liu <email address hidden>

commit d119336b3a3b24d924e000277a37ab0b5f93aae1
Author: Andy Ning <email address hidden>
Date: Mon Mar 23 16:26:21 2020 -0400

    Fix timeout waiting for CA cert install during ansible replay

    During ansible bootstrap replay, the ssl_ca_complete_flag file is
    removed. It expects puppet platform::config::runtime manifest apply
    during system CA certificate install to re-generate it. So this commit
    updated conductor manager to run that puppet manifest even if the CA cert
    has already installed so that the ssl_ca_complete_flag file is created
    and makes ansible replay to continue.

    Change-Id: Ic9051fba9afe5d5a189e2be8c8c2960bdb0d20a4
    Closes-Bug: 1868585
    Signed-off-by: Andy Ning <email address hidden>

commit 24a533d800b2c57b84f1086593fe5f04f95fe906
Author: Zhipeng Liu <email address hidden>
Date: Fri Mar 20 23:10:31 2020 +0800

    Fix rabbitmq could not bind port to ipv6 address issue

    When we use Armada to deploy openstack service for ipv6, rabbitmq
    pod could not start listen on [::]:5672 and [::]:15672.
    For ipv6, we need an override for configuration file.

    Upstream patch link is:
    https://review.opendev.org/#/c/714027/

    Test pass for deploying rabbitmq service on both ipv...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.