DistributedCloud using deprecated oslo messaging fields

Bug #1865054 reported by Al Bailey on 2020-02-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Low
Bart Wensley

Bug Description

Brief Description
-----------------
DistributedCloud is using an oslo_messaging call from pike. (5.30.6)
The method signature was deprecated in stein, and removed in rocky.
Therefore when we move to a newer oslo_messaging, this code will need to be updated.

Severity
--------
Minor

Steps to Reproduce
------------------
None. Future coding issue

Expected Behavior
------------------
N/A. Future coding issue

Actual Behavior
----------------
N/A. Future coding issue

Reproducibility
---------------
N/A. Future coding issue

System Configuration
--------------------
Distributed Cloud'

Branch/Pull Time/Commit
-----------------------
Master Branch. Any time before Feb 27, 2020.

Last Pass
---------
N/A. Future coding issue

Timestamp/Logs
--------------
N/A. Future coding issue

Test Activity
-------------
Developer Testing

Workaround
----------
N/A. Future coding issue

Ghada Khalil (gkhalil) wrote :

low priority / not gating for now -- needs to be handled when stx updates oslo_messaging

Changed in starlingx:
importance: Undecided → Low
status: New → Triaged
tags: added: stx.distcloud
Changed in starlingx:
assignee: nobody → Al Bailey (albailey1974)

Reviewed: https://review.opendev.org/710331
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=501fa35af2780d57329478fe0ef0a6037ef8bf73
Submitter: Zuul
Branch: master

commit 501fa35af2780d57329478fe0ef0a6037ef8bf73
Author: Al Bailey <email address hidden>
Date: Tue Jan 21 17:04:56 2020 -0600

    Update pylint for distributedcloud

    The pylint that was specified as an upper constraint was not
    as strict as the newer versions.

    - Fixed or suppressed any new error codes being reported.
    Suppressed error codes should be fixed by additional reviews.

    - added a zuul target for pylint

    - Added dcdbsync to the folders being processed by pylint.

    - Removed the env:UPPER_CONSTRAINTS_FILE from tox.ini so that zuul
    does not override the upper constraints with an newer version.

    - Needed to add greenlet to the extension-pkg-whitelist since
    runtime introspection of that component is not possible.

    - oslo-messaging get_transport deprecated 'aliases' in pike, and
    removed it in rocky. The packaged version in STX is 5.30.6
    which still supports aliases. This requires us to explicitly
    run tox with the version that we ship (pre-stein). This is
    controlled by a local upper-constraints.txt file.
    Related-Bug: 1865054

    - Paste file handling reports a pylint issue which has been suppressed
    Related-Bug: 1865085

    Story: 2004515
    Task: 38882
    Change-Id: Ie7c8c2adab1eeb9100159a2aa29968a0b557e2e4
    Signed-off-by: Al Bailey <email address hidden>

Download full text (15.6 KiB)

Reviewed: https://review.opendev.org/716140
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=04b49dd093ab850f4520cdb85638221120dd7568
Submitter: Zuul
Branch: f/centos8

commit 25c9d6ed3861f2d783404fcf84b186441ab9cd4d
Author: albailey <email address hidden>
Date: Wed Mar 25 15:43:32 2020 -0500

    Removing ddt from unit tests

    This cleanup should assist in transitioning to
    stestr and fixtures, as well as py3 support.

    The ddt data is primarily unused, only subcloud, route
    and endpoints were being loaded.

    The information in the data files was out of date,
    and not necessarily matching the current product model.

    Story: 2004515
    Task: 39160
    Change-Id: Iddd7ed4664b0d59dbc58aae5c3fedd74c9a138c0
    Signed-off-by: albailey <email address hidden>

commit 7f3827f24d2fb3cb546d3caf71d505d23187b0dc
Author: Tao Liu <email address hidden>
Date: Thu Mar 12 09:46:29 2020 -0400

    Keystone token and resource caching

    Add the following misc. changes to dcorch and dcmanager components:
    - Cache the master resource in dcorch audit
    - Consolidate the openstack drivers to common module, combine the
      dcmanager and dcorch sysinv client. (Note: the sdk driver that
      used by nova, neutron and cinder will be cleaned as part of
      story 2006588).
    - Update the common sdk driver:
      . in order to avoid creating new keystone client multiple times
      . to add a option for caching region clients, in addition to the
        keystone client
      . finally, to randomize the token early renewal duration
    - Change subcloud audit manager, patch audit manager,
      and sw update manager to:
      utilize the sdk driver which caches the keystone client and token

    Test cases:
    1. Manage/unmanage subclouds
    2. Platform resources sync and audit
    3. Verify the keystone token is cached until the token is
       expired
    4. Add/delete subclouds
    5. Managed subcloud goes offline/online (power off/on)
    6. Managed subcloud goes offline/online (delete/add a static route)
    7. Apply a patch to all subclouds via patch Orchestration

    Story: 2007267
    Task: 38865

    Change-Id: I75e0cf66a797a65faf75e7c64dafb07f54c2df06
    Signed-off-by: Tao Liu <email address hidden>

commit 3a1bf60caddfa2e807d4f5996ff94fea7dde5477
Author: Jessica Castelino <email address hidden>
Date: Wed Mar 11 16:23:21 2020 -0400

    Cleanup subcloud details when subcloud add fails

    Failure during add subcloud prevents subcloud from being added again
    with the same name as the subcloud details are not cleaned up
    properly. Fixes have been added for proper cleanup of dcorch database
    tables, ansible subcloud inventory files, keystone endpoints, keystone
    region, and addn_hosts_dc file when failure is encountered.

    Test cases:
    1. Add subcloud
    2. Add subcloud with "--deploy-playbook"
    3. Delete subcloud
    4. Raise explicit exception in dcorch/objects/subcloud.py
    5. Raise explicit exception in dcmanager/manager/subcloud_manager.py

    Change-Id: Iedf172c3e9c3c4bdb9b9482dc5d46f072b3ccf61
    ...

tags: added: in-f-centos8
Bart Wensley (bartwensley) wrote :
Changed in starlingx:
assignee: Al Bailey (albailey1974) → Bart Wensley (bartwensley)
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers