Distributed Cloud: Create a subcloud API does not support bootstrap and deployment input in form of yaml files

Bug #1864508 reported by Tee Ngo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Tao Liu

Bug Description

Brief Description
-----------------
The distributed cloud API to create a subcloud https://docs.starlingx.io/api-ref/distcloud/api-ref-dcmanager-v1.html?expanded=creates-a-subcloud-detail#subclouds does not support bootstrap and deployment input in form of the yaml files.

Severity
--------
Major - REST API cannot be used to deploy a subcloud as part of subcloud add request.

Steps to Reproduce
------------------
Make a subclouds POST request with --bootstrap-address, --bootstrap-values, --deploy-playbook and --deploy-values as accepted in the CLI command "dcmanager subcloud add"

Expected Behavior
------------------
Input to REST API should be consistently processed as input to the CLI and that the content of the specified yaml files are read, validated and converted to the corresponding fields needed by the dcmanager service to bootstrap and deploy a subcloud.

Actual Behavior
----------------
The API rejects the request as the mandatory fields which are already provided in the yaml files are not explicitly specified in the POST request.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Distributed Cloud

Branch/Pull Time/Commit
-----------------------
Feb. 21st master build

Last Pass
---------
I don't think this add subcloud API test with deployment option had been tested before

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Evaluation

 Workaround
 ----------
 The user has to mimic the code in distributedcloud client to convert the content of the yaml files to the POST request payload that is accepted by the dcmanager api and service.

Revision history for this message
Ghada Khalil (gkhalil) wrote :

stx.4.0 / medium priority - related to distributed cloud api.

tags: added: stx.distcloud
tags: added: stx.4.0
Changed in starlingx:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Dariush Eslimi (deslimi)
Frank Miller (sensfan22)
Changed in starlingx:
assignee: Dariush Eslimi (deslimi) → Tao Liu (tliu88)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/720487

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (master)

Fix proposed to branch: master
Review: https://review.opendev.org/720488

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud-client (master)

Fix proposed to branch: master
Review: https://review.opendev.org/720497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master)

Fix proposed to branch: master
Review: https://review.opendev.org/720589

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/720487
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=f64ae62e4dfede86ad821aa8282a783f3c406c8d
Submitter: Zuul
Branch: master

commit f64ae62e4dfede86ad821aa8282a783f3c406c8d
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:04:52 2020 -0400

    Support subcloud deploy upload the common files

    Define a constant for /opt/platform/deploy/<version>

    Partial-Bug: 1864508

    Change-Id: Ide43993992aeae830631a0c1bb8ee377990a6974
    Signed-off-by: Tao Liu <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master)

Reviewed: https://review.opendev.org/720488
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=7910646e9bd97af02d7f95eec5d8bd3a19dfb0e1
Submitter: Zuul
Branch: master

commit 7910646e9bd97af02d7f95eec5d8bd3a19dfb0e1
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:08:59 2020 -0400

    Support subcloud deploy upload the common files

    Create /opt/platform/deploy to host the deploy common files.

    Partial-Bug: 1864508

    Change-Id: Ifd40cb02d4a2ee17a05457b43c6227aaa069e01e
    Signed-off-by: Tao Liu <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (master)

Fix proposed to branch: master
Review: https://review.opendev.org/721271

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (master)

Reviewed: https://review.opendev.org/721271
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=9a8136b5b11a874da9a5b67519a59b27530b4aad
Submitter: Zuul
Branch: master

commit 9a8136b5b11a874da9a5b67519a59b27530b4aad
Author: Tao Liu <email address hidden>
Date: Sat Apr 18 13:54:45 2020 -0400

    Backup & restore: subcloud deploy files

    Backup the subcloud deploy files if available on the system.
    Restore the subcloud deploy files if included in the archive.

    Testcases:
    Backup & restore System Controller with the subcloud deploy
    files.
    Backup & restore a regular system without the subcloud
    deploy files

    Partial-Bug: 1864508

    Change-Id: Ic14f6c02dd187a082b03458b0a766c690400e317
    Signed-off-by: Tao Liu <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master)
Download full text (3.3 KiB)

Reviewed: https://review.opendev.org/720589
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=58a7186beae7b10866aecd53fcde5be34321a52c
Submitter: Zuul
Branch: master

commit 58a7186beae7b10866aecd53fcde5be34321a52c
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:37:32 2020 -0400

    Support subcloud deploy upload the common files

    Add new REST APIs to upload and display the deploy manager
    common files on the System Controller.

    The deploy manager common files which include playbook,
    overrides and helm charts are uploaded to
    /opt/platform/deploy/<version>:
    /opt/platform/deploy/<version>/deploy_playbook_<original name>
    /opt/platform/deploy/<version>/deploy_overrides_<original name>
    /opt/platform/deploy/<version>/deploy_chart_<original name>

    Modify the subcloud post request to accept the bootstrap-values,
    install-values and deploy-config as file contents. The deploy
    config file is only used by the deploy manager and it is
    uploaded to /opt/dc/ansible.

    The information that used to create the overrides for the
    playbook are extracted and sent to the dcmanager, which include
    bootstrap values, install values and the full path of deploy
    file names, if the deploy-config is presented in the request.

    Testcases:
    REST APIs:
    1. curl -X POST -H "X-Auth-Token: $TOKEN" $APIURL/subcloud-deploy \
    -F deploy_playbook=@<full path of the playbook name> \
    -F deploy_overrides=@<full path of the override file name> \
    -F deploy_chart=@full path of the helm chart name>

    2. curl -X GET -H "X-Auth-Token: $TOKEN" $APIURL/subcloud-deploy

    3. curl -X POST -H "X-Auth-Token: $TOKEN" \
    $APIURL/subclouds \
    -F bootstrap_values=@<full path of the bootstrap override file> \
    -F sysadmin_password=<encoded password> \
    -F bootstrap-address=<bootstrap IP>

    4. curl -X POST -H "X-Auth-Token: $TOKEN" \
    $APIURL/subclouds \
    -F bootstrap_values=@<full path of the bootstrap override file> \
    -F install_values=@<full path of the install value file> \
    -F deploy_config=@<full path of the deploy config file> \
    -F sysadmin_password=<encoded password> \
    -F bmc_password=<encoded password> \
    -F bootstrap-address=<bootstrap IP> \

    CLI:
    1. dcmanager subcloud-deploy upload \
    --deploy-playbook <full path of the playbook name> \
    --deploy-chart <full path of the override file name> \
    --deploy-overrides <full path of the override file name>

    2. dcmanager subcloud-deploy show

    3. dcmanager subcloud add --bootstrap-address <IP> \
    --bootstrap-values <full path of the bootstrap override> \
    --deploy-config <full path of the deploy config file> \

    4. dcmanager subcloud add --bootstrap-address <IP> \
    --bootstrap-values <full path of the bootstrap override> \
    --install-values <full path of the install value file> \

    5.dcmanager subcloud add --bootstrap-address <IP> \
    --bootstrap-values <full path of the bootstrap override> \
    --install-values <full path of the install value file> \
    --deploy-config <full path of the depl...

Read more...

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud-client (master)

Reviewed: https://review.opendev.org/720497
Committed: https://git.openstack.org/cgit/starlingx/distcloud-client/commit/?id=19f027179c391362848f1a4b7f0629593a041162
Submitter: Zuul
Branch: master

commit 19f027179c391362848f1a4b7f0629593a041162
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:40:30 2020 -0400

    Support subcloud deploy upload the common files

    Add new CLI commands to upload and show the subcloud
    deploy common files:
    dcmanager subcloud-deploy upload \
    --deploy-playbook <play book> \
    --deploy-chart <helm chart> \
    --deploy-overrides <overrides>

    dcmanager subcloud-deploy show

    Changes to the subcloud add commands
    dcmanager subcloud add \
    --bootstrap-address oam_ip_address_of_subclouds_controller-0 \
    --bootstrap-values <file> \
    --deploy-config <file> \
    --sysadmin-password sysadmin_password \
    --install-values <file> \
    --bmc-password bmc_password

    The password is base64 encoded in the REST API request.
    The files are sent using multipart/form-data in the REST request.
    The file contents are processed by the API server.

    Depends-On: https://review.opendev.org/#/c/720589/
    Closes-Bug: 1864508

    Change-Id: Id92ee8b631789b4949b9682586060ce424983e88
    Signed-off-by: Tao Liu <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master)

Fix proposed to branch: master
Review: https://review.opendev.org/722388

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master)

Reviewed: https://review.opendev.org/722388
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=c890f8314ecc88d89cb0a4ae5f0e423580d94d6b
Submitter: Zuul
Branch: master

commit c890f8314ecc88d89cb0a4ae5f0e423580d94d6b
Author: Tao Liu <email address hidden>
Date: Thu Apr 23 11:49:02 2020 -0400

    Display an error message when the deploy file is missing

    Subcloud add command fails without an error message if the
    deploy files were not uploaded to System Controller.

    This update ensures that an error message is displayed to
    inform users the pertinent files are missing.

    Closes-Bug: 1864508

    Change-Id: Ibfceb6bc9155dc60d8e8379966b71bb2c7f076f0
    Signed-off-by: Tao Liu <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729809

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729812

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729815

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud-client (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729816

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/729825

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (f/centos8)
Download full text (16.7 KiB)

Reviewed: https://review.opendev.org/729825
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=d4617fbad74a05f2af81ee85a47565083991e6f8
Submitter: Zuul
Branch: f/centos8

commit 4134023ab84d8a635b118d5e3ff26ade3bbe535b
Author: Sharath Kumar K <email address hidden>
Date: Thu May 7 10:08:11 2020 +0200

    Tox and Zuul job for the bandit code scan in stx/stx-puppet

    Setting up the bandit tool for the scanning of HIGH severity issues
    in the python codes under Starlingx/stx-puppet folder.
    Expecting this merge will enable zuul job for CI/CD of bandit scan.

    Configuration files:
    1. tox.ini for adding bandit environment and command.
    2. test-requirements.txt for adding bandit version.
    3. .zuul.yaml file for adding bandit job and configuring under
       check job to run code scan every time before code commit.

    Test:
    Run tox -e bandit command inside the fault folder to validate the
    bandit scan and result.

    Story: 2007541
    Task: 39687
    Depends-On: https://review.opendev.org/#/c/721294/

    Change-Id: I2982268db2b5e75feeb287bc95420fedc9b0d816
    Signed-off-by: Sharath Kumar K <email address hidden>

commit 65daac29e4635f32a57e80cd18f96fd59dc8ebe0
Author: Bin Qian <email address hidden>
Date: Tue May 12 22:39:21 2020 -0400

    DC cert manifest should only apply to controller nodes

    DC cert manifest should only apply to controller nodes on system
    controller.
    This fix is for DC with worker nodes in central cloud.

    Change-Id: I4233509a6f0afb3013c01e81dea6f655d9e15371
    Closes-Bug: 1878260
    Signed-off-by: Bin Qian <email address hidden>

commit 04a3cb8cbad9b1700286c5de67aa5d974cf54400
Author: Elena Taivan <email address hidden>
Date: Wed Apr 29 08:44:13 2020 +0000

    Changing permissions for conversion folder

    Adding writing permissions to '/opt/conversion' mountpoint
    so openstack image conversion can happen there.

    Change-Id: Id1a91db6570dcbed3b8068e79e72f5bb800f24ad
    Partial-bug: 1819688
    Signed-off-by: Elena Taivan <email address hidden>

commit 4e9153cf234e714e4bbc9a9eb3d9b55b2828145a
Author: Tao Liu <email address hidden>
Date: Mon May 4 14:30:30 2020 -0500

    Move subcloud audit to separate process

    Subcloud audit is being removed from the dcmanager-manager
    process and it is running in dcmanager-audit process.

    This update adds associated puppet config.

    Story: 2007267
    Task: 39640
    Depends-On: https://review.opendev.org/#/c/725627/

    Change-Id: Idd2e675126a01d6113597646ddd9eb4a0bc5be44
    Signed-off-by: Tao Liu <email address hidden>

commit b793518f65ae932f3974ff85b797f505b5ef1c2a
Author: Robert Church <email address hidden>
Date: Wed Apr 29 12:49:04 2020 -0400

    Ensure containerd binds to the loopback interface

    Set the stream_server_address to bind to the loopback interface with a
    value of "127.0.0.1" for IPv4 and "::1" for IPv6.

    Without setting the stream_server_address in config.toml, containerd was
    binding to the OAM interface. Under most situations this resulted in
    containe...

tags: added: in-f-centos8
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud-client (f/centos8)
Download full text (3.5 KiB)

Reviewed: https://review.opendev.org/729816
Committed: https://git.openstack.org/cgit/starlingx/distcloud-client/commit/?id=47ca1dc8850e82474413014b8253d89854e256e0
Submitter: Zuul
Branch: f/centos8

commit c640a5144011b25a76637ce3bb6cb59b16d35def
Author: albailey <email address hidden>
Date: Tue Apr 14 15:00:01 2020 -0500

    Adding upgrade strategy commands

    dcmanager strategy-config
    dcmanager upgrade-strategy

    This change refactors the existing sw-update code so that
    patch and upgrades share common functionality.

    This adds the strategy 'type' to the CLI output so that a
    user can differentiate between which strategy type is
    being orchestrated.

    patch-strategy-config is generic to all update types, so a new
    strategy-config CLI command is now registered.

    Change-Id: Icd33eb26f907e8e250ebddbba7d2cebea3592ac7
    Depends-On: https://review.opendev.org/#/c/721620
    Story: 2007403
    Task: 39654
    Signed-off-by: albailey <email address hidden>

commit 19f027179c391362848f1a4b7f0629593a041162
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:40:30 2020 -0400

    Support subcloud deploy upload the common files

    Add new CLI commands to upload and show the subcloud
    deploy common files:
    dcmanager subcloud-deploy upload \
    --deploy-playbook <play book> \
    --deploy-chart <helm chart> \
    --deploy-overrides <overrides>

    dcmanager subcloud-deploy show

    Changes to the subcloud add commands
    dcmanager subcloud add \
    --bootstrap-address oam_ip_address_of_subclouds_controller-0 \
    --bootstrap-values <file> \
    --deploy-config <file> \
    --sysadmin-password sysadmin_password \
    --install-values <file> \
    --bmc-password bmc_password

    The password is base64 encoded in the REST API request.
    The files are sent using multipart/form-data in the REST request.
    The file contents are processed by the API server.

    Depends-On: https://review.opendev.org/#/c/720589/
    Closes-Bug: 1864508

    Change-Id: Id92ee8b631789b4949b9682586060ce424983e88
    Signed-off-by: Tao Liu <email address hidden>

commit 190c0c45586f714b0f2a806a4d6f31a9b410e7a4
Author: albailey <email address hidden>
Date: Mon Mar 9 12:46:13 2020 -0500

    Enable pylint for distributed cloud client

    The error codes detected by pylint are suppressed
    and can be fixed by later submissions.

    The get_parser methods were updated to fix the
    arguments-differ error code, because the base method
    defined in 'cliff' expects prog_name as its argument.

    This also adds the pylint target to zuul.

    Story: 2007082
    Task: 39360
    Change-Id: Idf7264fa7594e4c9a18603960a566601883865a8
    Signed-off-by: albailey <email address hidden>

commit 826e167d5e56baff284d2f3360de457ca5753765
Author: albailey <email address hidden>
Date: Mon Mar 9 10:22:47 2020 -0500

    Subcloud Group support for dcmanager CLI

    Added CLI calls for:

    dcmanager
      subcloud-group add
      subcloud-group delete
      subcloud-group list
      subcloud-group show
      subcloud-group update
      su...

Read more...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8)
Download full text (37.5 KiB)

Reviewed: https://review.opendev.org/729812
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=539d476456277c22d0dcbc3cbbc832e623242264
Submitter: Zuul
Branch: f/centos8

commit 320cc40de8518787c2be234d7fdf88ec0a462df2
Author: Don Penney <email address hidden>
Date: Wed May 13 13:06:11 2020 -0400

    Add auto-versioning to starlingx/config packages

    This update makes use of the PKG_GITREVCOUNT variable to auto-version
    the packages in this repo.

    Change-Id: I3a2c8caeb4b4647608978b1f2ccfcf0661508803
    Depends-On: https://review.opendev.org/727837
    Story: 2006166
    Task: 39766
    Signed-off-by: Don Penney <email address hidden>

commit d9f2aea0fb228ed69eb9c9262e29041eedabc15d
Author: Sharath Kumar K <email address hidden>
Date: Wed Apr 22 16:22:22 2020 +0200

    De-branding in starlingx/config: CGCS -> StarlingX

    1. Rename CGCS to StarlingX for .spec files

    Test:
    After the de-brand change, bootimage.iso has been built in the flock
    Layer and installed on the dev machine to validate the changes.

    Please note, doing de-brand changes in batches, this is batch9 changes.

    Story: 2006387
    Task: 39524

    Change-Id: Ia1fe0f2baafb78c974551100f16e6a7d99882f15
    Signed-off-by: Sharath Kumar K <email address hidden>

    De-branding in starlingx/config: CGCS -> StarlingX

    1. Rename CGCS to StarlingX for .spec file
    2. Rename TIS to StarlingX for .service files

    Test:
    After the de-brand change, bootimage.iso has been built in the flock
    Layer and installed on the dev machine to validate the changes.

    Please note, doing de-brand changes in batches, this is batch10 changes.

    Story: 2006387
    Task: 36202

    Change-Id: I404ce0da2621495175ad31489e9ad6f7b0211e26
    Signed-off-by: Sharath Kumar K <email address hidden>

commit d141e954fa6bbf688929ec90d1b6604a97792c43
Author: Teresa Ho <email address hidden>
Date: Tue Mar 31 10:08:57 2020 -0400

    Sysinv extensions for FPGA support

    This update adds cli and restapi to support FPGA device
    programming.

    CLI commands:
    system device-image-apply
    system device-image-create
    system device-image-delete
    system device-image-list
    system device-image-remove
    system device-image-show
    system device-image-state-list
    system device-label-list
    system host-device-image-update
    system host-device-image-update-abort
    system host-device-label-assign
    system host-device-label-list
    system host-device-label-remove

    Story: 2006740
    Task: 39498

    Change-Id: I556c2e7a51b3931b5a66ab27b67f51e3a8aebd9f
    Signed-off-by: Teresa Ho <email address hidden>

commit 491cca42ed854d2cb3ee3646b93c56a4f45f563c
Author: Elena Taivan <email address hidden>
Date: Wed Apr 29 11:25:26 2020 +0000

    Qcow2 conversion to raw can be done using 'image-conversion' filesystem

    1. Conversion filesystem can be added before/after
       stx-openstack is applied
    2. If conversion filesystem is added after stx-openstack
       is applied, changes to stx-openstack will only take effec...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (f/centos8)
Download full text (22.6 KiB)

Reviewed: https://review.opendev.org/729809
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=73027425d4501a6b7785e91024c9e8ddbc03115d
Submitter: Zuul
Branch: f/centos8

commit 55c9afd075194f7669fa2a87e546f61034679b04
Author: Dan Voiculeasa <email address hidden>
Date: Wed May 13 14:19:52 2020 +0300

    Restore: disconnect etcd from ceph

    At the moment etcd is restored only if ceph data is kept.
    Etcd should be restored regardless if ceph data is kept or wiped.

    Story: 2006770
    Task 39751
    Change-Id: I9dfb1be0a83c3fdc5f1b29cbb974c5e0e2236ad3
    Signed-off-by: Dan Voiculeasa <email address hidden>

commit 003ddff574c74adf11cf8e4758e93ba0eed45a6a
Author: Don Penney <email address hidden>
Date: Fri May 8 11:35:58 2020 -0400

    Add playbook for updating static images

    This commit introduces a new playbook, upgrade-static-images.yml, used
    for downloading updating images and pushing to the local registry.

    Change-Id: I8884440261a5a4e27b40398e5a75c9d03b09d4ba
    Story: 2006781
    Task: 39706
    Signed-off-by: Don Penney <email address hidden>

commit 26fd273cf5175ba4bdd31d6b6b777814f1a6c860
Author: Matt Peters <email address hidden>
Date: Thu May 7 14:29:02 2020 -0500

    Add kube-apiserver port to calico failsafe rules

    An invalid GlobalNetworkPolicy or NetworkPolicy may prevent
    calico-node from communicating with the kube-apiserver.
    Once the communication is broken, calico-node is no longer
    able to update the policies since it cannot communicate to
    read the updated policies. It can also prevent the pod
    from starting since the policies will prevent it from
    reading the configuration.

    To ensure that this scenario does not happen, the kube-apiserver
    port is being added to the failsafe rules to ensure communication
    is always possible, regardless of the network policy configuration.

    Change-Id: I1b065a74e7ad0ba9b1fdba4b63136b97efbe98ce
    Closes-Bug: 1877166
    Related-Bug: 1877383
    Signed-off-by: Matt Peters <email address hidden>

commit bd0f14a7dfb206ccaa3ce0f5e7d9034703b3403c
Author: Robert Church <email address hidden>
Date: Tue May 5 15:11:15 2020 -0400

    Provide an update strategy for Tiller deployment

    In the case of a simplex controller configuration the current patching
    strategy for the Tiller environment will fail as the tiller ports will
    be in use when the new deployment is attempted to be applied. The
    resulting tiller pod will be stuck in a Pending state.

    This will be observed if the node becomes ready after 'helm init'
    installs the initial deployment and before the deployment is patched for
    environment checks.

    The deployment strategy provided by 'helm init' is unspecified. This
    change will allow one additional pod (current + new) and one unavailable
    pod (current) during an update. The maxUnavailable setting allows the
    tiller pod to be deleted which will release its ports, thus allowing the
    patch deployment to spin up an new pod to a Running state.

    Change-Id: I83c43c52a77...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (f/centos8)
Download full text (19.6 KiB)

Reviewed: https://review.opendev.org/729815
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=a39415ff84d71a54580eb8cbe885647e69279306
Submitter: Zuul
Branch: f/centos8

commit 5c8377047ba679ce88a0360315df494a74208bbf
Author: Tao Liu <email address hidden>
Date: Tue May 5 08:59:59 2020 -0500

    Move subcloud audit to separate process

    Remove subcloud audit from dcmanager-manager process.
    Create dcmanager-audit process & associated files.
    Add new RPC calls for dcmanager-audit to notify dcmanager
    subcloud availability and sync endpoint type changes.
    Update dcmanager to handle availability and sync endpoint
    type updates from dcmanager-audit.
    Subcloud audit interval will be reduced to 20 seconds.
    Create/update unit tests, to verify the implementation
    changes.

    Story: 2007267
    Task: 39637

    Change-Id: Iff408166753f22ce3616d34e267ca1155ac43042
    Signed-off-by: Tao Liu <email address hidden>

commit d46516c46d24f8fea6ea71fdbe2f3fa2d296eb4d
Author: albailey <email address hidden>
Date: Wed May 13 14:00:12 2020 -0500

    Enable python3 unit tests as part of zuul

    The existing py27 unit tests were not all passing in py36,
    however now they are and so the zuul check and gate for py36
    have been added.

    Change-Id: Ie293ec69a04e6fd657f960aa9a135c428138b4b4
    Story: 2004515
    Task: 39768
    Signed-off-by: albailey <email address hidden>

commit dbf603b4c45e865e56a21d3b14d94bcc8d5f455c
Author: albailey <email address hidden>
Date: Mon May 11 10:29:45 2020 -0500

    Reduce the number of suppressed pylint warnings

    All pylint warnings were being suppressed by a wildcard.
    This commit only suppresses the warnings that are failing and
    prevents checks that would pass from being broken in later commits.

    The warnings being suppressed can be resolved individually
    by later submissions based on priority where appropriate.

    This commit also specifies python3 for pylint which has
    more recent checks.

    Change-Id: Ie29aeb0ea3e9dcb671af67f38e9a3f919ea7111e
    Story: 2004515
    Task: 39734
    Signed-off-by: albailey <email address hidden>

commit 15fb58f45c0f552eccd9c27ba023dbea560f27f2
Author: albailey <email address hidden>
Date: Fri May 8 13:20:23 2020 -0500

    Enhance Upgrade strategy to use endpoint audit status

    The distributed cloud audit was updated to include 'load'
    endpoint status, so the upgrade strategy is now able to
    make use of that information when constructing a strategy.

    Change-Id: I69eb4d98b9abf38b329e13fb116fc098db2bd736
    Story: 2007403
    Task: 39736
    Signed-off-by: albailey <email address hidden>

commit acc710093bb1c9581670d20b62c68ad669b3a3ad
Author: MCamp859 <email address hidden>
Date: Mon May 11 14:28:28 2020 -0400

    Minor edits to test docs promote issue

    Change-Id: I08ffc5e57b5b04c59102a6491f2fcdc256f16e0f
    Signed-off-by: MCamp859 <email address hidden>

commit 6d4fa855462cc6faf2e962f9d825b832f2885aa3
Author: Tee Ngo <email address hidden>
Date: Mon May 4 23:53:20 2020 -0400

    Extend subcloud audit...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.