Distributed Cloud: Create a subcloud API does not support bootstrap and deployment input in form of yaml files
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Medium
|
Tao Liu |
Bug Description
Brief Description
-----------------
The distributed cloud API to create a subcloud https:/
Severity
--------
Major - REST API cannot be used to deploy a subcloud as part of subcloud add request.
Steps to Reproduce
------------------
Make a subclouds POST request with --bootstrap-
Expected Behavior
------------------
Input to REST API should be consistently processed as input to the CLI and that the content of the specified yaml files are read, validated and converted to the corresponding fields needed by the dcmanager service to bootstrap and deploy a subcloud.
Actual Behavior
----------------
The API rejects the request as the mandatory fields which are already provided in the yaml files are not explicitly specified in the POST request.
Reproducibility
---------------
100% reproducible
System Configuration
-------
Distributed Cloud
Branch/Pull Time/Commit
-------
Feb. 21st master build
Last Pass
---------
I don't think this add subcloud API test with deployment option had been tested before
Timestamp/Logs
--------------
N/A
Test Activity
-------------
Evaluation
Workaround
----------
The user has to mimic the code in distributedcloud client to convert the content of the yaml files to the POST request payload that is accepted by the dcmanager api and service.
Ghada Khalil (gkhalil) wrote : | #1 |
tags: | added: stx.distcloud |
tags: | added: stx.4.0 |
Changed in starlingx: | |
importance: | Undecided → Medium |
status: | New → Triaged |
assignee: | nobody → Dariush Eslimi (deslimi) |
Changed in starlingx: | |
assignee: | Dariush Eslimi (deslimi) → Tao Liu (tliu88) |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master) | #2 |
Fix proposed to branch: master
Review: https:/
Changed in starlingx: | |
status: | Triaged → In Progress |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (master) | #3 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud-client (master) | #4 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master) | #5 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master) | #6 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit f64ae62e4dfede8
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:04:52 2020 -0400
Support subcloud deploy upload the common files
Define a constant for /opt/platform/
Partial-Bug: 1864508
Change-Id: Ide43993992aeae
Signed-off-by: Tao Liu <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master) | #7 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 7910646e9bd97af
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:08:59 2020 -0400
Support subcloud deploy upload the common files
Create /opt/platform/
Partial-Bug: 1864508
Change-Id: Ifd40cb02d4a2ee
Signed-off-by: Tao Liu <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (master) | #8 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (master) | #9 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 9a8136b5b11a874
Author: Tao Liu <email address hidden>
Date: Sat Apr 18 13:54:45 2020 -0400
Backup & restore: subcloud deploy files
Backup the subcloud deploy files if available on the system.
Restore the subcloud deploy files if included in the archive.
Testcases:
Backup & restore System Controller with the subcloud deploy
files.
Backup & restore a regular system without the subcloud
deploy files
Partial-Bug: 1864508
Change-Id: Ic14f6c02dd187a
Signed-off-by: Tao Liu <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master) | #10 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 58a7186beae7b10
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:37:32 2020 -0400
Support subcloud deploy upload the common files
Add new REST APIs to upload and display the deploy manager
common files on the System Controller.
The deploy manager common files which include playbook,
overrides and helm charts are uploaded to
/opt/
/opt/
/opt/
/opt/
Modify the subcloud post request to accept the bootstrap-values,
install-values and deploy-config as file contents. The deploy
config file is only used by the deploy manager and it is
uploaded to /opt/dc/ansible.
The information that used to create the overrides for the
playbook are extracted and sent to the dcmanager, which include
bootstrap values, install values and the full path of deploy
file names, if the deploy-config is presented in the request.
Testcases:
REST APIs:
1. curl -X POST -H "X-Auth-Token: $TOKEN" $APIURL/
-F deploy_
-F deploy_
-F deploy_chart=@full path of the helm chart name>
2. curl -X GET -H "X-Auth-Token: $TOKEN" $APIURL/
3. curl -X POST -H "X-Auth-Token: $TOKEN" \
$APIURL/
-F bootstrap_
-F sysadmin_
-F bootstrap-
4. curl -X POST -H "X-Auth-Token: $TOKEN" \
$APIURL/
-F bootstrap_
-F install_
-F deploy_
-F sysadmin_
-F bmc_password=
-F bootstrap-
CLI:
1. dcmanager subcloud-deploy upload \
--deploy-
--deploy-chart <full path of the override file name> \
--deploy-
2. dcmanager subcloud-deploy show
3. dcmanager subcloud add --bootstrap-address <IP> \
--bootstrap
--deploy-config <full path of the deploy config file> \
4. dcmanager subcloud add --bootstrap-address <IP> \
--bootstrap
--install-
5.dcmanager subcloud add --bootstrap-address <IP> \
--bootstrap
--install-
--deploy-config <full path of the depl...
Changed in starlingx: | |
status: | In Progress → Fix Released |
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud-client (master) | #11 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 19f027179c39136
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:40:30 2020 -0400
Support subcloud deploy upload the common files
Add new CLI commands to upload and show the subcloud
deploy common files:
dcmanager subcloud-deploy upload \
--deploy-
--deploy-chart <helm chart> \
--deploy-
dcmanager subcloud-deploy show
Changes to the subcloud add commands
dcmanager subcloud add \
--bootstrap
--bootstrap
--deploy-config <file> \
--sysadmin-
--install-
--bmc-password bmc_password
The password is base64 encoded in the REST API request.
The files are sent using multipart/form-data in the REST request.
The file contents are processed by the API server.
Depends-On: https:/
Closes-Bug: 1864508
Change-Id: Id92ee8b631789b
Signed-off-by: Tao Liu <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master) | #12 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master) | #13 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit c890f8314ecc88d
Author: Tao Liu <email address hidden>
Date: Thu Apr 23 11:49:02 2020 -0400
Display an error message when the deploy file is missing
Subcloud add command fails without an error message if the
deploy files were not uploaded to System Controller.
This update ensures that an error message is displayed to
inform users the pertinent files are missing.
Closes-Bug: 1864508
Change-Id: Ibfceb6bc9155dc
Signed-off-by: Tao Liu <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (f/centos8) | #14 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8) | #15 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (f/centos8) | #16 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud-client (f/centos8) | #17 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8) | #18 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (f/centos8) | #19 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 4134023ab84d8a6
Author: Sharath Kumar K <email address hidden>
Date: Thu May 7 10:08:11 2020 +0200
Tox and Zuul job for the bandit code scan in stx/stx-puppet
Setting up the bandit tool for the scanning of HIGH severity issues
in the python codes under Starlingx/
Expecting this merge will enable zuul job for CI/CD of bandit scan.
Configuration files:
1. tox.ini for adding bandit environment and command.
2. test-requiremen
3. .zuul.yaml file for adding bandit job and configuring under
check job to run code scan every time before code commit.
Test:
Run tox -e bandit command inside the fault folder to validate the
bandit scan and result.
Story: 2007541
Task: 39687
Depends-On: https:/
Change-Id: I2982268db2b5e7
Signed-off-by: Sharath Kumar K <email address hidden>
commit 65daac29e4635f3
Author: Bin Qian <email address hidden>
Date: Tue May 12 22:39:21 2020 -0400
DC cert manifest should only apply to controller nodes
DC cert manifest should only apply to controller nodes on system
controller.
This fix is for DC with worker nodes in central cloud.
Change-Id: I4233509a6f0afb
Closes-Bug: 1878260
Signed-off-by: Bin Qian <email address hidden>
commit 04a3cb8cbad9b17
Author: Elena Taivan <email address hidden>
Date: Wed Apr 29 08:44:13 2020 +0000
Changing permissions for conversion folder
Adding writing permissions to '/opt/conversion' mountpoint
so openstack image conversion can happen there.
Change-Id: Id1a91db6570dcb
Partial-bug: 1819688
Signed-off-by: Elena Taivan <email address hidden>
commit 4e9153cf234e714
Author: Tao Liu <email address hidden>
Date: Mon May 4 14:30:30 2020 -0500
Move subcloud audit to separate process
Subcloud audit is being removed from the dcmanager-manager
process and it is running in dcmanager-audit process.
This update adds associated puppet config.
Story: 2007267
Task: 39640
Depends-On: https:/
Change-Id: Idd2e675126a01d
Signed-off-by: Tao Liu <email address hidden>
commit b793518f65ae932
Author: Robert Church <email address hidden>
Date: Wed Apr 29 12:49:04 2020 -0400
Ensure containerd binds to the loopback interface
Set the stream_
value of "127.0.0.1" for IPv4 and "::1" for IPv6.
Without setting the stream_
binding to the OAM interface. Under most situations this resulted in
containe...
tags: | added: in-f-centos8 |
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud-client (f/centos8) | #20 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit c640a5144011b25
Author: albailey <email address hidden>
Date: Tue Apr 14 15:00:01 2020 -0500
Adding upgrade strategy commands
dcmanager strategy-config
dcmanager upgrade-strategy
This change refactors the existing sw-update code so that
patch and upgrades share common functionality.
This adds the strategy 'type' to the CLI output so that a
user can differentiate between which strategy type is
being orchestrated.
patch-
strategy-config CLI command is now registered.
Change-Id: Icd33eb26f907e8
Depends-On: https:/
Story: 2007403
Task: 39654
Signed-off-by: albailey <email address hidden>
commit 19f027179c39136
Author: Tao Liu <email address hidden>
Date: Thu Apr 16 10:40:30 2020 -0400
Support subcloud deploy upload the common files
Add new CLI commands to upload and show the subcloud
deploy common files:
dcmanager subcloud-deploy upload \
--deploy-
--deploy-chart <helm chart> \
--deploy-
dcmanager subcloud-deploy show
Changes to the subcloud add commands
dcmanager subcloud add \
--bootstrap
--bootstrap
--deploy-config <file> \
--sysadmin-
--install-
--bmc-password bmc_password
The password is base64 encoded in the REST API request.
The files are sent using multipart/form-data in the REST request.
The file contents are processed by the API server.
Depends-On: https:/
Closes-Bug: 1864508
Change-Id: Id92ee8b631789b
Signed-off-by: Tao Liu <email address hidden>
commit 190c0c45586f714
Author: albailey <email address hidden>
Date: Mon Mar 9 12:46:13 2020 -0500
Enable pylint for distributed cloud client
The error codes detected by pylint are suppressed
and can be fixed by later submissions.
The get_parser methods were updated to fix the
arguments-
defined in 'cliff' expects prog_name as its argument.
This also adds the pylint target to zuul.
Story: 2007082
Task: 39360
Change-Id: Idf7264fa7594e4
Signed-off-by: albailey <email address hidden>
commit 826e167d5e56baf
Author: albailey <email address hidden>
Date: Mon Mar 9 10:22:47 2020 -0500
Subcloud Group support for dcmanager CLI
Added CLI calls for:
dcmanager
subcloud-
subcloud-
subcloud-
subcloud-
subcloud-
su...
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8) | #21 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 320cc40de851878
Author: Don Penney <email address hidden>
Date: Wed May 13 13:06:11 2020 -0400
Add auto-versioning to starlingx/config packages
This update makes use of the PKG_GITREVCOUNT variable to auto-version
the packages in this repo.
Change-Id: I3a2c8caeb4b464
Depends-On: https:/
Story: 2006166
Task: 39766
Signed-off-by: Don Penney <email address hidden>
commit d9f2aea0fb228ed
Author: Sharath Kumar K <email address hidden>
Date: Wed Apr 22 16:22:22 2020 +0200
De-branding in starlingx/config: CGCS -> StarlingX
1. Rename CGCS to StarlingX for .spec files
Test:
After the de-brand change, bootimage.iso has been built in the flock
Layer and installed on the dev machine to validate the changes.
Please note, doing de-brand changes in batches, this is batch9 changes.
Story: 2006387
Task: 39524
Change-Id: Ia1fe0f2baafb78
Signed-off-by: Sharath Kumar K <email address hidden>
De-branding in starlingx/config: CGCS -> StarlingX
1. Rename CGCS to StarlingX for .spec file
2. Rename TIS to StarlingX for .service files
Test:
After the de-brand change, bootimage.iso has been built in the flock
Layer and installed on the dev machine to validate the changes.
Please note, doing de-brand changes in batches, this is batch10 changes.
Story: 2006387
Task: 36202
Change-Id: I404ce0da262149
Signed-off-by: Sharath Kumar K <email address hidden>
commit d141e954fa6bbf6
Author: Teresa Ho <email address hidden>
Date: Tue Mar 31 10:08:57 2020 -0400
Sysinv extensions for FPGA support
This update adds cli and restapi to support FPGA device
programming.
CLI commands:
system device-image-apply
system device-image-create
system device-image-delete
system device-image-list
system device-image-remove
system device-image-show
system device-
system device-label-list
system host-device-
system host-device-
system host-device-
system host-device-
system host-device-
Story: 2006740
Task: 39498
Change-Id: I556c2e7a51b393
Signed-off-by: Teresa Ho <email address hidden>
commit 491cca42ed854d2
Author: Elena Taivan <email address hidden>
Date: Wed Apr 29 11:25:26 2020 +0000
Qcow2 conversion to raw can be done using 'image-conversion' filesystem
1. Conversion filesystem can be added before/after
2. If conversion filesystem is added after stx-openstack
is applied, changes to stx-openstack will only take effec...
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (f/centos8) | #22 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 55c9afd075194f7
Author: Dan Voiculeasa <email address hidden>
Date: Wed May 13 14:19:52 2020 +0300
Restore: disconnect etcd from ceph
At the moment etcd is restored only if ceph data is kept.
Etcd should be restored regardless if ceph data is kept or wiped.
Story: 2006770
Task 39751
Change-Id: I9dfb1be0a83c3f
Signed-off-by: Dan Voiculeasa <email address hidden>
commit 003ddff574c74ad
Author: Don Penney <email address hidden>
Date: Fri May 8 11:35:58 2020 -0400
Add playbook for updating static images
This commit introduces a new playbook, upgrade-
for downloading updating images and pushing to the local registry.
Change-Id: I8884440261a5a4
Story: 2006781
Task: 39706
Signed-off-by: Don Penney <email address hidden>
commit 26fd273cf5175ba
Author: Matt Peters <email address hidden>
Date: Thu May 7 14:29:02 2020 -0500
Add kube-apiserver port to calico failsafe rules
An invalid GlobalNetworkPolicy or NetworkPolicy may prevent
calico-node from communicating with the kube-apiserver.
Once the communication is broken, calico-node is no longer
able to update the policies since it cannot communicate to
read the updated policies. It can also prevent the pod
from starting since the policies will prevent it from
reading the configuration.
To ensure that this scenario does not happen, the kube-apiserver
port is being added to the failsafe rules to ensure communication
is always possible, regardless of the network policy configuration.
Change-Id: I1b065a74e7ad0b
Closes-Bug: 1877166
Related-Bug: 1877383
Signed-off-by: Matt Peters <email address hidden>
commit bd0f14a7dfb206c
Author: Robert Church <email address hidden>
Date: Tue May 5 15:11:15 2020 -0400
Provide an update strategy for Tiller deployment
In the case of a simplex controller configuration the current patching
strategy for the Tiller environment will fail as the tiller ports will
be in use when the new deployment is attempted to be applied. The
resulting tiller pod will be stuck in a Pending state.
This will be observed if the node becomes ready after 'helm init'
installs the initial deployment and before the deployment is patched for
environment checks.
The deployment strategy provided by 'helm init' is unspecified. This
change will allow one additional pod (current + new) and one unavailable
pod (current) during an update. The maxUnavailable setting allows the
tiller pod to be deleted which will release its ports, thus allowing the
patch deployment to spin up an new pod to a Running state.
Change-Id: I83c43c52a77...
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (f/centos8) | #23 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 5c8377047ba679c
Author: Tao Liu <email address hidden>
Date: Tue May 5 08:59:59 2020 -0500
Move subcloud audit to separate process
Remove subcloud audit from dcmanager-manager process.
Create dcmanager-audit process & associated files.
Add new RPC calls for dcmanager-audit to notify dcmanager
subcloud availability and sync endpoint type changes.
Update dcmanager to handle availability and sync endpoint
type updates from dcmanager-audit.
Subcloud audit interval will be reduced to 20 seconds.
Create/update unit tests, to verify the implementation
changes.
Story: 2007267
Task: 39637
Change-Id: Iff408166753f22
Signed-off-by: Tao Liu <email address hidden>
commit d46516c46d24f8f
Author: albailey <email address hidden>
Date: Wed May 13 14:00:12 2020 -0500
Enable python3 unit tests as part of zuul
The existing py27 unit tests were not all passing in py36,
however now they are and so the zuul check and gate for py36
have been added.
Change-Id: Ie293ec69a04e6f
Story: 2004515
Task: 39768
Signed-off-by: albailey <email address hidden>
commit dbf603b4c45e865
Author: albailey <email address hidden>
Date: Mon May 11 10:29:45 2020 -0500
Reduce the number of suppressed pylint warnings
All pylint warnings were being suppressed by a wildcard.
This commit only suppresses the warnings that are failing and
prevents checks that would pass from being broken in later commits.
The warnings being suppressed can be resolved individually
by later submissions based on priority where appropriate.
This commit also specifies python3 for pylint which has
more recent checks.
Change-Id: Ie29aeb0ea3e9dc
Story: 2004515
Task: 39734
Signed-off-by: albailey <email address hidden>
commit 15fb58f45c0f552
Author: albailey <email address hidden>
Date: Fri May 8 13:20:23 2020 -0500
Enhance Upgrade strategy to use endpoint audit status
The distributed cloud audit was updated to include 'load'
endpoint status, so the upgrade strategy is now able to
make use of that information when constructing a strategy.
Change-Id: I69eb4d98b9abf3
Story: 2007403
Task: 39736
Signed-off-by: albailey <email address hidden>
commit acc710093bb1c95
Author: MCamp859 <email address hidden>
Date: Mon May 11 14:28:28 2020 -0400
Minor edits to test docs promote issue
Change-Id: I08ffc5e57b5b04
Signed-off-by: MCamp859 <email address hidden>
commit 6d4fa855462cc6f
Author: Tee Ngo <email address hidden>
Date: Mon May 4 23:53:20 2020 -0400
Extend subcloud audit...
stx.4.0 / medium priority - related to distributed cloud api.