Unable to use Horizon to save after specifying mandatory host info and install parameters

[Wendy Mitchell]

Brief Description
-----------------
Unexpectedly unable to Save in Horizon "Edit Host" dialog after specifying mandatory info for personality and install paramaters.

Severity
--------
standard.

Steps to Reproduce
------------------
1) lock, shutdown hoste eg. compute-7
2) performed a wipe disk and power up.
The host waits for a personality to be configured
3) Attempt to use Horizon Edit Host dialog to set the personality Worker
Set other mandatory field ie. host name eg. compute-7,
installation Parameters ie. boot device and rootfs device
Installation output eg. "text"

Note: Nothing else in the dialog is considered mandatory ie. these are the only fields with *

4) Select Save

Expected Behavior
------------------
The Save operation should succeed as all mandatory host info and Installation Parameters have been provided.

Actual Behavior
----------------
The user is directed to the Board Management tab where "No Board Management" is automatically selected from the drop down however a notice appears in red indicating
"Board management IP is required."
The Save operation does not complete.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
any
HW eg. PV-1

Branch/Pull Time/Commit
-----------------------
2020-02-15_00-10-00

Last Pass
---------

Timestamp/Logs
--------------

20:20:14,494 [admin f268e14c83e845bb831c094c699ea6d8] [admin 5a7f3814d6b84cb6a78c6ca97111253d] [POST /admin/13/update/ 200] parameters:[{"boot_device": "/dev/disk/by-path/pci-0000:00:1f.2-ata-5.0", "interfaceProfile": "", "bm_password": "********", "clock_synchronization": "ntp", "cpuProfile": "", "subfunctions": "worker", "hostname": "compute-7", "bm_ip": "", "console": "ttyS0,115200", "bm_username": "", "location": "", "host_id": "13", "diskProfile": "", "bm_confirm_password": "********", "bm_type": "none", "csrfmiddlewaretoken": "4r2Q48ZmVm6YovV0wF6DpHrFqpKNBfGyGcNQeLTpQJJEzw1KfERYLRe7oo3hnahC", "rootfs_device": "/dev/disk/by-path/pci-0000:00:1f.2-ata-5.0", "install_output": "text", "personality": "worker", "memoryProfile": ""}] message:[None]

Test Activity
-------------
Regression

Workaround
----------
used the cli to assign personality
system host-add -n compute-7 -p worker -m <MAC address> ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/709239

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709239
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=5f83c963ccd04670727bfac41040f76f0671fc0f
Submitter: Zuul
Branch: master

commit 5f83c963ccd04670727bfac41040f76f0671fc0f
Author: Bin Qian <email address hidden>
Date: Fri Feb 21 15:58:52 2020 -0500

    Fix unexpected denial of saving host due to BM IP required

    Fix unexpected denial of saving host data in horizon, due to Board
    Management IP not set when no Board Management Protocol is selected.

    Change-Id: I1a303b6b173767c4254cdd2921da187bfc96681b
    Closes-bug: 1864114
    Signed-off-by: Bin Qian <email address hidden>

[Wendy Mitchell (wmitchellwr)]

verified wcp-68
2020-03-13_04-10-00

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/716144

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716144
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=c794affbd62325e03635c41d4d769cd4213fff92
Submitter: Zuul
Branch: f/centos8

commit 654fb174857d81bb17234149c3f16014f8a41b2b
Author: Teresa Ho <email address hidden>
Date: Mon Mar 16 09:49:23 2020 -0400

    Add platform network type for storage

    Added a new platform network type for optional backend storage.

    Story: 2007391
    Task: 39018

    Change-Id: I8d10a2db50f1bfc055092b81e1872b4cb69242f0
    Signed-off-by: Teresa Ho <email address hidden>

commit 5d41bb083c384092792193297a67d0bcde675f27
Author: Stefan Dinescu <email address hidden>
Date: Tue Mar 10 12:55:33 2020 +0000

    Check for presence of Ceph storage backend

    Some Horizon operation and APIs worked on the assumption
    that the Ceph storage backend was always present. Since
    now Ceph is no longer provisioned by default, we need
    to update certain functions to check for the presence
    of such backend.

    Tests done:
    1. Install setup with Ceph
       - use Horizon to navigate to various pages and see
         if any errors appear
       - provision OSD using Horizon
    2. Install setup without Ceph
       - use Horizon to navigate to various pages and asee
         if any errors appear
       - see that options for Ceph operations are now hidden
         since Ceph is not provisioned

    Change-Id: I0ec1d0e73bf2c261c1ef35a35d8dd1f10d827fc4
    Closes-bug: 1866664
    Signed-off-by: Stefan Dinescu <email address hidden>

commit e3c2a190d06c83013fc4ae613c4b071e5b70dc97
Author: Kristine Bujold <email address hidden>
Date: Tue Feb 25 16:54:23 2020 -0500

    Add Subcloud ID to the Subclouds table's detail

    Story: 2007255
    Task: 38614
    Change-Id: I4b5f802410a3d6a6d27c887314c7a09aefad071b
    Signed-off-by: Kristine Bujold <email address hidden>

commit dbd25b92cdd8e3d9f2ac01a931a9df07c0b13044
Author: Kristine Bujold <email address hidden>
Date: Tue Feb 25 10:36:41 2020 -0500

    Fix label name in Regions pull down

    Story: 2007255
    Task: 38835
    Signed-off-by: Kristine Bujold <email address hidden>
    Change-Id: I6ddee15f406c1e06d4525d30bf9b381aa891f160

commit 03571b691d7ec16dd6151ee7e0d427ea9b7fb1be
Author: Kristine Bujold <email address hidden>
Date: Mon Feb 24 11:01:02 2020 -0500

    Fix data list formatting

    Change the Storage Overview page data list formatting to centered.

    Story: 2007255
    Task: 38835
    Change-Id: I0584a58f9a6a3fcb8860459e92b57d07b64e25e2
    Signed-off-by: Kristine Bujold <email address hidden>

commit b32ae659113c288684f7bedd016a1711a1dae12e
Author: Kristine Bujold <email address hidden>
Date: Fri Feb 21 10:53:42 2020 -0500

    Add table titles and update formatting

    This commits adds table titles to Host Inventory Storage and Storage
    Overview pages which have mutiple tables in one panel. It also use the
    upstream formatting for the table info for Host Inventory Processor
    page.

    Story: 2007255
    Task: 38835
    Change-Id:...