PTP configuration change for interface ptp_role doesn't take effect after unlock

[Anujeyan Manokeran]

Brief Description
-----------------
      After the configuration change on interface ptp_role from none to slave doesn’t take place immediately in the node after unlock. The file change on /etc/ptp4l.conf was happened after the process ptp4l was up. Due to this PTP slave clock is not getting locked to master clock . This issue was found when changing the configuration from management as slave and mechanishm e2e to ptp interface as slave and mechanishm p2p.

As a workaround another lock and unlock on the host was able to resolve this issue.

compute-1:/home/sysadmin# ls -l /etc/ptp4l.conf
-rw-r--r-- 1 root root 2144 Jan 31 20:57 /etc/ptp4l.conf
compute-1:/home/sysadmin# ps -ef | grep ptp4l
root 2550 1 0 20:56 ? 00:00:00 /usr/sbin/ptp4l -f /etc/ptp4l.conf

100.119 | compute-0 is not locked to remote PTP Grand Master | host=compute-0.ptp=no-lock | major | 2020-01-31T15:58:45.126562 |

compute-0:~$ date
Fri Jan 31 19:12:24 UTC 2020
compute-0:~$ sudo /usr/sbin/pmc -u -b 0 'GET TIME_STATUS_NP'
Password:
sending: GET TIME_STATUS_NP
        6805ca.fffe.3a1993-0 seq 0 RESPONSE MANAGEMENT TIME_STATUS_NP
                master_offset 5448284
                ingress_time 1580497950247092805
                cumulativeScaledRateOffset +0.000000000
                scaledLastGmPhaseChange 0
                gmTimeBaseIndicator 0
                lastGmPhaseChange 0x0000'0000000000000000.0000
                gmPresent true
                gmIdentity 6805ca.fffe.3a17b0

Severity
--------
Major

Steps to Reproduce
------------------
1. Pre setup as PTP slave as management and mechanism=e2e
2. lock the node to change PTP management to PTP slave and PTP interface as slave.
System host-lock compute-0
3. system host-if-modify compute-0 ptp0 --ptp-role slave
4. system host-if-modify compute-0 mgmt0 --ptp-role none
5. system host-unlock compute-0
6. Verify file change and process time. Verify master clock locked to slave.

System Configuration
--------------------
Regular system wcp-71-75

Expected Behavior
------------------
PTP configuration take effect after unlock

Actual Behavior
----------------
As per description failure

Reproducibility
---------------
reproduced re-execution application apply was unsuccessful.

Load
----
stx3.0 designer load as of " 2020-01-28_18-49-15"

Last Pass
---------
This was not tested. Since the lab(switch) was supporting either management as slave or only
 ptp interface is slave configuration. So only one configuration was tested per lab.

Timestamp/Logs
--------------

Test Activity
-------------
Regression test

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - ptp started with the incorrect config and requires an extra lock/unlock cycle. Medium priority as there is a workaround, but should be fixed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/707904

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707904
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=a82578526aecb2ce6562f4285756a7684adfc52e
Submitter: Zuul
Branch: master

commit a82578526aecb2ce6562f4285756a7684adfc52e
Author: David Sullivan <email address hidden>
Date: Fri Feb 14 15:39:23 2020 -0500

    Apply PTP configuration at runtime

    Allow PTP configuration to be applied at runtime. Introduce a new
    runtime class in the ptp manifest.

    Closes-Bug: 1861726
    Story: 2006759
    Task: 38771
    Change-Id: I279cf4f9bf72e19981d4204e8e3b4bab8dcd7ff3
    Signed-off-by: David Sullivan <email address hidden>

[Anujeyan Manokeran (anujeyan)]

This fix is verified .

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/716153

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716153
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=da2659f53aa94b9818dc78b28b739abd785e5546
Submitter: Zuul
Branch: f/centos8

commit ed763e6a5db5df4a0005dd57bd11b4c411557ea5
Author: Steven Webster <email address hidden>
Date: Sat Mar 28 17:23:16 2020 -0400

    Fix SR-IOV runtime manifest apply

    When an SR-IOV interface is configured, the platform's
    network runtime manifest is applied in order to apply the virtual
    function (VF) config and restart the interface. This results in
    sysinv being able to determine and populate the puppet hieradata
    with the virtual function PCI addresses.

    A side effect of the network manifest apply is that potentially
    all platform interfaces may be brought down/up if it is determined
    that their configuration has changed. This will likely be the case
    for a system which configures SR-IOV interfaces before initial
    unlock.

    A few issues have been encountered because of this, with some
    services not behaving well when the interface they are communicating
    over suddenly goes down.

    This commit makes the SR-IOV VF configuration much more targeted
    so that only the operation of setting the desired number of VFs
    is performed.

    Closes-Bug: #1868584

    Change-Id: Ic867fccae89fe8bc9173598c3c84c94ba2d7511f
    Signed-off-by: Steven Webster <email address hidden>

commit 1ca6d5914266fc7f424ec88e1a466b9f8ab5da9d
Author: Robert Church <email address hidden>
Date: Wed Mar 18 21:56:09 2020 -0400

    Add kubelet support for volume plugins

    When upversioning Calico from 3.6 to 3.12 the --volume-plugin-dir
    argument needs to be provided to kubelet.

    Specifically, the configuration for Calico 3.8 "Adds a Flex Volume
    Driver that creates a per-pod Unix Domain Socket to allow Dikastes to
    communicate with Felix over the Policy Sync API."

    Change-Id: Ic76baa00de4402cbb65c37fe89835b114d424634
    Story: 2006999
    Task: 39111
    Signed-off-by: Robert Church <email address hidden>

commit 17ce7aa97eb485807a46181b2a7db7e02641e245
Author: Jerry Sun <email address hidden>
Date: Fri Mar 13 12:44:48 2020 -0400

    Remove creation of /etc/kuberetes/kubeadm.yaml

    Now that we are not using /etc/kubernetes/kubeadm.yaml anymore,
    we can remove the creation of the file from puppet. Bootstrap will
    still create it for bootstrap use.

    Change-Id: Id08af049fac3fc68b70a7dae5aec8548865a4784
    Closes-bug: 1866695
    Depends-On: https://review.opendev.org/#/c/713020/
    Signed-off-by: Jerry Sun <email address hidden>

commit 027727470da6dcbf3641ff2a701d0c7561476920
Author: Jerry Sun <email address hidden>
Date: Wed Mar 11 14:18:15 2020 -0400

    Clean up change_apiserver_parameters in kubernetes puppet

    Move excess puppet execs into the template already used in the class

    Story: 2006711
    Task: 38944

    Change-Id: Iad54064fa4056f9f30406646c95623a1e7c25bec
    Signed-off-by: Jerry Sun <email address hidden>

commit b39136dc686549c1c937ba30d885ed6958603dba
Author: J...