Unmanage/manage a subcloud causes sysinv api exception in subcloud

[Bart Wensley]

Brief Description
-----------------
In a distributed cloud deployment, when a subcloud is unmanaged and then managed again, the following exception appears in the sysinv logs on each subcloud:
sysinv 2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest [-] A TrapDest with UUID e6f1dca1-6fa0-4272-997c-945bd366aec6 already exists.: TrapDestAlreadyExists: A TrapDest with UUID e6f1dca1-6fa0-4272-997c-945bd366aec6 already exists.
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest Traceback (most recent call last):
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/trapdest.py", line 189, in post
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest new_itrapdest = pecan.request.dbapi.itrapdest_create(itrapdest.as_dict())
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest File "/usr/lib64/python2.7/site-packages/sysinv/objects/__init__.py", line 106, in wrapper
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest result = fn(*args, **kwargs)
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest File "/usr/lib64/python2.7/site-packages/sysinv/db/sqlalchemy/api.py", line 3332, in itrapdest_create
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest raise exception.TrapDestAlreadyExists(uuid=values['uuid'])
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest TrapDestAlreadyExists: A TrapDest with UUID e6f1dca1-6fa0-4272-997c-945bd366aec6 already exists.
2020-01-22 14:00:03.016 99413 ERROR sysinv.api.controllers.v1.trapdest

Severity
--------
Unknown - I don't know the functional impact of this exception

Steps to Reproduce
------------------
Install a distributed cloud system with at least one subcloud.
Unmanage and manage the subcloud.

Expected Behavior
------------------
Managing a subcloud should not result in exceptions.

Actual Behavior
----------------
Managing the subcloud causes an exception in the sysinv API in the subcloud.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Distributed cloud with AIO-DX system controller and AIO-SX subcloud.

Branch/Pull Time/Commit
-----------------------
Designer load built on January 16, 2020.

Last Pass
---------
Unknown

Timestamp/Logs
--------------
See above

Test Activity
-------------
Developer Testing

Workaround
----------
None

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - unexpected exception on DC.

[Dariush Eslimi (deslimi)]

There has been many improvement in this area, please retest.

[Jessica Castelino (jcasteli)]

Unable to reproduce this on a load built on 29th April 2020 using the below mentioned steps:

1) Manage a subcloud
2) Added a community on the system controller. Added a trapdest in SystemController region and passed the community created in the previous step as an argument
4) Unmanaged the subcloud once the audit has been completed (verified trapdest is synched to the subcloud)
5) Managed the subcloud again