build-helm-charts.sh can't handle image records using hostnames with hyphens or ports
Bug #1860465 reported by
Joseph Richard
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Medium
|
Joseph Richard |
Bug Description
When building helm charts with the image-record option passed in, the script will update the generated manifest to replace the image version with that of the image record.
The code to do this for each image record works by looking through all images in the manifest, and replacing any that match an old_image_reference for that record with a new image_reference that contains the image_record.
This currently does not work when an image record contains a hostname that has a hyphen in it, or that contains a hostname:port.
old_image_
should be
old_image_
Changed in starlingx: | |
assignee: | nobody → Joseph Richard (josephrichard) |
To post a comment you must log in.
Reviewed: https:/ /review. opendev. org/703659 /git.openstack. org/cgit/ starlingx/ root/commit/ ?id=6cadc457483 c7ce194e1f2f58f 07cc3434eb20a7
Committed: https:/
Submitter: Zuul
Branch: master
commit 6cadc457483c7ce 194e1f2f58f07cc 3434eb20a7
Author: Joseph Richard <email address hidden>
Date: Tue Jan 21 12:08:40 2020 -0500
Update old_image_reference regex
This commit updates the old_image_reference regex to correctly handle
images records using a hostname with hyphens and/or a port specified.
Closes-bug: 1860465 4b133d0fd680295 55ceea3e18d
Change-Id: Ibf88d1c675277d
Signed-off-by: Joseph Richard <email address hidden>