HORIZON Platform->Inventory->Storage incorrectly greys out 'add physical volume'

[Greg Waines]

Brief Description
-----------------
I was trying to add a partition to the cgts-vg on a worker node in order to increase the size of the /scratch file system.

I added an new partition thru HORIZON.
I then locked the worker node.
But, using HORIZON, I could NOT add the new partition to cgts-vg because the 'Add Physical Volume' button was greyed out with the reason 'no nova-local lvg'

Using the CLI ... it allowed me to do it
e.g.
[sysadmin@controller-0 ~(keystone_admin)]$ system host-pv-add worker-0 cgts-vg 93e431b4-e9c9-4b31-bc5a-81d4345206cc
+--------------------------+--------------------------------------------------+
| Property | Value |
+--------------------------+--------------------------------------------------+
| uuid | d190d0dc-4940-4d92-a267-8adc32dd209b |
| pv_state | adding |
| pv_type | partition |
| disk_or_part_uuid | 93e431b4-e9c9-4b31-bc5a-81d4345206cc |
| disk_or_part_device_node | /dev/sda5 |
| disk_or_part_device_path | /dev/disk/by-path/pci-0000:00:17.0-ata-1.0-part5 |
| lvm_pv_name | /dev/sda5 |
| lvm_vg_name | cgts-vg |
| lvm_pv_uuid | None |
| lvm_pv_size_gib | 0.0 |
| lvm_pe_total | 0 |
| lvm_pe_alloced | 0 |
| ihost_uuid | fb375911-bf55-4bef-8de0-0b821aaef64a |
| created_at | 2020-01-16T17:36:49.995944+00:00 |
| updated_at | None |
+--------------------------+--------------------------------------------------+
[sysadmin@controller-0 ~(keystone_admin)]$

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
See description

Expected Behavior
------------------
Horizon does not grey the button out so I can add the new partition to cgts-vg using HORIZON

Actual Behavior
----------------
Button is greyed out

Reproducibility
---------------
100%

System Configuration
--------------------
Dedicated storage ... in my particular case

Branch/Pull Time/Commit
-----------------------
STX 3.0

Last Pass
---------
Not sure if this ever worked.

Timestamp/Logs
--------------
n/a

Test Activity
-------------
[Other - lab deployment]

 Workaround
 ----------
See Description ... use the CLI.

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - option not available from horizon; would be nice to fix for 4.0

[Ghada Khalil (gkhalil)]

Lowering the priority - this is still a would-be-nice to fix, but strictly speaking does not gate stx.4.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/738462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738462
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=73b77d5d526af66bed2c41975635febedf685162
Submitter: Zuul
Branch: master

commit 73b77d5d526af66bed2c41975635febedf685162
Author: Kristine Bujold <email address hidden>
Date: Mon Jun 29 11:05:40 2020 -0400

    Update restrictions on Physical Volume

    Physical Volume had restrictions which were no longer valid.

    Closes-Bug: 1860139
    Change-Id: I89e6c5aa429875171fc7e083e35057b61d920b95
    Signed-off-by: Kristine Bujold <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/792252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/gui/+/792252
Committed: https://opendev.org/starlingx/gui/commit/63d6de4701a7f21779ad9ea4060fce9ed85bc71f
Submitter: "Zuul (22348)"
Branch: f/centos8

commit e05e1a43531499d94cfb1e538683ee36eea92b43
Author: Teresa Ho <email address hidden>
Date: Thu May 13 23:04:04 2021 -0400

    Do not display primary_reselect if not specified

    If the attribute 'primary_reselect' is not specified, the sysinv API
    will leave it as null and GUI will not display the attribute.

    Closes-Bug: 1928461

    Change-Id: I5b8ef8b29fb7775dde8607bb14cd733015269f82
    Signed-off-by: Teresa Ho <email address hidden>

commit f1a4d30eca91c7a239ebd7479a56fef7870a4b2e
Author: Pablo Bovina <email address hidden>
Date: Fri May 7 16:59:50 2021 -0300

    Display DataNetworks list

    DataNetworks are listed for pci-sriov
    under Create/Edit Interface forms.

    Closes-bug: 1927782
    Signed-off-by: Pablo Bovina <email address hidden>
    Change-Id: If927bb0facdec9e587a13354bef56eca5df08785

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu May 6 07:32:59 2021 -0400

    In AIO-SX, interface edit rejected with Host administrative unlocked

    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".

    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.

    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):

    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected

    Locked state:
    all conversions (with network/datanetwork assignment) are accepted

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

commit ddcc4fd3ccb4c02580c71414345993252b089761
Author: Enzo Candotti <email address hidden>
Date: Tue May 4 11:08:57 2021 -0300

    Enable add/edit Worker personality on DC AIO-DX's GUI

    This update is to allow the option to add a new host with Worker
    personality on Distributed Cloud mode.

    Closes-Bug: 1927107

    Signed-off-by: Enzo Candotti <email address hidden>
    Change-Id: Idfed9352c7c6467014a2ed2cf10b70f6b470c28c

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fer...

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Bart Wensley <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/765064
Reason: This patch has been idle for more than six months. I am abandoning it to keep the review queue sane. If you are still interested in working on this patch, please unabandon it and upload a new patchset.