sriov test suite fails to verify error types (false negatives)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| StarlingX |
Medium
|
Thomas Gao |
Bug Description
Brief Description
-----------------
Several tests in sysinv/
For example, for test_invalid_
Those false-negative tests include:
- test_invalid_
- test_invalid_
- test_invalid_
- test_invalid_
Severity
--------
Minor: System/Feature is usable with minor issue
Steps to Reproduce
------------------
In the development repo:
> cd cgcs-root/
> tox -e py27 test_invalid_
Expected Behavior
------------------
Test should fail when the function doesn't start with `self._
Actual Behavior
----------------
Test succeeds when the function doesn't start with `self._
Reproducibility
---------------
100% Reproducible
System Configuration
-------
Any machine that's set up for development.
Branch/Pull Time/Commit
-------
master; 1/16/2020; 737b98c4562c6ad
Last Pass
---------
new test scenario
Test Activity
-------------
Feature Testing
description: | updated |
description: | updated |
Changed in starlingx: | |
assignee: | nobody → Thomas Gao (tgao) |
Ghada Khalil (gkhalil) wrote : | #1 |
tags: | added: stx.4.0 stx.config |
Changed in starlingx: | |
importance: | Undecided → Medium |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit c22e5787c8308b6
Author: Thomas Gao <email address hidden>
Date: Thu Jan 16 14:38:32 2020 -0500
Verified types of errors for sriov test suites.
Verification is done by checking whether certain messages
are shown in the response.
error message "Unable to provision pci-sriov interface
without configured mgmt interface" is promptly caught, causing
the test to fail, as expected.
Since the intended error message is supposed to be something
that's not "Unable to provision pci-sriov interface without
configured mgmt interface," I added mgmt interface
configuration so the test won't fail.
Closes-Bug: 1860030
Change-Id: I6a2f11d6cf5b37
Signed-off-by: Thomas Gao <email address hidden>
Changed in starlingx: | |
status: | In Progress → Fix Released |
tags: | added: stx.zuul |
Fix proposed to branch: f/centos8
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 7995dd436954b92
Author: Jessica Castelino <email address hidden>
Date: Mon Feb 3 12:07:26 2020 -0500
Unit test cases for helm charts
Test cases added for API endpoints used by:
1. helm-override-
2. helm-override-show
3. helm-override-list
4. helm-override-
5. helm-chart-
Story: 2007082
Task: 38012
Change-Id: I86763496bb4108
Signed-off-by: Jessica Castelino <email address hidden>
commit 7e2fda010299f73
Author: Angie Wang <email address hidden>
Date: Wed Jan 29 21:18:18 2020 -0500
Finish kubernetes networking upgrade support
The commit completes the RPC kube_upgrade_
in sysinv-conductor to run ansible playbook
upgrade-
and also updates the networking upgrade function called
as part of sysinv-conductor startup to provide a current
kubernetes version when running the upgrade playbook.
The second control plane upgrade can only be performed
after the networking upgrade is done, fix the semantic
check in sysinv api.
Change-Id: I8dcf5a2baedfae
Story: 2006781
Task: 37584
Depends-On: https:/
Signed-off-by: Angie Wang <email address hidden>
commit 52c37a35d2cd62f
Author: Jerry Sun <email address hidden>
Date: Fri Jan 31 16:10:25 2020 -0500
Add Unit Tests for Dex Sysinv Changes
Add unit tests for the dex helm chart changes under the same story
and task
Story: 2006711
Task: 37857
Depends-On: https:/
Change-Id: I3a0e1c490e5618
Signed-off-by: Jerry Sun <email address hidden>
commit 144587a6ac9fc48
Author: Teresa Ho <email address hidden>
Date: Fri Jan 31 15:35:04 2020 -0500
Tox tests for OIDC client helm overrides
Added some tox tests for OIDC client helm overrides.
Story: 2006711
Task: 38481
Change-Id: If4aeaf0010c707
Signed-off-by: Teresa Ho <email address hidden>
commit 763ddeadd4e83af
Author: Thomas Gao <email address hidden>
Date: Wed Jan 29 16:30:40 2020 -0500
Fixed errors in address deletion
Allowed address deletion despite missing associated interface or host.
Enabled relevant unit test.
Closes-Bug: 1860186
Change-Id: Ie6e6358aa75091
Signed-off-by: Thomas Gao <email address hidden>
commit 61463608169e756
Author: Thomas Gao <email address hidden>
Date: Tue Jan 28 15:32:58 2020 -0500
Fixed broken sysinv address get-all api call
Removed unexpected keyword argument that caused the error....
tags: | added: in-f-centos8 |
stx.4.0 / medium priority given the focus on increasing unit test coverage