k8s app: app_name and Armada operator specification

[John Kung]

Brief Description
-----------------
Allow kubernetes application, which is applied via system application-apply, to:
 - specify its app_name in it’s application meta-data
 - specify Armada manifest operator

Severity
--------
Provide the severity of the defect.
Minor: System/Feature is usable with minor issue. This allows flexibility for
application.

Steps to Reproduce
------------------
build-helm-charts <app>
system application-upload <app_name>
system application-apply <app_name>

Expected Behavior
------------------
Expect app_name to be as specified in application metadata and system application
to load the stevedore plugins according to latest version.

Actual Behavior
----------------
Currently, the app_name must match the parameter passed into build-helm-charts and
stevedore only loads the Armada operator based without a particular order.

Reproducibility
---------------
Reproducible.

System Configuration
--------------------
All systems.

Branch/Pull Time/Commit
-----------------------
All StarlingX branches; this is for stx4.0

Test Activity
-------------
Designer Test

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/702984

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/702985

[Ghada Khalil (gkhalil)]

stx.4.0 / medium priority - small enhancement to k8s application handling

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702984
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=31aea8e88b2f0e2fe90e3b802a2ffff3c230b212
Submitter: Zuul
Branch: master

commit 31aea8e88b2f0e2fe90e3b802a2ffff3c230b212
Author: John Kung <email address hidden>
Date: Thu Jan 16 16:03:27 2020 -0500

    Allow application to specify app_name in metadata

    Update build-helm-charts to allow application to optionally specify app_name.
    The script was ignoring app_name if it was already specified in the metadata;
    this updates it to accept the app_name if specified, otherwise default to
    APP_NAME as specified in command line for the tarball.

    Change-Id: I9368b3a8a7c3d50981f02fe7c4a5e4be8255cfc3
    Partial-Bug: 1859882
    Signed-off-by: John Kung <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702985
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=11929c129e6417b60297e36ab80d0836ce205366
Submitter: Zuul
Branch: master

commit 11929c129e6417b60297e36ab80d0836ce205366
Author: John Kung <email address hidden>
Date: Thu Jan 16 15:57:47 2020 -0500

    Allow versioned Armada operators to be loaded

    Enable the uploading of newer version of Armada manifest operator
    for an application by checking for a suffix and overriding with the
    latest numerically versioned suffix.

    Change-Id: Ie1e2d9f68743236194ae184668cfbe037f6c415e
    Partial-Bug: 1859882
    Signed-off-by: John Kung <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/705827

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/705837

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705837
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=8ac6ec70cb8a787a274fd7227eb34d2b7bcd5f5b
Submitter: Zuul
Branch: f/centos8

commit 7995dd436954b92f1c4e3f760a7609af670c84c8
Author: Jessica Castelino <email address hidden>
Date: Mon Feb 3 12:07:26 2020 -0500

    Unit test cases for helm charts

    Test cases added for API endpoints used by:
     1. helm-override-delete
     2. helm-override-show
     3. helm-override-list
     4. helm-override-update
     5. helm-chart-attribute-modify

    Story: 2007082
    Task: 38012
    Change-Id: I86763496bb41084c006f2486702c3b15bde039d2
    Signed-off-by: Jessica Castelino <email address hidden>

commit 7e2fda010299f7305b630d6db97bbe1e169a38b1
Author: Angie Wang <email address hidden>
Date: Wed Jan 29 21:18:18 2020 -0500

    Finish kubernetes networking upgrade support

    The commit completes the RPC kube_upgrade_networking
    in sysinv-conductor to run ansible playbook
    upgrade-k8s-networking.yml to upgrade networking pods
    and also updates the networking upgrade function called
    as part of sysinv-conductor startup to provide a current
    kubernetes version when running the upgrade playbook.

    The second control plane upgrade can only be performed
    after the networking upgrade is done, fix the semantic
    check in sysinv api.

    Change-Id: I8dcf5a2baedfaefb0a7ca037eb47bf7cacd686f8
    Story: 2006781
    Task: 37584
    Depends-On: https://review.opendev.org/#/c/705310/
    Signed-off-by: Angie Wang <email address hidden>

commit 52c37a35d2cd62fa1cc1933765c76c1ba8616864
Author: Jerry Sun <email address hidden>
Date: Fri Jan 31 16:10:25 2020 -0500

    Add Unit Tests for Dex Sysinv Changes

    Add unit tests for the dex helm chart changes under the same story
    and task

    Story: 2006711
    Task: 37857

    Depends-On: https://review.opendev.org/#/c/705297/

    Change-Id: I3a0e1c490e56188adfbd614fd6ebb21bfdddf49e
    Signed-off-by: Jerry Sun <email address hidden>

commit 144587a6ac9fc48b9249be99abadd35dfa49e7a7
Author: Teresa Ho <email address hidden>
Date: Fri Jan 31 15:35:04 2020 -0500

    Tox tests for OIDC client helm overrides

    Added some tox tests for OIDC client helm overrides.

    Story: 2006711
    Task: 38481

    Change-Id: If4aeaf0010c7076d1d83bacd00d6fd0122d4ffad
    Signed-off-by: Teresa Ho <email address hidden>

commit 763ddeadd4e83af6cebf752d693ee3e7d3b005b1
Author: Thomas Gao <email address hidden>
Date: Wed Jan 29 16:30:40 2020 -0500

    Fixed errors in address deletion

    Allowed address deletion despite missing associated interface or host.

    Enabled relevant unit test.

    Closes-Bug: 1860186

    Change-Id: Ie6e6358aa75091e92914a8b581b4d5203a596f56
    Signed-off-by: Thomas Gao <email address hidden>

commit 61463608169e75601b8a4f9db7c98190788d6f6a
Author: Thomas Gao <email address hidden>
Date: Tue Jan 28 15:32:58 2020 -0500

    Fixed broken sysinv address get-all api call

    Removed unexpected keyword argument that caused the error....

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/705827
Committed: https://git.openstack.org/cgit/starlingx/root/commit/?id=b7abdd160cc11bb86bdb876db0230b9f5160eccd
Submitter: Zuul
Branch: f/centos8

commit b864e153ddac995cb111b583a9d9e0c58a567387
Author: Don Penney <email address hidden>
Date: Tue Jan 21 17:04:10 2020 -0500

    Support source patches for building images

    The build-stx-images.sh allows for building images using a git repo as
    the source, which is cloned into the workspace as part of the build
    procedure. In some cases, there may be source changes required for
    fixes or enhancements that have not yet merged into the referenced
    repo. This update adds support in build-stx-images to allow the
    designer to specify patches in the image directives file, which will
    be applied after cloning.

    Designer workflow:
    * clone git repo (may need to apply any existing git patches from
    previous fixes)
    * make changes
    * commit, with a beautiful and admirable commit message
    * git format-patch
    * copy source patch to stx repo, somewhere alongside the docker_image
    directives file (ie. a docker_patches dir)
    * update docker_image directives file to add DOCKER_REPO_PATCHES or
    SOURCE_PATCHES, as appropriate, with DOCKER_REF or SOURCE_REF set to
    the current upstream SHA used as the base for the patch

    Story: 2006711
    Task: 38499
    Change-Id: Icac2b4dc2ebeb32946de6e5adcbf59a10c56a30c
    Signed-off-by: Don Penney <email address hidden>

commit 6cadc457483c7ce194e1f2f58f07cc3434eb20a7
Author: Joseph Richard <email address hidden>
Date: Tue Jan 21 12:08:40 2020 -0500

    Update old_image_reference regex

    This commit updates the old_image_reference regex to correctly handle
    images records using a hostname with hyphens and/or a port specified.

    Closes-bug: 1860465
    Change-Id: Ibf88d1c675277d4b133d0fd68029555ceea3e18d
    Signed-off-by: Joseph Richard <email address hidden>

commit e443a2c736e891226bcd2f5b08ade79a3aceaf02
Author: Lin Shuicheng <email address hidden>
Date: Sun Jan 19 01:15:50 2020 +0000

    Revert "Revert "add kata rpms to ISO""

    This reverts commit 4c7595db02ac250cdf8f04fd49df7a401c8bfb7e.

    Depends-On: https://review.opendev.org/703263

    Change-Id: Iefc0bafb369e3897e1028b33c45303d18f93a24b
    Signed-off-by: Shuicheng Lin <email address hidden>

commit 31aea8e88b2f0e2fe90e3b802a2ffff3c230b212
Author: John Kung <email address hidden>
Date: Thu Jan 16 16:03:27 2020 -0500

    Allow application to specify app_name in metadata

    Update build-helm-charts to allow application to optionally specify app_name.
    The script was ignoring app_name if it was already specified in the metadata;
    this updates it to accept the app_name if specified, otherwise default to
    APP_NAME as specified in command line for the tarball.

    Change-Id: I9368b3a8a7c3d50981f02fe7c4a5e4be8255cfc3
    Partial-Bug: 1859882
    Signed-off-by: John Kung <email address hidden>

commit b5bfa6087e7e131fdff107029f33fb46205e0884
Author: Don Penney <email address hidden>
Date: Wed Jan 15 23...

[Ghada Khalil (gkhalil)]

Marking as Fix Released after confirming with the developer, John Kung. The fixes submitted to date address this issue.